From ffe980977cbae8fb556be9b765a217e3986a9aef Mon Sep 17 00:00:00 2001 From: Cristy Date: Wed, 27 Sep 2023 23:03:21 -0400 Subject: [PATCH] correct exit code (https://github.com/ImageMagick/ImageMagick/issues/6744) --- MagickWand/compare.c | 7 ++++++- MagickWand/composite.c | 7 ++++++- MagickWand/conjure.c | 7 ++++++- MagickWand/convert.c | 7 ++++++- MagickWand/identify.c | 7 ++++++- MagickWand/mogrify.c | 7 ++++++- MagickWand/montage.c | 7 ++++++- MagickWand/stream.c | 7 ++++++- 8 files changed, 48 insertions(+), 8 deletions(-) diff --git a/MagickWand/compare.c b/MagickWand/compare.c index 85552b64f1..7a4eb2571a 100644 --- a/MagickWand/compare.c +++ b/MagickWand/compare.c @@ -292,7 +292,12 @@ WandExport MagickBooleanType CompareImagesCommand(ImageInfo *image_info, } } if (argc < 3) - return(CompareUsage()); + { + (void) ThrowMagickException(exception,GetMagickModule(),OptionError, + "MissingArgument","%s",""); + (void) CompareUsage(); + return(MagickFalse); + } difference_image=NewImageList(); similarity_image=NewImageList(); dissimilarity_threshold=DefaultDissimilarityThreshold; diff --git a/MagickWand/composite.c b/MagickWand/composite.c index 0992e962a5..2209d29b19 100644 --- a/MagickWand/composite.c +++ b/MagickWand/composite.c @@ -488,7 +488,12 @@ WandExport MagickBooleanType CompositeImageCommand(ImageInfo *image_info, } } if (argc < 4) - return(CompositeUsage()); + { + (void) ThrowMagickException(exception,GetMagickModule(),OptionError, + "MissingArgument","%s",""); + (void) CompositeUsage(); + return(MagickFalse); + } GetCompositeOptions(image_info,&composite_options); filename=(char *) NULL; format="%w,%h,%m"; diff --git a/MagickWand/conjure.c b/MagickWand/conjure.c index 66147bff89..83c03fc750 100644 --- a/MagickWand/conjure.c +++ b/MagickWand/conjure.c @@ -168,7 +168,12 @@ WandExport MagickBooleanType ConjureImageCommand(ImageInfo *image_info, if (IsEventLogging() != MagickFalse) (void) LogMagickEvent(TraceEvent,GetMagickModule(),"..."); if (argc < 2) - return(ConjureUsage()); + { + (void) ThrowMagickException(exception,GetMagickModule(),OptionError, + "MissingArgument","%s",""); + (void) ConjureUsage(); + return(MagickFalse); + } image=NewImageList(); number_images=0; option=(char *) NULL; diff --git a/MagickWand/convert.c b/MagickWand/convert.c index 91f0d20479..d08979877f 100644 --- a/MagickWand/convert.c +++ b/MagickWand/convert.c @@ -558,7 +558,12 @@ WandExport MagickBooleanType ConvertImageCommand(ImageInfo *image_info, } } if (argc < 3) - return(ConvertUsage()); + { + (void) ThrowMagickException(exception,GetMagickModule(),OptionError, + "MissingArgument","%s",""); + (void) ConvertUsage(); + return(MagickFalse); + } filename=(char *) NULL; format="%w,%h,%m"; j=1; diff --git a/MagickWand/identify.c b/MagickWand/identify.c index cd4e39198a..34521f89da 100644 --- a/MagickWand/identify.c +++ b/MagickWand/identify.c @@ -241,7 +241,12 @@ WandExport MagickBooleanType IdentifyImageCommand(ImageInfo *image_info, } } if (argc < 2) - return(IdentifyUsage()); + { + (void) ThrowMagickException(exception,GetMagickModule(),OptionError, + "MissingArgument","%s",""); + (void) IdentifyUsage(); + return(MagickFalse); + } count=0; format=NULL; j=1; diff --git a/MagickWand/mogrify.c b/MagickWand/mogrify.c index 45a0920102..3abdec512b 100644 --- a/MagickWand/mogrify.c +++ b/MagickWand/mogrify.c @@ -3789,7 +3789,12 @@ WandExport MagickBooleanType MogrifyImageCommand(ImageInfo *image_info, } } if (argc < 2) - return(MogrifyUsage()); + { + (void) ThrowMagickException(exception,GetMagickModule(),OptionError, + "MissingArgument","%s",""); + (void) MogrifyUsage(); + return(MagickFalse); + } format=(char *) NULL; path=(char *) NULL; global_colormap=MagickFalse; diff --git a/MagickWand/montage.c b/MagickWand/montage.c index 79cce6e6b4..ad887aeeb3 100644 --- a/MagickWand/montage.c +++ b/MagickWand/montage.c @@ -327,7 +327,12 @@ WandExport MagickBooleanType MontageImageCommand(ImageInfo *image_info, } } if (argc < 3) - return(MontageUsage()); + { + (void) ThrowMagickException(exception,GetMagickModule(),OptionError, + "MissingArgument","%s",""); + (void) MontgagUsage(); + return(MagickFalse); + } format="%w,%h,%m"; first_scene=0; j=1; diff --git a/MagickWand/stream.c b/MagickWand/stream.c index 14a77479c2..b0d01979ba 100644 --- a/MagickWand/stream.c +++ b/MagickWand/stream.c @@ -224,7 +224,12 @@ WandExport MagickBooleanType StreamImageCommand(ImageInfo *image_info, } } if (argc < 3) - return(StreamUsage()); + { + (void) ThrowMagickException(exception,GetMagickModule(),OptionError, + "MissingArgument","%s",""); + (void) StreamUsage(); + return(MagickFalse); + } format="%w,%h,%m"; (void) format; j=1;