mirror of
https://git.sr.ht/~rjarry/aerc
synced 2026-09-30 12:15:45 +02:00
Simon SigurdhssonandJason Cox
556a312cdc
With5f91f4ff7d, message flags are essentially only updated in the message store if the ReplaceFlags field is set. The IMAP backend sets this flag correctly when `:flag` triggers a flag update, but all other backends relied on the old behavior where flags were unconditionally updated. This caused a regression where these backends no longer update the UI correctly after running `:flag` and friends. Set the ReplaceFlags field in these cases, which should be safe for both mbox and maildir. The JMAP backend also only triggers the MessageInfo update once it *knows* that the operation succeeded (just as IMAP does based on4cfc71b1be), so the change should be safe for JMAP as well. Fixes:5f91f4ff7d("msgstore: preserve message flags on header updates") Link: https://lists.sr.ht/~rjarry/aerc-discuss/%3CDKFJHNNJAGRR.RE124BP26HQ5@gmx.fr%3E Changelog-fixed: Flag changes through `:flag` et. al. are now correctly reflected in the UI again for non-IMAP backends. Reported-by: Philippe SWARTVAGHER <phil.swart@gmx.fr> Co-authored-by: Jason Cox <me@jasoncarloscox.com> Signed-off-by: Simon Sigurdhsson <me@urdh.eu> Acked-by: Simon Martin <simon@nasilyan.com>