mirror of
https://git.sr.ht/~rjarry/aerc
synced 2026-03-02 18:23:33 +01:00
73dc39c6ee
Add a new models.UID type (an alias to string). Replace all occurrences of uint32 being used as message UID or thread UID with models.UID. Update all workers to only expose models.UID values and deal with the conversion internally. Only IMAP needs to convert these to uint32. All other backends already use plain strings as message identifiers, in which case no conversion is even needed. The directory tree implementation needed to be heavily refactored in order to accommodate thread UID not being usable as a list index. Signed-off-by: Robin Jarry <robin@jarry.cc> Tested-by: Inwit <inwit@sindominio.net> Tested-by: Tim Culverhouse <tim@timculverhouse.com>
97 lines
2.4 KiB
Go
97 lines
2.4 KiB
Go
package iterator_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"git.sr.ht/~rjarry/aerc/lib/iterator"
|
|
"git.sr.ht/~rjarry/aerc/models"
|
|
"git.sr.ht/~rjarry/aerc/worker/types"
|
|
)
|
|
|
|
func toThreads(uids []models.UID) []*types.Thread {
|
|
threads := make([]*types.Thread, len(uids))
|
|
for i, u := range uids {
|
|
threads[i] = &types.Thread{Uid: u}
|
|
}
|
|
return threads
|
|
}
|
|
|
|
func TestIterator_DefaultFactory(t *testing.T) {
|
|
input := []models.UID{"1", "2", "3", "4", "5", "6", "7", "8", "9"}
|
|
want := []models.UID{"9", "8", "7", "6", "5", "4", "3", "2", "1"}
|
|
|
|
factory := iterator.NewFactory(false)
|
|
if factory == nil {
|
|
t.Errorf("could not create factory")
|
|
}
|
|
start, end := len(input)-1, 0
|
|
checkUids(t, factory, input, want, start, end)
|
|
checkThreads(t, factory, toThreads(input),
|
|
toThreads(want), start, end)
|
|
}
|
|
|
|
func TestIterator_ReverseFactory(t *testing.T) {
|
|
input := []models.UID{"1", "2", "3", "4", "5", "6", "7", "8", "9"}
|
|
want := []models.UID{"1", "2", "3", "4", "5", "6", "7", "8", "9"}
|
|
|
|
factory := iterator.NewFactory(true)
|
|
if factory == nil {
|
|
t.Errorf("could not create factory")
|
|
}
|
|
|
|
start, end := 0, len(input)-1
|
|
checkUids(t, factory, input, want, start, end)
|
|
checkThreads(t, factory, toThreads(input),
|
|
toThreads(want), start, end)
|
|
}
|
|
|
|
func checkUids(t *testing.T, factory iterator.Factory,
|
|
input []models.UID, want []models.UID, start, end int,
|
|
) {
|
|
label := "uids"
|
|
got := make([]models.UID, 0)
|
|
iter := factory.NewIterator(input)
|
|
for iter.Next() {
|
|
got = append(got, iter.Value().(models.UID))
|
|
}
|
|
if len(got) != len(want) {
|
|
t.Errorf(label + "number of elements not correct")
|
|
}
|
|
for i, u := range want {
|
|
if got[i] != u {
|
|
t.Errorf(label + "order not correct")
|
|
}
|
|
}
|
|
if iter.StartIndex() != start {
|
|
t.Errorf(label + "start index not correct")
|
|
}
|
|
if iter.EndIndex() != end {
|
|
t.Errorf(label + "end index not correct")
|
|
}
|
|
}
|
|
|
|
func checkThreads(t *testing.T, factory iterator.Factory,
|
|
input []*types.Thread, want []*types.Thread, start, end int,
|
|
) {
|
|
label := "threads"
|
|
got := make([]*types.Thread, 0)
|
|
iter := factory.NewIterator(input)
|
|
for iter.Next() {
|
|
got = append(got, iter.Value().(*types.Thread))
|
|
}
|
|
if len(got) != len(want) {
|
|
t.Errorf(label + "number of elements not correct")
|
|
}
|
|
for i, th := range want {
|
|
if got[i].Uid != th.Uid {
|
|
t.Errorf(label + "order not correct")
|
|
}
|
|
}
|
|
if iter.StartIndex() != start {
|
|
t.Errorf(label + "start index not correct")
|
|
}
|
|
if iter.EndIndex() != end {
|
|
t.Errorf(label + "end index not correct")
|
|
}
|
|
}
|