Files
merge-script 8c49a9abe9 Merge bitcoin/bitcoin#36151: makeseeds: fix off-by-one in field count check
c786052865 makeseeds: fix off-by-one in field count check (aman21-droid)

Pull request description:

  Fixes #36146.

  `parseline()` checks that a line has at least 11 whitespace-separated fields:

  ```python
  if len(sline) < 11:
      # line too short to be valid, skip it.
      return None
  ```

  but it later reads `sline[11]` (the user agent), which needs 12. A line with exactly 11 fields got past the check and then raised `IndexError`, aborting the whole run instead of skipping that line. 11 is the highest index the function uses, so the check now requires 12 fields.

  This isn't only theoretical: README.md builds seeds_main.txt by appending one crawler's output onto another's, so the file mixes two independently maintained formats, and a truncated download leaves a short last line too. Skipping the line is what the check was already trying to do.

ACKs for top commit:
  maflcko:
    lgtm ACK c786052865
  l0rinc:
    ACK c786052865

Tree-SHA512: 3c3aeb8876b7e0eccf8f03faafe0e0bb71d1b11924feaf22b2bb6bf1a36e25bedd622de257060de873c42f12fba8df42d96b2a831a2e8d395220fed70f4bba34
2026-10-05 12:37:15 +02:00
..
2025-12-29 17:50:43 +00:00
2026-09-30 13:37:33 +01:00

Repository Tools

Developer tools

Specific tools for developers working on this repository. Additional tools, including the github-merge.py script, are available in the maintainer-tools repository.

Verify-Commits

Tool to verify that every merge commit was signed by a developer using the github-merge.py script.

Linearize

Construct a linear, no-fork, best version of the blockchain.

Qos

A Linux bash script that will set up traffic control (tc) to limit the outgoing bandwidth for connections to the Bitcoin network. This means one can have an always-on bitcoind instance running, and another local bitcoind/bitcoin-qt instance which connects to this node and receives blocks from it.

Seeds

Utility to generate the pnSeed[] array that is compiled into the client.

ASMap

Utilities to analyze and process asmap files.

Build Tools and Keys

Packaging

The Debian subfolder contains the copyright file.

All other packaging related files can be found in the bitcoin-core/packaging repository.

MacDeploy

Scripts and notes for Mac builds.

Test and Verify Tools

TestGen

Utilities to generate test vectors for the data-driven Bitcoin tests.

Verify-Binaries

This script attempts to download and verify the signature file SHA256SUMS.asc from bitcoin.org.

Command Line Tools

Completions

Shell completions for bash and fish.

UTXO Set Tools

UTXO-to-SQLite

This script converts a compact-serialized UTXO set (as generated by Bitcoin Core with dumptxoutset) to a SQLite3 database. For more details like e.g. the created table name and schema, refer to the module docstring on top of the script, which is also contained in the command's --help output.