mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-06-28 12:29:55 +02:00
6921f5df01
6751a323c0iwyu: Fix warnings in `src/bench` and treat them as error (Hennadii Stepanov)a6ed29d6c2bench, refactor: Use `std::string_view` for `BenchRunner` ctor parameter (Hennadii Stepanov) Pull request description: This PR addresses [this](https://github.com/bitcoin/bitcoin/pull/35011#discussion_r3323359707) comment: > I had the impression I already fixed bench in https://github.com/bitcoin/bitcoin/pull/30716 two years ago, but I guess it isn't yet enforced. > > Could do that as a next step? The first two commits act as prerequisites. See the commit messages for details. The third commit additionally ensures that our drop-in header replacements are used instead of system headers: - `util/check.h`:https://github.com/bitcoin/bitcoin/blob/10dfdd4b9fab578e43ba211325967cbc28cb6652/src/util/check.h#L11-L13 - `util/time.h`:https://github.com/bitcoin/bitcoin/blob/10dfdd4b9fab578e43ba211325967cbc28cb6652/src/util/time.h#L9-L10 ACKs for top commit: maflcko: re-ACK6751a323c0📃 BrandonOdiwuor: ACK6751a323c0Tree-SHA512: 159ee734a83dcba3c914682be4b119549e1e4269a43d34c52903e76056d537a2ae02c2f5f4e3adff1b4230082b8ed267c04164abc83b16f717b34fba6e03e359