Files
compound-engineering-plugin…/tests
Trevin Chow 2183d5be53 Address PR review feedback (#590)
- Rewrite Step 5 gating to track total fixes_applied_count across the run
  rather than listing routing options. The prior list implied options C
  and D always skip Step 5, but safe_auto fixes land BEFORE the routing
  question — picking C or D after safe_auto applied fixes should NOT
  skip push/PR handoff. The counter-based gate makes every routing path
  behave correctly. (Codex P1)
- Clarify the generic tracker label as a whole-label substitution, not a
  [TRACKER] token swap. "File an issue per finding without applying fixes"
  replaces the full "File a [TRACKER] ticket per finding without applying
  fixes" — literal token swap would have produced malformed text like
  "File a File a ticket ticket per finding". (Codex P2)
- Specify the no-sink Defer->Skip conversion as an explicit preview-time
  runtime step, not Stage 5 tie-breaking. Step 7b orders conflicting
  reviewer recommendations (Skip > Defer > Apply) and has no knowledge
  of sink_available. The downgrade happens before preview rendering and
  is surfaced to the user so they see why Defer counts moved to Skip.
  (Codex P2)
- Update contract test to match the revised Step 5 gate landmark
  (fixes_applied_count).
2026-04-18 13:01:40 -07:00
..