Files
compound-engineering-plugin…/plugins/compound-engineering/agents
Trevin Chow f06f3169cc Address PR review feedback (#622)
- Subagent template: tighten anchor 25 definition to match the floor
  rule. Rubric now says anchors 0 and 25 are both never emitted — they
  exist in the enum only so synthesis can track drops. Previously the
  anchor 25 description said "emit only when the domain tolerates
  speculative observations" which contradicted the "suppress below 50"
  floor rule a few lines down.

- Product-lens persona: remove "speculative future-product concern with
  no current signal" from the anchor 50 advisory band. The FP catalog
  in subagent-template.md already names that shape as a non-finding to
  suppress, and routing it to anchor 50 contradicted the catalog. The
  persona's suppress-entirely bullet now explicitly defers to the FP
  catalog so the contradiction can't reappear if someone edits one list
  without the other.

- Same fix applied to feasibility and security-lens personas, which
  had the same bug shape — advisory-band examples ("theoretical
  scalability concerns without baseline", "speculative timing-attack
  on non-sensitive data") overlap with the FP catalog. Both personas
  now note that the false-positive catalog takes precedence and list
  domain-specific examples that stay out of the overlap.

The reviewer flagged product-lens specifically; feasibility and
security-lens carry the same contradiction and fixing them now prevents
the same review comment landing on those files next round.
2026-04-21 11:09:51 -07:00
..