averello/git-mirror
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2025-12-12 20:36:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

hashmap: mark unused callback parameters

Browse Source 
Hashmap comparison functions must conform to a particular callback
interface, but many don't use all of their parameters. Especially the
void cmp_data pointer, but some do not use keydata either (because they
can easily form a full struct to pass when doing lookups). Let's mark
these to make -Wunused-parameter happy.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King
2022-08-19 06:08:46 -04:00
committed by Junio C Hamano
parent 783a86c142
commit 02c3c59e62
29 changed files with 59 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
name-hash.c
View File

@@ -18,7 +18,7 @@ struct dir_entry {
char name[FLEX_ARRAY];
};
static int dir_entry_cmp(const void *unused_cmp_data,
static int dir_entry_cmp(const void *UNUSED(cmp_data),
const struct hashmap_entry *eptr,
const struct hashmap_entry *entry_or_key,
const void *keydata)
@@ -120,7 +120,7 @@ static void hash_index_entry(struct index_state *istate, struct cache_entry *ce)
add_dir_entry(istate, ce);
}
static int cache_entry_cmp(const void *unused_cmp_data,
static int cache_entry_cmp(const void *UNUSED(cmp_data),
const struct hashmap_entry *eptr,
const struct hashmap_entry *entry_or_key,
const void *remove)