averello/git-mirror
1
0
Fork 0
mirror of https://github.com/git/git.git synced 2025-12-12 20:36:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

version: replace manual ASCII checks with isprint() for clarity

Browse Source 
Since the isprint() function checks for printable characters, let's
replace the existing hardcoded ASCII checks with it. However, since
the original checks also handled spaces, we need to account for spaces
explicitly in the new check.

Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Usman Akinyemi
2025-02-15 21:20:47 +05:30
committed by Junio C Hamano
parent e63e62171b
commit 0c124cba54
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
version.c
View File

@@ -2,6 +2,7 @@
#include "version.h" #include "version.h"
#include "version-def.h" #include "version-def.h"
#include "strbuf.h" #include "strbuf.h"
#include "sane-ctype.h"
const char git_version_string[] = GIT_VERSION; const char git_version_string[] = GIT_VERSION;
const char git_built_from_commit_string[] = GIT_BUILT_FROM_COMMIT; const char git_built_from_commit_string[] = GIT_BUILT_FROM_COMMIT;
@@ -29,7 +30,7 @@ const char *git_user_agent_sanitized(void)
strbuf_addstr(&buf, git_user_agent()); strbuf_addstr(&buf, git_user_agent());
strbuf_trim(&buf); strbuf_trim(&buf);
for (size_t i = 0; i < buf.len; i++) { for (size_t i = 0; i < buf.len; i++) {
if (buf.buf[i] <= 32 || buf.buf[i] >= 127) if (!isprint(buf.buf[i]) || buf.buf[i] == ' ')
buf.buf[i] = '.'; buf.buf[i] = '.';
} }
agent = buf.buf; agent = buf.buf;