From f87593ab1a7040f4a132787ee436f67cef3136d0 Mon Sep 17 00:00:00 2001 From: cuiweixie Date: Wed, 25 Feb 2026 02:00:57 +0000 Subject: [PATCH] fetch: fix wrong evaluation order in URL trailing-slash trimming if i == -1, url[i] will be UB. Signed-off-by: cuiweixie Signed-off-by: Junio C Hamano --- builtin/fetch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/fetch.c b/builtin/fetch.c index 40a0e8d244..1ced5f22de 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -761,7 +761,7 @@ static void display_state_init(struct display_state *display_state, struct ref * display_state->url = xstrdup("foreign"); display_state->url_len = strlen(display_state->url); - for (i = display_state->url_len - 1; display_state->url[i] == '/' && 0 <= i; i--) + for (i = display_state->url_len - 1; 0 <= i && display_state->url[i] == '/'; i--) ; display_state->url_len = i + 1; if (4 < i && !strncmp(".git", display_state->url + i - 3, 4))