mirror of
https://github.com/git/git.git
synced 2025-12-12 20:36:24 +01:00
clang: warn when the comma operator is used
When compiling Git using `clang`, the `-Wcomma` option can be used to warn about code using the comma operator (because it is typically unintentional and wants to use the semicolon instead). Helped-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Acked-by: Phillip Wood <phillip.wood@dunelm.org.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
88c91d7d74
commit
3db4cb987f
@@ -40,6 +40,10 @@ DEVELOPER_CFLAGS += -Wvla
|
||||
DEVELOPER_CFLAGS += -Wwrite-strings
|
||||
DEVELOPER_CFLAGS += -fno-common
|
||||
|
||||
ifneq ($(filter clang9,$(COMPILER_FEATURES)),)
|
||||
DEVELOPER_CFLAGS += -Wcomma
|
||||
endif
|
||||
|
||||
ifneq ($(filter clang4,$(COMPILER_FEATURES)),)
|
||||
DEVELOPER_CFLAGS += -Wtautological-constant-out-of-range-compare
|
||||
endif
|
||||
|
||||
Reference in New Issue
Block a user