Merge branch 'kh/you-still-use-whatchanged-fix'

The "do you still use it?" message given by a command that is
deeply deprecated and allow us to suggest alternatives has been
updated.

* kh/you-still-use-whatchanged-fix:
  BreakingChanges: remove claim about whatchanged reports
  whatchanged: remove not-even-shorter clause
  whatchanged: hint about git-log(1) and aliasing
  you-still-use-that??: help the user help themselves
  t0014: test shadowing of aliases for a sample of builtins
  git: allow alias-shadowing deprecated builtins
  git: move seen-alias bookkeeping into handle_alias(...)
  git: add `deprecated` category to --list-cmds
  Makefile: don’t add whatchanged after it has been removed
This commit is contained in:
Junio C Hamano
2025-10-02 12:26:12 -07:00
11 changed files with 165 additions and 46 deletions

33
usage.c
View File

@@ -7,6 +7,7 @@
#include "git-compat-util.h"
#include "gettext.h"
#include "trace2.h"
#include "strbuf.h"
static void vfreportf(FILE *f, const char *prefix, const char *err, va_list params)
{
@@ -376,14 +377,32 @@ void bug_fl(const char *file, int line, const char *fmt, ...)
va_end(ap);
}
NORETURN void you_still_use_that(const char *command_name)
NORETURN void you_still_use_that(const char *command_name, const char *hint)
{
struct strbuf percent_encoded = STRBUF_INIT;
strbuf_add_percentencode(&percent_encoded,
command_name,
STRBUF_ENCODE_SLASH);
fprintf(stderr,
_("'%s' is nominated for removal.\n"
"If you still use this command, please add an extra\n"
"option, '--i-still-use-this', on the command line\n"
"and let us know you still use it by sending an e-mail\n"
"to <git@vger.kernel.org>. Thanks.\n"),
command_name);
_("'%s' is nominated for removal.\n"), command_name);
if (hint)
fputs(hint, stderr);
fprintf(stderr,
_("If you still use this command, here's what you can do:\n"
"\n"
"- read https://git-scm.com/docs/BreakingChanges.html\n"
"- check if anyone has discussed this on the mailing\n"
" list and if they came up with something that can\n"
" help you: https://lore.kernel.org/git/?q=%s\n"
"- send an email to <git@vger.kernel.org> to let us\n"
" know that you still use this command and were unable\n"
" to determine a suitable replacement\n"
"\n"),
percent_encoded.buf);
strbuf_release(&percent_encoded);
die(_("refusing to run without --i-still-use-this"));
}