mirror of
https://github.com/git/git.git
synced 2025-12-12 20:36:24 +01:00
remote: use strvecs to store remote url/pushurl
Now that the url/pushurl fields of "struct remote" own their strings, we
can switch from bare arrays to strvecs. This has a few advantages:
- push/clear are now one-liners
- likewise the free+assigns in alias_all_urls() can use
strvec_replace()
- we now use size_t for storage, avoiding possible overflow
- this will enable some further cleanups in future patches
There's quite a bit of fallout in the code that reads these fields, as
it tends to access these arrays directly. But it's mostly a mechanical
replacement of "url_nr" with "url.nr", and "url[i]" with "url.v[i]",
with a few variations (e.g. "*url" could become "*url.v", but I used
"url.v[0]" for consistency).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
52595c155a
commit
8e804415fd
@@ -1574,7 +1574,7 @@ int cmd_main(int argc, const char **argv)
|
||||
if (argc > 2) {
|
||||
end_url_with_slash(&url, argv[2]);
|
||||
} else {
|
||||
end_url_with_slash(&url, remote->url[0]);
|
||||
end_url_with_slash(&url, remote->url.v[0]);
|
||||
}
|
||||
|
||||
http_init(remote, url.buf, 0);
|
||||
|
||||
Reference in New Issue
Block a user