mirror of
https://github.com/git/git.git
synced 2025-12-12 20:36:24 +01:00
run-command: introduce CHILD_PROCESS_INIT
Most struct child_process variables are cleared using memset first after declaration. Provide a macro, CHILD_PROCESS_INIT, that can be used to initialize them statically instead. That's shorter, doesn't require a function call and is slightly more readable (especially given that we already have STRBUF_INIT, ARGV_ARRAY_INIT etc.). Helped-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
6c4ab27f23
commit
d318027932
@@ -623,10 +623,9 @@ static int rpc_service(struct rpc_state *rpc, struct discovery *heads)
|
||||
const char *svc = rpc->service_name;
|
||||
struct strbuf buf = STRBUF_INIT;
|
||||
struct strbuf *preamble = rpc->stdin_preamble;
|
||||
struct child_process client;
|
||||
struct child_process client = CHILD_PROCESS_INIT;
|
||||
int err = 0;
|
||||
|
||||
memset(&client, 0, sizeof(client));
|
||||
client.in = -1;
|
||||
client.out = -1;
|
||||
client.git_cmd = 1;
|
||||
|
||||
Reference in New Issue
Block a user