mirror of
https://github.com/git/git.git
synced 2025-12-12 20:36:24 +01:00
setup: introduce startup_info->original_cwd
Removing the current working directory causes all subsequent git
commands run from that directory to get confused and fail with a message
about being unable to read the current working directory:
$ git status
fatal: Unable to read current working directory: No such file or directory
Non-git commands likely have similar warnings or even errors, e.g.
$ bash -c 'echo hello'
shell-init: error retrieving current directory: getcwd: cannot access parent directories: No such file or directory
hello
This confuses end users, particularly since the command they get the
error from is not the one that caused the problem; the problem came from
the side-effect of some previous command.
We would like to avoid removing the current working directory of our
parent process; towards this end, introduce a new variable,
startup_info->original_cwd, that tracks the current working directory
that we inherited from our parent process. For convenience of later
comparisons, we prefer that this new variable store a path relative to
the toplevel working directory (thus much like 'prefix'), except without
the trailing slash.
Subsequent commits will make use of this new variable.
Acked-by: Derrick Stolee <stolee@gmail.com>
Acked-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
8a0d52dfd8
commit
e6f8861bd4
@@ -26,6 +26,7 @@ static void restore_sigpipe_to_default(void)
|
||||
int main(int argc, const char **argv)
|
||||
{
|
||||
int result;
|
||||
struct strbuf tmp = STRBUF_INIT;
|
||||
|
||||
trace2_initialize_clock();
|
||||
|
||||
@@ -49,6 +50,9 @@ int main(int argc, const char **argv)
|
||||
trace2_cmd_start(argv);
|
||||
trace2_collect_process_info(TRACE2_PROCESS_INFO_STARTUP);
|
||||
|
||||
if (!strbuf_getcwd(&tmp))
|
||||
tmp_original_cwd = strbuf_detach(&tmp, NULL);
|
||||
|
||||
result = cmd_main(argc, argv);
|
||||
|
||||
trace2_cmd_exit(result);
|
||||
|
||||
Reference in New Issue
Block a user