mirror of
https://github.com/git/git.git
synced 2025-12-12 20:36:24 +01:00
08b775864e
In "config.c" we host both the business logic to read and write config files as well as the logic to parse specific Git-related variables. On the one hand this is mixing concerns, but even more importantly it means that we cannot easily remove the dependency on `the_repository` in our config parsing logic. Move the logic into "environment.c". This file is a grab bag of all kinds of global state already, so it is quite a good fit. Furthermore, it also hosts most of the global variables that we're parsing the config values into, making this an even better fit. Note that there is one hidden change: in `parse_fsync_components()` we use an `int` to iterate through `ARRAY_SIZE(fsync_component_names)`. But as -Wsign-compare warnings are enabled in this file this causes a compiler warning. The issue is fixed by using a `size_t` instead. This change allows us to drop the `USE_THE_REPOSITORY_VARIABLE` declaration. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
99 lines
2.8 KiB
C
99 lines
2.8 KiB
C
#define USE_THE_REPOSITORY_VARIABLE
|
|
#include "builtin.h"
|
|
#include "config.h"
|
|
#include "environment.h"
|
|
#include "gettext.h"
|
|
#include "refs.h"
|
|
#include "parse-options.h"
|
|
#include "strbuf.h"
|
|
|
|
static const char * const git_symbolic_ref_usage[] = {
|
|
N_("git symbolic-ref [-m <reason>] <name> <ref>"),
|
|
N_("git symbolic-ref [-q] [--short] [--no-recurse] <name>"),
|
|
N_("git symbolic-ref --delete [-q] <name>"),
|
|
NULL
|
|
};
|
|
|
|
static int check_symref(const char *HEAD, int quiet, int shorten, int recurse, int print)
|
|
{
|
|
int resolve_flags, flag;
|
|
const char *refname;
|
|
|
|
resolve_flags = (recurse ? 0 : RESOLVE_REF_NO_RECURSE);
|
|
refname = refs_resolve_ref_unsafe(get_main_ref_store(the_repository),
|
|
HEAD, resolve_flags, NULL, &flag);
|
|
|
|
if (!refname)
|
|
die("No such ref: %s", HEAD);
|
|
else if (!(flag & REF_ISSYMREF)) {
|
|
if (!quiet)
|
|
die("ref %s is not a symbolic ref", HEAD);
|
|
else
|
|
return 1;
|
|
}
|
|
if (print) {
|
|
char *to_free = NULL;
|
|
if (shorten)
|
|
refname = to_free = refs_shorten_unambiguous_ref(get_main_ref_store(the_repository),
|
|
refname,
|
|
0);
|
|
puts(refname);
|
|
free(to_free);
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
int cmd_symbolic_ref(int argc,
|
|
const char **argv,
|
|
const char *prefix,
|
|
struct repository *repo UNUSED)
|
|
{
|
|
int quiet = 0, delete = 0, shorten = 0, recurse = 1, ret = 0;
|
|
const char *msg = NULL;
|
|
struct option options[] = {
|
|
OPT__QUIET(&quiet,
|
|
N_("suppress error message for non-symbolic (detached) refs")),
|
|
OPT_BOOL('d', "delete", &delete, N_("delete symbolic ref")),
|
|
OPT_BOOL(0, "short", &shorten, N_("shorten ref output")),
|
|
OPT_BOOL(0, "recurse", &recurse, N_("recursively dereference (default)")),
|
|
OPT_STRING('m', NULL, &msg, N_("reason"), N_("reason of the update")),
|
|
OPT_END(),
|
|
};
|
|
|
|
repo_config(the_repository, git_default_config, NULL);
|
|
argc = parse_options(argc, argv, prefix, options,
|
|
git_symbolic_ref_usage, 0);
|
|
if (msg && !*msg)
|
|
die("Refusing to perform update with empty message");
|
|
|
|
if (delete) {
|
|
if (argc != 1)
|
|
usage_with_options(git_symbolic_ref_usage, options);
|
|
ret = check_symref(argv[0], 1, 0, 0, 0);
|
|
if (ret)
|
|
die("Cannot delete %s, not a symbolic ref", argv[0]);
|
|
if (!strcmp(argv[0], "HEAD"))
|
|
die("deleting '%s' is not allowed", argv[0]);
|
|
return refs_delete_ref(get_main_ref_store(the_repository),
|
|
NULL, argv[0], NULL, REF_NO_DEREF);
|
|
}
|
|
|
|
switch (argc) {
|
|
case 1:
|
|
ret = check_symref(argv[0], quiet, shorten, recurse, 1);
|
|
break;
|
|
case 2:
|
|
if (!strcmp(argv[0], "HEAD") &&
|
|
!starts_with(argv[1], "refs/"))
|
|
die("Refusing to point HEAD outside of refs/");
|
|
if (check_refname_format(argv[1], REFNAME_ALLOW_ONELEVEL) < 0)
|
|
die("Refusing to set '%s' to invalid ref '%s'", argv[0], argv[1]);
|
|
ret = !!refs_update_symref(get_main_ref_store(the_repository),
|
|
argv[0], argv[1], msg);
|
|
break;
|
|
default:
|
|
usage_with_options(git_symbolic_ref_usage, options);
|
|
}
|
|
return ret;
|
|
}
|