mirror of
https://github.com/git/git.git
synced 2025-12-12 20:36:24 +01:00
861d4bc292
There are many tests that validate whether 'git pack-objects' works as expected. Instead of duplicating these tests, add a new test environment variable, GIT_TEST_PACK_PATH_WALK, that implies --path-walk by default when specified. This was useful in testing the implementation of the --path-walk implementation, helping to find tests that are overly specific to the default object walk. These include: - t0411-clone-from-partial.sh : One test fetches from a repo that does not have the boundary objects. This causes the path-based walk to fail. Disable the variable for this test. - t5306-pack-nobase.sh : Similar to t0411, one test fetches from a repo without a boundary object. - t5310-pack-bitmaps.sh : One test compares the case when packing with bitmaps to the case when packing without them. Since we disable the test variable when writing bitmaps, this causes a difference in the object list (the --path-walk option adds an extra object). Specify --no-path-walk in both processes for the comparison. Another test checks for a specific delta base, but when computing dynamically without using bitmaps, the base object it too small to be considered in the delta calculations so no base is used. - t5316-pack-delta-depth.sh : This script cares about certain delta choices and their chain lengths. The --path-walk option changes how these chains are selected, and thus changes the results of this test. - t5322-pack-objects-sparse.sh : This demonstrates the effectiveness of the --sparse option and how it combines with --path-walk. - t5332-multi-pack-reuse.sh : This test verifies that the preferred pack is used for delta reuse when possible. The --path-walk option is not currently aware of the preferred pack at all, so finds a different delta base. - t7406-submodule-update.sh : When using the variable, the --depth option collides with the --path-walk feature, resulting in a warning message. Disable the variable so this warning does not appear. I want to call out one specific test change that is only temporary: - t5530-upload-pack-error.sh : One test cares specifically about an "unable to read" error message. Since the current implementation performs delta calculations within the path-walk API callback, a different "unable to get size" error message appears. When this is changed in a future refactoring, this test change can be reverted. Similar to GIT_TEST_NAME_HASH_VERSION, we do not add this option to the linux-TEST-vars CI build as that's already an overloaded build. Signed-off-by: Derrick Stolee <stolee@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
83 lines
2.0 KiB
Bash
Executable File
83 lines
2.0 KiB
Bash
Executable File
#!/bin/sh
|
|
#
|
|
# Copyright (c) 2008 Google Inc.
|
|
#
|
|
|
|
test_description='git-pack-object with missing base
|
|
|
|
'
|
|
|
|
. ./test-lib.sh
|
|
|
|
# Create A-B chain
|
|
#
|
|
test_expect_success 'setup base' '
|
|
test_write_lines a b c d e f g h i >text &&
|
|
echo side >side &&
|
|
git update-index --add text side &&
|
|
A=$(echo A | git commit-tree $(git write-tree)) &&
|
|
|
|
echo m >>text &&
|
|
git update-index text &&
|
|
B=$(echo B | git commit-tree $(git write-tree) -p $A) &&
|
|
git update-ref HEAD $B
|
|
'
|
|
|
|
# Create repository with C whose parent is B.
|
|
# Repository contains C, C^{tree}, C:text, B, B^{tree}.
|
|
# Repository is missing B:text (best delta base for C:text).
|
|
# Repository is missing A (parent of B).
|
|
# Repository is missing A:side.
|
|
#
|
|
test_expect_success 'setup patch_clone' '
|
|
base_objects=$(pwd)/.git/objects &&
|
|
(mkdir patch_clone &&
|
|
cd patch_clone &&
|
|
git init &&
|
|
echo "$base_objects" >.git/objects/info/alternates &&
|
|
echo q >>text &&
|
|
git read-tree $B &&
|
|
git update-index text &&
|
|
git update-ref HEAD $(echo C | git commit-tree $(git write-tree) -p $B) &&
|
|
rm .git/objects/info/alternates &&
|
|
|
|
git --git-dir=../.git cat-file commit $B |
|
|
git hash-object -t commit -w --stdin &&
|
|
|
|
git --git-dir=../.git cat-file tree "$B^{tree}" |
|
|
git hash-object -t tree -w --stdin
|
|
) &&
|
|
C=$(git --git-dir=patch_clone/.git rev-parse HEAD)
|
|
'
|
|
|
|
# Clone patch_clone indirectly by cloning base and fetching.
|
|
#
|
|
test_expect_success 'indirectly clone patch_clone' '
|
|
(mkdir user_clone &&
|
|
cd user_clone &&
|
|
git init &&
|
|
git pull ../.git &&
|
|
test $(git rev-parse HEAD) = $B &&
|
|
|
|
# The --path-walk feature of "git pack-objects" is not
|
|
# compatible with this kind of fetch from an incomplete repo.
|
|
GIT_TEST_PACK_PATH_WALK=0 &&
|
|
export GIT_TEST_PACK_PATH_WALK &&
|
|
|
|
git pull ../patch_clone/.git &&
|
|
test $(git rev-parse HEAD) = $C
|
|
)
|
|
'
|
|
|
|
# Cloning the patch_clone directly should fail.
|
|
#
|
|
test_expect_success 'clone of patch_clone is incomplete' '
|
|
(mkdir user_direct &&
|
|
cd user_direct &&
|
|
git init &&
|
|
test_must_fail git fetch ../patch_clone/.git
|
|
)
|
|
'
|
|
|
|
test_done
|