mirror of
https://github.com/git/git.git
synced 2025-12-12 20:36:24 +01:00
9051638519
The `git refs verify` command is used to run consistency checks on the reference backends. This command is also invoked when users run 'git fsck'. While the files-backend has some fsck checks added, the reftable backend lacks such checks. Let's add the required infrastructure and a check to test for the files present in the reftable directory. Since the reftable library is treated as an independent library we should ensure that the library code works independently without knowledge about Git's internals. To do this, add both 'reftable/fsck.c' and 'reftable/reftable-fsck.h'. Which provide an entry point 'reftable_fsck_check' for running fsck checks over a provided reftable stack. The callee provides the function with callbacks to handle issue and information reporting. The added check, goes over all tables in the reftable stack validates that they have a valid name. It not, it raises an error. While here, move 'reftable/error.o' in the Makefile to retain lexicographic ordering. Signed-off-by: Karthik Nayak <karthik.188@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
101 lines
2.0 KiB
C
101 lines
2.0 KiB
C
#include "basics.h"
|
|
#include "reftable-fsck.h"
|
|
#include "reftable-table.h"
|
|
#include "stack.h"
|
|
|
|
static bool table_has_valid_name(const char *name)
|
|
{
|
|
const char *ptr = name;
|
|
char *endptr;
|
|
|
|
/* strtoull doesn't set errno on success */
|
|
errno = 0;
|
|
|
|
strtoull(ptr, &endptr, 16);
|
|
if (errno)
|
|
return false;
|
|
ptr = endptr;
|
|
|
|
if (*ptr != '-')
|
|
return false;
|
|
ptr++;
|
|
|
|
strtoull(ptr, &endptr, 16);
|
|
if (errno)
|
|
return false;
|
|
ptr = endptr;
|
|
|
|
if (*ptr != '-')
|
|
return false;
|
|
ptr++;
|
|
|
|
strtoul(ptr, &endptr, 16);
|
|
if (errno)
|
|
return false;
|
|
ptr = endptr;
|
|
|
|
if (strcmp(ptr, ".ref") && strcmp(ptr, ".log"))
|
|
return false;
|
|
|
|
return true;
|
|
}
|
|
|
|
typedef int (*table_check_fn)(struct reftable_table *table,
|
|
reftable_fsck_report_fn report_fn,
|
|
void *cb_data);
|
|
|
|
static int table_check_name(struct reftable_table *table,
|
|
reftable_fsck_report_fn report_fn,
|
|
void *cb_data)
|
|
{
|
|
if (!table_has_valid_name(table->name)) {
|
|
struct reftable_fsck_info info;
|
|
|
|
info.error = REFTABLE_FSCK_ERROR_TABLE_NAME;
|
|
info.msg = "invalid reftable table name";
|
|
info.path = table->name;
|
|
|
|
return report_fn(&info, cb_data);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int table_checks(struct reftable_table *table,
|
|
reftable_fsck_report_fn report_fn,
|
|
reftable_fsck_verbose_fn verbose_fn UNUSED,
|
|
void *cb_data)
|
|
{
|
|
table_check_fn table_check_fns[] = {
|
|
table_check_name,
|
|
NULL,
|
|
};
|
|
int err = 0;
|
|
|
|
for (size_t i = 0; table_check_fns[i]; i++)
|
|
err |= table_check_fns[i](table, report_fn, cb_data);
|
|
|
|
return err;
|
|
}
|
|
|
|
int reftable_fsck_check(struct reftable_stack *stack,
|
|
reftable_fsck_report_fn report_fn,
|
|
reftable_fsck_verbose_fn verbose_fn,
|
|
void *cb_data)
|
|
{
|
|
struct reftable_buf msg = REFTABLE_BUF_INIT;
|
|
int err = 0;
|
|
|
|
for (size_t i = 0; i < stack->tables_len; i++) {
|
|
reftable_buf_reset(&msg);
|
|
reftable_buf_addstr(&msg, "Checking table: ");
|
|
reftable_buf_addstr(&msg, stack->tables[i]->name);
|
|
verbose_fn(msg.buf, cb_data);
|
|
|
|
err |= table_checks(stack->tables[i], report_fn, verbose_fn, cb_data);
|
|
}
|
|
|
|
reftable_buf_release(&msg);
|
|
return err;
|
|
}
|