Address review feedback

* Indicate how we're sorting new contributors
* Don't fork for `date` checks
* Include reference in the manpage

Signed-off-by: Ben Cotton <bcotton@funnelfiasco.com>
This commit is contained in:
Ben Cotton
2024-09-19 11:57:38 -04:00
parent 8c1d81a29d
commit fe2df31c36
2 changed files with 8 additions and 3 deletions

View File

@@ -276,7 +276,7 @@ function showMenu() {
printf %b "${NUMS} 8)${TEXT} Branch tree view (last $_limit)\\n" printf %b "${NUMS} 8)${TEXT} Branch tree view (last $_limit)\\n"
printf %b "${NUMS} 9)${TEXT} All branches (sorted by most recent commit)\\n" printf %b "${NUMS} 9)${TEXT} All branches (sorted by most recent commit)\\n"
printf %b "${NUMS} 10)${TEXT} All contributors (sorted by name)\\n" printf %b "${NUMS} 10)${TEXT} All contributors (sorted by name)\\n"
printf %b "${NUMS} 11)${TEXT} New contributors\\n" printf %b "${NUMS} 11)${TEXT} New contributors (sorted by email)\\n"
printf %b "${NUMS} 12)${TEXT} Git commits per author\\n" printf %b "${NUMS} 12)${TEXT} Git commits per author\\n"
printf %b "${NUMS} 13)${TEXT} Git commits per date\\n" printf %b "${NUMS} 13)${TEXT} Git commits per date\\n"
printf %b "${NUMS} 14)${TEXT} Git commits per month\\n" printf %b "${NUMS} 14)${TEXT} Git commits per month\\n"
@@ -1036,7 +1036,7 @@ if [[ "$#" -eq 1 ]]; then
# what people may try. This script doesn't provide any additional # what people may try. This script doesn't provide any additional
# output for a bad date since `date`'s STDERR already contains # output for a bad date since `date`'s STDERR already contains
# useful information. # useful information.
if [ ! $(date -d "${newDate}" +%s) ]; then if ! date -d "${newDate}" +%s > /dev/null 2>&1; then
newDate="" newDate=""
fi fi
done done
@@ -1124,7 +1124,7 @@ while [[ "${opt}" != "" ]]; do
while [[ -z "${newDate}" ]]; do while [[ -z "${newDate}" ]]; do
read -r -p "Since what date? " newDate read -r -p "Since what date? " newDate
# Test if the date provide is valid and try again if it isn't. # Test if the date provide is valid and try again if it isn't.
if [ ! $(date -d "${newDate}" +%s) ]; then if ! date -d "${newDate}" +%s > /dev/null 2>&1; then
newDate="" newDate=""
fi fi
done done

View File

@@ -70,6 +70,11 @@ show branches by date
see a list of everyone who contributed to the repo see a list of everyone who contributed to the repo
.HP .HP
.PP .PP
\fB\-n\fR, \fB\-\-new\-contributors\fR
.IP
list everyone who made their first contribution since a specified date
.HP
.PP
\fB\-a\fR, \fB\-\-commits\-per\-author\fR \fB\-a\fR, \fB\-\-commits\-per\-author\fR
.IP .IP
displays a list of commits per author displays a list of commits per author