- Remove unused (*Action).printReminder shim from handler_shims.go
- Remove unused cryptoBackend type alias from base.go
- Add blank line before return in queue/background.go (nlreturn)
- Update integration tests to use 'show -u' instead of 'show -f'
since the --force/-f aliases for show --unsafe were intentionally dropped
- Add .doctor to commandsWithError in main_test.go
B-1 (grep): increment matches and errors counters so the summary
line correctly reports the number of matches and decryption failures.
B-2 (autoSync): move autosyncLastRun = time.Now() outside the
err != nil block so the debounce timestamp is updated on success,
not only on failure.
B-3 (create wizard): fix password maximum-length check to compare
against v.Max instead of v.Min, so passwords under v.Max are
accepted and those over v.Max are rejected.
B-4 (RemoveMount): remove the duplicate map-lookup / warning block;
the second check was dead code that could never show a different
result than the first.
B-5 (convert): pass sv (the user-supplied backend name string)
instead of the zero-value storage variable into the error message so
users see what they actually typed.
B-6 (leaf convert): fix typo 'stroage' -> 'storage' in error message.
B-7 (audit): default to PrintSummary when neither --full nor
--summary is given, instead of running the (potentially slow) full
audit and silently discarding all results.
B-8 (queue): replace the goroutine-leaking Idle() implementation
with a simple polling loop that terminates correctly; remove the
self-documenting 'likely broken' package comment.
* Fsck: Improved message handling and decreased commit spam.
* Merge upstream changes with local changes (part 2: manual fixes)
* pgp keyring: Do not import a pgp public key into the user's private keyring if the key there is identical to the one in the store's keyring
* fsck.go: made the code more go-idiomatic
* more changes to make code more go-idiomatic
* Fsck: fixed misleading messages caused by previous refactor
(also clarified the roles of the values in ErrorSeverity)
* Fsck: even smoother git use (pubkey updates now in the same git commit as the rest of fsck's changes)
Also removed dupeicate check of public keys, and added more tests around commit messages
* Ctxutil: Pruning unused functions, more go idiomaticity (and some tweaks regarding errors)
* Formatted files with gofmt
* fixed misc. error management
* More fixes and formatting
(plus one fixed text for the `link` action)
* unblock CI (attempt 1)
* fix problems discovered by CI
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Co-authored-by: Dominik Schulz <dominik.schulz@gauner.org>
By using the default queue some git operations might still have been
running when gopass did attempt to update exported keys. Disabling
the queue in the inner loop makes more sense since it's more predictable
and less brittle and using the queue there wouldn't help much anyway.
Fixes#2459
RELEASE_NOTES=[BUGFIX] Fix possible concurrency issues in fsck.
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
This PR moves some packages from internal to pkg to increase the
independence of binaries in cmd/ from internal packages further.
RELEASE_NOTES=n/a
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
This commit adds a synchornous background queue for processing e.g. sync
tasks. These shouldn't be blocking in interactive use but still need to
be done before we terminate.
This might also help improve the git implementation later on.
RELEASE_NOTES=n/a
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
This commit adds remote sync support to the ondisk backend. It uses
minio to support a number of cloud storage products as well as self
hosted minio servers.
RELEASE_NOTES=[FEATURE] Add remote sync support for the ondisk backend.
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Dominik Schulz
niacdoial
Dominik Schulz