averello/jquery-validation-mirror
1
0
Fork 0
mirror of https://github.com/jquery-validation/jquery-validation.git synced 2025-12-24 12:13:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Core: Don't call submitHandler when in debug mode (#2193)

Browse Source 
Fixes #2042
This commit is contained in:
Brahim Arkni
2018-07-29 15:58:24 +01:00
committed by GitHub
parent e26547a01e
commit 2037129e00
3 changed files with 12 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
test/test.js
View File

@@ -167,14 +167,10 @@ QUnit.test( "valid() ???", function( assert ) {
v.errorList = errorList;
assert.ok( !v.valid(), "One error, must be invalid" );
v.destroy();
v = $( "#testForm3" ).validate( {
submitHandler: function() {
assert.ok( false, "Submit handler was called" );
}
} );
assert.ok( v.valid(), "No errors, must be valid and returning true, even with the submit handler" );
v = $( "#testForm3" ).validate();
assert.ok( v.valid(), "No errors, must be valid and returning true" );
v.errorList = errorList;
assert.ok( !v.valid(), "One error, must be invalid, no call to submit handler" );
assert.ok( !v.valid(), "One error, must be invalid" );
} );
QUnit.test( "valid(), ignores ignored elements", function( assert ) {
@@ -576,13 +572,14 @@ QUnit.test( "submitHandler keeps submitting button", function( assert ) {
var button, event;
$( "#userForm" ).validate( {
debug: true,
debug: false,
submitHandler: function( form ) {
// Dunno how to test this better; this tests the implementation that uses a hidden input
var hidden = $( form ).find( "input:hidden" )[ 0 ];
assert.deepEqual( hidden.value, button.value );
assert.deepEqual( hidden.name, button.name );
return false;
}
} );
$( "#username" ).val( "bla" );
@@ -596,7 +593,7 @@ QUnit.test( "submitHandler keeps submitting button", function( assert ) {
QUnit.test( "submitHandler keeps submitting button, even if descendants are clicked", function( assert ) {
var button = $( "#testForm27 :submit" )[ 0 ];
var v = $( "#testForm27" ).validate( {
debug: true,
debug: false,
submitHandler: function( form ) {
// Compare the button with the `submitButton` property
@@ -1370,6 +1367,7 @@ QUnit.test( "ajaxSubmit", function( assert ) {
$( "#user" ).val( "Peter" );
$( "#password" ).val( "foobar" );
jQuery( "#signupForm" ).validate( {
debug: false,
submitHandler: function( form ) {
jQuery( form ).ajaxSubmit( {
success: function( response ) {
@@ -1377,6 +1375,8 @@ QUnit.test( "ajaxSubmit", function( assert ) {
done();
}
} );
return false;
}
} );
jQuery( "#signupForm" ).triggerHandler( "submit" );
@@ -2424,7 +2424,6 @@ QUnit.test( "calling blur on ignored element", function( assert ) {
form.validate( {
ignore: ".ignore",
submitHandler: $.noop,
invalidHandler: function() {
$( "#ss1" ).blur();
}