From c65a2c43f20d70a1c8d86106ba3ff778f8aa9114 Mon Sep 17 00:00:00 2001 From: Philipp Kiemle Date: Wed, 11 Jun 2025 01:41:32 +0200 Subject: [PATCH] Make strings HIG compliant MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Use the Copyright symbol © - Use en-dashes for date ranges - Use ellipses instead of '...' --- app/main.cpp | 2 +- cli/kdeconnect-cli.cpp | 4 ++-- daemon/kdeconnectd.cpp | 2 +- indicator/deviceindicator.cpp | 2 +- indicator/main.cpp | 4 ++-- kio/kiokdeconnect.cpp | 4 ++-- plugins/notifications/notification.cpp | 2 +- settings/main.cpp | 2 +- smsapp/main.cpp | 2 +- urlhandler/kdeconnect-handler.cpp | 2 +- 10 files changed, 13 insertions(+), 13 deletions(-) diff --git a/app/main.cpp b/app/main.cpp index 23d6a518c..cb8663a73 100644 --- a/app/main.cpp +++ b/app/main.cpp @@ -30,7 +30,7 @@ int main(int argc, char *argv[]) QStringLiteral(KDECONNECT_VERSION_STRING), i18n("KDE Connect"), KAboutLicense::GPL, - i18n("(c) 2015-2025, KDE Connect Team")); + i18n("© 2015–2025 KDE Connect Team")); aboutData.addAuthor(i18n("Aleix Pol Gonzalez"), {}, QStringLiteral("aleixpol@kde.org")); aboutData.addAuthor(i18n("Albert Vaca Cintora"), {}, QStringLiteral("albertvaka@kde.org")); aboutData.setTranslator(i18nc("NAME OF TRANSLATORS", "Your names"), i18nc("EMAIL OF TRANSLATORS", "Your emails")); diff --git a/cli/kdeconnect-cli.cpp b/cli/kdeconnect-cli.cpp index f1130d8b1..0b60ced5f 100644 --- a/cli/kdeconnect-cli.cpp +++ b/cli/kdeconnect-cli.cpp @@ -31,7 +31,7 @@ int main(int argc, char **argv) QStringLiteral(KDECONNECT_VERSION_STRING), i18n("KDE Connect CLI tool"), KAboutLicense::GPL, - i18n("(c) 2015-2025, KDE Connect Team")); + i18n("© 2015–2025, KDE Connect Team")); aboutData.addAuthor(i18n("Aleix Pol Gonzalez"), {}, QStringLiteral("aleixpol@kde.org")); aboutData.addAuthor(i18n("Albert Vaca Cintora"), {}, QStringLiteral("albertvaka@kde.org")); KAboutData::setApplicationData(aboutData); @@ -254,7 +254,7 @@ int main(int argc, char **argv) if (!dev.isReachable()) { // Device doesn't exist, go into discovery mode and wait up to 30 seconds for the device to appear QEventLoop wait; - QTextStream(stderr) << i18n("waiting for device...") << Qt::endl; + QTextStream(stderr) << i18n("waiting for device…") << Qt::endl; QObject::connect(&iface, &DaemonDbusInterface::deviceAdded, &iface, [&](const QString &deviceAddedId) { if (device == deviceAddedId) { diff --git a/daemon/kdeconnectd.cpp b/daemon/kdeconnectd.cpp index ce160ebf3..5443e77f1 100644 --- a/daemon/kdeconnectd.cpp +++ b/daemon/kdeconnectd.cpp @@ -72,7 +72,7 @@ int main(int argc, char *argv[]) QStringLiteral(KDECONNECT_VERSION_STRING), i18n("KDE Connect Daemon"), KAboutLicense::GPL, - i18n("(c) 2015-2025, KDE Connect Team")); + i18n("© 2015–2025 KDE Connect Team")); KAboutData::setApplicationData(aboutData); app.setQuitOnLastWindowClosed(false); diff --git a/indicator/deviceindicator.cpp b/indicator/deviceindicator.cpp index 986eca0f9..d5bbb4b9e 100644 --- a/indicator/deviceindicator.cpp +++ b/indicator/deviceindicator.cpp @@ -114,7 +114,7 @@ DeviceIndicator::DeviceIndicator(DeviceDbusInterface *device) // SMS Messages const QString kdeconnectsmsExecutable = QStandardPaths::findExecutable(QStringLiteral("kdeconnect-sms"), {QCoreApplication::applicationDirPath()}); if (!kdeconnectsmsExecutable.isEmpty()) { - auto smsapp = addAction(QIcon::fromTheme(QStringLiteral("message-new")), i18n("SMS Messages...")); + auto smsapp = addAction(QIcon::fromTheme(QStringLiteral("message-new")), i18n("SMS Messages…")); QObject::connect(smsapp, &QAction::triggered, device, [device, kdeconnectsmsExecutable]() { QProcess::startDetached(kdeconnectsmsExecutable, {QStringLiteral("--device"), device->id()}); }); diff --git a/indicator/main.cpp b/indicator/main.cpp index 3f3be382e..11accb882 100644 --- a/indicator/main.cpp +++ b/indicator/main.cpp @@ -58,7 +58,7 @@ int main(int argc, char **argv) QStringLiteral(KDECONNECT_VERSION_STRING), i18n("KDE Connect Indicator tool"), KAboutLicense::GPL, - i18n("(c) 2016-2025, KDE Connect Team")); + i18n("© 2016–2025 KDE Connect Team")); aboutData.addAuthor(i18n("Aleix Pol Gonzalez"), {}, QStringLiteral("aleixpol@kde.org")); aboutData.addAuthor(i18n("Albert Vaca Cintora"), {}, QStringLiteral("albertvaka@kde.org")); aboutData.setProgramLogo(QIcon::fromTheme(QStringLiteral("kdeconnect"))); @@ -106,7 +106,7 @@ int main(int argc, char **argv) QProcess::startDetached(appPath); }); #endif - auto configure = menu->addAction(QIcon::fromTheme(QStringLiteral("configure")), i18n("Configure...")); + auto configure = menu->addAction(QIcon::fromTheme(QStringLiteral("configure")), i18n("Configure…")); QObject::connect(configure, &QAction::triggered, configure, [&dialog]() { if (dialog == nullptr) { dialog = new KCMultiDialog; diff --git a/kio/kiokdeconnect.cpp b/kio/kiokdeconnect.cpp index 380ebaaf4..b622ed6d3 100644 --- a/kio/kiokdeconnect.cpp +++ b/kio/kiokdeconnect.cpp @@ -72,7 +72,7 @@ KioKdeconnect::KioKdeconnect(const QByteArray &pool, const QByteArray &app) KIO::WorkerResult KioKdeconnect::listAllDevices() { - infoMessage(i18n("Listing devices...")); + infoMessage(i18n("Listing devices…")); // TODO: Change to all devices and show different icons for connected and disconnected? const QStringList devices = m_dbusInterface->devices(true, true); @@ -117,7 +117,7 @@ KIO::WorkerResult KioKdeconnect::listAllDevices() KIO::WorkerResult KioKdeconnect::listDevice(const QString &device) { - infoMessage(i18n("Accessing device...")); + infoMessage(i18n("Accessing device…")); qCDebug(KDECONNECT_KIO) << "ListDevice" << device; diff --git a/plugins/notifications/notification.cpp b/plugins/notifications/notification.cpp index e170a7dda..dbd4787b4 100644 --- a/plugins/notifications/notification.cpp +++ b/plugins/notifications/notification.cpp @@ -106,7 +106,7 @@ void Notification::createKNotification(const NetworkPacket &np) if (!m_requestReplyId.isEmpty()) { auto replyAction = std::make_unique(i18nc("@action:button", "Reply")); - replyAction->setPlaceholderText(i18nc("@info:placeholder", "Reply to %1...", m_appName)); + replyAction->setPlaceholderText(i18nc("@info:placeholder", "Reply to %1…", m_appName)); replyAction->setFallbackBehavior(KNotificationReplyAction::FallbackBehavior::UseRegularAction); QObject::connect(replyAction.get(), &KNotificationReplyAction::replied, this, &Notification::replied); QObject::connect(replyAction.get(), &KNotificationReplyAction::activated, this, &Notification::reply); diff --git a/settings/main.cpp b/settings/main.cpp index 6553b67c6..4662a3f43 100644 --- a/settings/main.cpp +++ b/settings/main.cpp @@ -28,7 +28,7 @@ int main(int argc, char **argv) QStringLiteral(KDECONNECT_VERSION_STRING), i18n("KDE Connect Settings"), KAboutLicense::GPL, - i18n("(c) 2018-2025, KDE Connect Team")); + i18n("© 2018–2025 KDE Connect Team")); aboutData.addAuthor(i18n("Nicolas Fella"), {}, QStringLiteral("nicolas.fella@gmx.de")); KAboutData::setApplicationData(aboutData); diff --git a/smsapp/main.cpp b/smsapp/main.cpp index 8616de234..c51837518 100644 --- a/smsapp/main.cpp +++ b/smsapp/main.cpp @@ -51,7 +51,7 @@ int main(int argc, char *argv[]) QStringLiteral(KDECONNECT_VERSION_STRING), i18n("SMS Instant Messaging"), KAboutLicense::GPL, - i18n("(C) 2018-2025, KDE Connect Team")); + i18n("© 2018–2025 KDE Connect Team")); aboutData.addAuthor(i18n("Simon Redman"), {}, QStringLiteral("simon@ergotech.com")); aboutData.addAuthor(i18n("Aleix Pol Gonzalez"), {}, QStringLiteral("aleixpol@kde.org")); aboutData.addAuthor(i18n("Nicolas Fella"), {}, QStringLiteral("nicolas.fella@gmx.de")); diff --git a/urlhandler/kdeconnect-handler.cpp b/urlhandler/kdeconnect-handler.cpp index fb5637ede..c247d3b0f 100644 --- a/urlhandler/kdeconnect-handler.cpp +++ b/urlhandler/kdeconnect-handler.cpp @@ -47,7 +47,7 @@ int main(int argc, char **argv) QStringLiteral(KDECONNECT_VERSION_STRING), description, KAboutLicense::GPL, - i18n("(c) 2015-2025, KDE Connect Team")); + i18n("© 2015–2025 KDE Connect Team")); aboutData.addAuthor(i18n("Aleix Pol Gonzalez"), {}, QStringLiteral("aleixpol@kde.org")); aboutData.addAuthor(i18n("Albert Vaca Cintora"), {}, QStringLiteral("albertvaka@gmail.org")); aboutData.setProgramLogo(QIcon::fromTheme(QStringLiteral("kdeconnect")));