mirror of
https://github.com/koreader/koreader.git
synced 2025-12-24 12:14:05 +01:00
[doc] Tag @todo, @fixme and @warning (#5244)
This commit standardizes the various todos around the code a bit in a manner recognized by LDoc. Besides drawing more attention by being displayed in the developer docs, they're also extractable with LDoc on the command line: ```sh ldoc --tags todo,fixme *.lua ``` However, whether that particular usage offers any advantage over other search tools is questionable at best. * and some random beautification
This commit is contained in:
@@ -159,7 +159,7 @@ function ReaderRolling:onReadSettings(config)
|
||||
self.ui.document:gotoXPointer(self.xpointer)
|
||||
end
|
||||
-- we read last_percent just for backward compatibility
|
||||
-- FIXME: remove this branch with migration script
|
||||
--- @fixme remove this branch with migration script
|
||||
elseif last_per then
|
||||
self.setupXpointer = function()
|
||||
self:_gotoPercent(last_per)
|
||||
@@ -343,7 +343,7 @@ function ReaderRolling:getLastProgress()
|
||||
end
|
||||
|
||||
function ReaderRolling:addToMainMenu(menu_items)
|
||||
-- FIXME: repeated code with page overlap menu for readerpaging
|
||||
--- @fixme repeated code with page overlap menu for readerpaging
|
||||
-- needs to keep only one copy of the logic as for the DRY principle.
|
||||
-- The difference between the two menus is only the enabled func.
|
||||
local overlap_lines_help_text = _([[
|
||||
@@ -407,7 +407,7 @@ function ReaderRolling:getLastPercent()
|
||||
if self.view.view_mode == "page" then
|
||||
return self.current_page / self.old_page
|
||||
else
|
||||
-- FIXME: the calculated percent is not accurate in "scroll" mode.
|
||||
--- @fixme the calculated percent is not accurate in "scroll" mode.
|
||||
return self.ui.document:getPosFromXPointer(
|
||||
self.ui.document:getXPointer()) / self.ui.document.info.doc_height
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user