10 Commits

Author SHA1 Message Date
hius07
6133a43512 TouchMenu: optimize item removal (#13901) 2025-06-04 08:15:02 +03:00
hius07
178bb823f0 Dispatcher: update action name or value (#13831) 2025-05-22 17:57:36 +03:00
hius07
0c5d75612b Update main.lua 2025-03-10 08:47:53 +02:00
hius07
cda2dcaacc BookShortcuts: open file with associated provider (#13106) 2025-01-25 12:26:18 +02:00
NiLuJe
fadee1f5dc Clarify our OOP semantics across the codebase (#9586)
Basically:

* Use `extend` for class definitions
* Use `new` for object instantiations

That includes some minor code cleanups along the way:

* Updated `Widget`'s docs to make the semantics clearer.
* Removed `should_restrict_JIT` (it's been dead code since https://github.com/koreader/android-luajit-launcher/pull/283)
* Minor refactoring of LuaSettings/LuaData/LuaDefaults/DocSettings to behave (mostly, they are instantiated via `open` instead of `new`) like everything else and handle inheritance properly (i.e., DocSettings is now a proper LuaSettings subclass).
* Default to `WidgetContainer` instead of `InputContainer` for stuff that doesn't actually setup key/gesture events.
* Ditto for explicit `*Listener` only classes, make sure they're based on `EventListener` instead of something uselessly fancier.
* Unless absolutely necessary, do not store references in class objects, ever; only values. Instead, always store references in instances, to avoid both sneaky inheritance issues, and sneaky GC pinning of stale references.
  * ReaderUI: Fix one such issue with its `active_widgets` array, with critical implications, as it essentially pinned *all* of ReaderUI's modules, including their reference to the `Document` instance (i.e., that was a big-ass leak).
* Terminal: Make sure the shell is killed on plugin teardown.
* InputText: Fix Home/End/Del physical keys to behave sensibly.
* InputContainer/WidgetContainer: If necessary, compute self.dimen at paintTo time (previously, only InputContainers did, which might have had something to do with random widgets unconcerned about input using it as a baseclass instead of WidgetContainer...).
* OverlapGroup: Compute self.dimen at *init* time, because for some reason it needs to do that, but do it directly in OverlapGroup instead of going through a weird WidgetContainer method that it was the sole user of.
* ReaderCropping: Under no circumstances should a Document instance member (here, self.bbox) risk being `nil`ed!
* Kobo: Minor code cleanups.
2022-10-06 02:14:48 +02:00
hius07
460d42293a PathChooser: add creating folder (#9354) 2022-07-27 12:02:37 -04:00
yparitcher
c9bfb74d2a Book Shortcuts: allow recursively searching folders 2022-03-24 22:49:34 -04:00
hius07
c9fc9496aa BookShortcuts: fix folders handling (#8795) 2022-02-15 12:04:07 +02:00
yparitcher
8207bdc3e3 BookShortcuts plugin: folder support (#8449)
Allow setting a folder as a book shortcut, with 2 options:
- open file browser: opens the FM in that folder
- last book: opens the most recently read book (via
  ReadHistory) in that folder
2021-11-21 20:51:42 +01:00
yparitcher
c40874d300 book shortcuts plugin 2021-09-13 10:56:06 -04:00