diff --git a/io_uring/rw.c b/io_uring/rw.c index 4ff3442ac2ee..f2ab967b9507 100644 --- a/io_uring/rw.c +++ b/io_uring/rw.c @@ -140,27 +140,37 @@ void io_readv_writev_cleanup(struct io_kiocb *req) kfree(io->free_iovec); } -static inline void io_rw_done(struct kiocb *kiocb, ssize_t ret) +static inline ssize_t io_fixup_restart_res(ssize_t ret) { switch (ret) { - case -EIOCBQUEUED: - break; case -ERESTARTSYS: case -ERESTARTNOINTR: case -ERESTARTNOHAND: case -ERESTART_RESTARTBLOCK: /* * We can't just restart the syscall, since previously - * submitted sqes may already be in progress. Just fail this - * IO with EINTR. + * submitted sqes may already be in progress. Just fail + * this IO with EINTR. */ - ret = -EINTR; - fallthrough; + return -EINTR; default: - kiocb->ki_complete(kiocb, ret); + return ret; } } +static inline void io_rw_done(struct kiocb *kiocb, ssize_t ret) +{ + /* IO was queued async, completion will happen later */ + if (ret == -EIOCBQUEUED) + return; + + /* transform internal restart error codes */ + if (unlikely(ret < 0)) + ret = io_fixup_restart_res(ret); + + kiocb->ki_complete(kiocb, ret); +} + static inline loff_t *io_kiocb_update_pos(struct io_kiocb *req) { struct io_rw *rw = io_kiocb_to_cmd(req, struct io_rw); @@ -885,7 +895,7 @@ int io_read(struct io_kiocb *req, unsigned int issue_flags) if (ret >= 0) return kiocb_done(req, ret, issue_flags); - return ret; + return io_fixup_restart_res(ret); } static bool io_kiocb_start_write(struct io_kiocb *req, struct kiocb *kiocb)