abbd838c57
Merge tag 'mt76-for-kvalo-2024-09-06' of https://github.com/nbd168/wireless
...
mt76 patches for 6.12
- fixes
- mt7915 .sta_state support
- mt7915 hardware restart improvements
2024-09-09 20:37:47 +03:00
6bba05d651
wifi: mt76: mt7925: replace chan config with extend txpower config for clc
...
Since MT792x_CLC_CHAN is currently not in use, we have added an
extension for setting txpower to replace it.
Signed-off-by: Ming Yen Hsieh <mingyen.hsieh@mediatek.com >
Link: https://patch.msgid.link/20240819015334.14580-2-mingyen.hsieh@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:08 +02:00
9679ca7326
wifi: mt76: mt7925: fix a potential array-index-out-of-bounds issue for clc
...
Due to the lack of checks on the clc array, if the firmware supports
more clc configuration, it will cause illegal memory access.
Cc: stable@vger.kernel.org
Fixes: c948b5da6bmingyen.hsieh@mediatek.com >
Link: https://patch.msgid.link/20240819015334.14580-1-mingyen.hsieh@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:08 +02:00
5acdc432f8
wifi: mt76: mt7615: check devm_kasprintf() returned value
...
devm_kasprintf() can return a NULL pointer on failure but this returned
value is not checked. Fix this lack and check the returned value.
Found by code review.
Cc: stable@vger.kernel.org
Fixes: 0bb4e9187emake24@iscas.ac.cn >
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com >
Link: https://patch.msgid.link/20240905014753.353271-1-make24@iscas.ac.cn
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:07 +02:00
df6b08670f
wifi: mt76: mt7925: convert comma to semicolon
...
Replace comma between expressions with semicolons.
Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.
Found by inspection.
No functional change intended.
Compile tested only.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn >
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com >
Link: https://patch.msgid.link/20240904075213.1352976-1-nichen@iscas.ac.cn
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:07 +02:00
45064d19fd
wifi: mt76: mt7925: fix a potential association failure upon resuming
...
In multi-channel scenarios, the granted channel must be aborted before
suspending. Otherwise, the firmware will be put into a wrong state,
resulting in an association failure after resuming.
With this patch, the granted channel will be aborted before suspending
if necessary.
Cc: stable@vger.kernel.org
Fixes: c948b5da6bmichael.lo@mediatek.com >
Signed-off-by: Ming Yen Hsieh <mingyen.hsieh@mediatek.com >
Link: https://patch.msgid.link/20240902090054.15806-1-mingyen.hsieh@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:07 +02:00
bb6fe2b92a
wifi: mt76: Avoid multiple -Wflex-array-member-not-at-end warnings
...
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are
getting ready to enable it, globally.
So, in order to avoid ending up with a flexible-array member in the
middle of multiple other structs, we use the `struct_group_tagged()`
helper to create a new tagged `struct mt76_connac2_mcu_rxd_hdr`.
This structure groups together all the members of the flexible
`struct mt76_connac2_mcu_rxd` except the flexible array.
As a result, the array is effectively separated from the rest of the
members without modifying the memory layout of the flexible structure.
We then change the type of the middle struct members currently causing
trouble from `struct mt76_connac2_mcu_rxd` to `struct
mt76_connac2_mcu_rxd_hdr`.
We also want to ensure that when new members need to be added to the
flexible structure, they are always included within the newly created
tagged struct. For this, we use `static_assert()`. This ensures that the
memory layout for both the flexible structure and the new tagged struct
is the same after any changes.
This approach avoids having to implement `struct mt76_connac2_mcu_rxd_hdr`
as a completely separate structure, thus preventing having to maintain
two independent but basically identical structures, closing the door
to potential bugs in the future.
So, with these changes, fix the following warnings:
drivers/net/wireless/mediatek/mt76/mt7915/mcu.h:32:37: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
drivers/net/wireless/mediatek/mt76/mt7915/mcu.h:40:37: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
drivers/net/wireless/mediatek/mt76/mt7915/mcu.h:49:37: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
drivers/net/wireless/mediatek/mt76/mt7915/mcu.h:58:37: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org >
Link: https://patch.msgid.link/Zr5KsZugaEXrApQJ@elsanto
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:07 +02:00
1ccc9e476c
wifi: mt76: mt7921: Check devm_kasprintf() returned value
...
devm_kasprintf() can return a NULL pointer on failure but this returned
value is not checked. Fix this lack and check the returned value.
Found by code review.
Cc: stable@vger.kernel.org
Fixes: 6ae39b7c7emake24@iscas.ac.cn >
Reviwed-by: Matthias Brugger <matthias.bgg@gmail.com >
Link: https://patch.msgid.link/20240903014455.4144536-1-make24@iscas.ac.cn
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:07 +02:00
267efeda8c
wifi: mt76: mt7915: check devm_kasprintf() returned value
...
devm_kasprintf() can return a NULL pointer on failure but this returned
value is not checked. Fix this lack and check the returned value.
Found by code review.
Cc: stable@vger.kernel.org
Fixes: 6ae39b7c7emake24@iscas.ac.cn >
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com >
Link: https://patch.msgid.link/20240903014955.4145423-1-make24@iscas.ac.cn
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:07 +02:00
b13cd593ef
wifi: mt76: mt7915: avoid long MCU command timeouts during SER
...
Immediately abort MCU commands when firmware requests DMA restart.
Link: https://patch.msgid.link/20240827093011.18621-24-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:07 +02:00
9e461f4a23
wifi: mt76: mt7996: fix uninitialized TLV data
...
Use skb_put_zero instead of skb_put
Fixes: 98686cd216https://patch.msgid.link/20240827093011.18621-23-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:07 +02:00
eeb672b50d
wifi: mt76: mt7915: always query station rx rate from firmware
...
When offloading is enabled, the software rx path may not have the latest
rate information.
Link: https://patch.msgid.link/20240827093011.18621-22-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:07 +02:00
6ac80fce71
wifi: mt76: mt7915: fix rx filter setting for bfee functionality
...
Fix rx filter setting to prevent dropping NDPA frames. Without this
change, bfee functionality may behave abnormally.
Fixes: e57b790146howard-yh.hsu@mediatek.com >
Link: https://patch.msgid.link/20240827093011.18621-21-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:07 +02:00
c377844352
wifi: mt76: shrink mt76_queue_buf
...
Reuse one bit from the length field for skip_unmap
Link: https://patch.msgid.link/20240827093011.18621-20-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:07 +02:00
328e35c7bf
wifi: mt76: mt7915: improve hardware restart reliability
...
- use reconfig_complete to restart mac_work / queues
- reset full wtbl after firmware init
- clear wcid and vif mask to avoid leak
- fix sta poll list corruption
Link: https://patch.msgid.link/20240827093011.18621-19-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:07 +02:00
b2141eadf8
wifi: mt76: connac: move mt7615_mcu_del_wtbl_all to connac
...
Preparation for reusing it in mt7915
Link: https://patch.msgid.link/20240827093011.18621-18-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:07 +02:00
8f7152f10c
wifi: mt76: mt7915: hold dev->mt76.mutex while disabling tx worker
...
Prevent racing against other functions disabling the same worker
Link: https://patch.msgid.link/20240827093011.18621-17-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:07 +02:00
f2cc859149
wifi: mt76: mt7915: add dummy HW offload of IEEE 802.11 fragmentation
...
Currently, CONNAC2 series do not support encryption for fragmented Tx frames.
Therefore, add dummy function mt7915_set_frag_threshold() to prevent SW
IEEE 802.11 fragmentation.
Signed-off-by: Benjamin Lin <benjamin-jw.lin@mediatek.com >
Link: https://patch.msgid.link/20240827093011.18621-16-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:07 +02:00
10f73bb393
wifi: mt76: mt7915: reset the device after MCU timeout
...
On MT7915, MCU hangs do not trigger watchdog interrupts, so they can only
be detected through MCU message timeouts. Ensure that the hardware gets
restarted when that happens in order to prevent a permanent stuck state.
Link: https://patch.msgid.link/20240827093011.18621-15-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:06 +02:00
3688c18b65
wifi: mt76: mt7915: retry mcu messages
...
In some cases MCU messages can get lost. Instead of failing completely,
attempt to recover by re-sending them.
Link: https://patch.msgid.link/20240827093011.18621-14-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:06 +02:00
8351a4a40b
wifi: mt76: mt7915: set MT76_MCU_RESET early in mt7915_mac_full_reset
...
This avoids running into unnecessary timeouts waiting for MCU responses
Link: https://patch.msgid.link/20240827093011.18621-13-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:06 +02:00
33eb14f102
wifi: mt76: mt7915: use mac80211 .sta_state op
...
Allows adding stations before assoc, though they are not passed to the
firmware yet at that point.
Link: https://patch.msgid.link/20240827093011.18621-12-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:06 +02:00
17b0f68a72
wifi: mt76: change .sta_assoc callback to .sta_event
...
Also report auth/disassoc events, in order to give the driver more control over
handling the station state.
Link: https://patch.msgid.link/20240827093011.18621-11-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:06 +02:00
8a977b3f96
wifi: mt76: connac: add support for passing connection state directly
...
Preparation for improvements to sta handling. No functional changes.
Link: https://patch.msgid.link/20240827093011.18621-10-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:06 +02:00
dfaf079a1a
wifi: mt76: connac: add support for IEEE 802.11 fragmentation
...
Add fragmentation index into TXD.DW2 to support IEEE 802.11 fragmentation.
Signed-off-by: Benjamin Lin <benjamin-jw.lin@mediatek.com >
Link: https://patch.msgid.link/20240827093011.18621-9-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:06 +02:00
f3049b88b2
wifi: mt76: mt7915: allocate vif wcid in the same range as stations
...
Reduces the amount of unnecessary WTBL bank switching, while still reserving
WTBL entries for vifs.
Link: https://patch.msgid.link/20240827093011.18621-8-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:06 +02:00
256cbd26fb
wifi: mt76: mt7915: disable tx worker during tx BA session enable/disable
...
Avoids firmware race condition.
Link: https://patch.msgid.link/20240827093011.18621-7-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:06 +02:00
0b3be9d1d3
wifi: mt76: add separate tx scheduling queue for off-channel tx
...
Ensure that packets are not sent out to the wrong channel
Link: https://patch.msgid.link/20240827093011.18621-6-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 14:23:06 +02:00
bca8bc0399
wifi: mac80211: handle ieee80211_radar_detected() for MLO
...
Currently DFS works under assumption there could be only one channel
context in the hardware. Hence, drivers just calls the function
ieee80211_radar_detected() passing the hardware structure. However, with
MLO, this obviously will not work since number of channel contexts will be
more than one and hence drivers would need to pass the channel information
as well on which the radar is detected.
Also, when radar is detected in one of the links, other link's CAC should
not be cancelled.
Hence, in order to support DFS with MLO, do the following changes -
* Add channel context conf pointer as an argument to the function
ieee80211_radar_detected(). During MLO, drivers would have to pass on
which channel context conf radar is detected. Otherwise, drivers could
just pass NULL.
* ieee80211_radar_detected() will iterate over all channel contexts
present and
* if channel context conf is passed, only mark that as radar
detected
* if NULL is passed, then mark all channel contexts as radar
detected
* Then as usual, schedule the radar detected work.
* In the worker, go over all the contexts again and for all such context
which is marked with radar detected, cancel the ongoing CAC by calling
ieee80211_dfs_cac_cancel() and then notify cfg80211 via
cfg80211_radar_event().
* To cancel the CAC, pass the channel context as well where radar is
detected to ieee80211_dfs_cac_cancel(). This ensures that CAC is
canceled only on the links using the provided context, leaving other
links unaffected.
This would also help in scenarios where there is split phy 5 GHz radio,
which is capable of DFS channels in both lower and upper band. In this
case, simultaneous radars can be detected.
Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com >
Link: https://patch.msgid.link/20240906064426.2101315-9-quic_adisi@quicinc.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com >
2024-09-06 13:01:05 +02:00
f4fdd77162
wifi: mt76: partially move channel change code to core
...
This allows the core code to change the channel. Code deduplication and
preparation for adding scanning code to the core.
Link: https://patch.msgid.link/20240828063422.44813-1-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 11:14:37 +02:00
e43b87f6b7
wifi: mt76: fix mt76_get_rate
...
Do not assume that the first phy has 2 GHz support.
Check sband->band instead of accessing dev->phy.sband_2g.
Link: https://patch.msgid.link/20240827093011.18621-4-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 11:14:37 +02:00
6ea13e6bd2
wifi: mt76: mt7603: initialize chainmask
...
Fixes reported tx power by accounting for the combined output
Link: https://patch.msgid.link/20240827093011.18621-3-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 11:14:37 +02:00
3dd99b8f20
wifi: mt76: mt7603: fix reading target power from eeprom
...
If the ext-PA target power is unset, fall back to the standard EEPROM value.
Link: https://patch.msgid.link/20240827093011.18621-2-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 11:14:37 +02:00
9b8d932053
wifi: mt76: mt7603: fix mixed declarations and code
...
Move the qid variable declaration further up
Fixes: b473c0e47fhttps://patch.msgid.link/20240827093011.18621-1-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 11:14:34 +02:00
a04b920fbc
wifi: mt76: connac: fix checksum offload fields of connac3 RXD
...
Fix incorrect RXD offset and bitfield related to RX checksum offload.
Fixes: 98686cd2164e9011fcdfshayne.chen@mediatek.com >
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com >
Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com >
Link: https://patch.msgid.link/20240816095040.2574-1-shayne.chen@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 11:14:31 +02:00
f503ae90c7
wifi: mt76: mt7996: fix NULL pointer dereference in mt7996_mcu_sta_bfer_he
...
Fix the NULL pointer dereference in mt7996_mcu_sta_bfer_he
routine adding an sta interface to the mt7996 driver.
Found by code review.
Cc: stable@vger.kernel.org
Fixes: 98686cd216make24@iscas.ac.cn >
Link: https://patch.msgid.link/20240813081242.3991814-1-make24@iscas.ac.cn
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 11:14:31 +02:00
dcd21b27f1
wifi: mt76: mt7996: set IEEE80211_KEY_FLAG_GENERATE_MMIE for other ciphers
...
When beacon protection is enabled, FW checks MMIE tag & length in the
beacon for every cipher mode. To pass the check, driver needs to set the
key flag IEEE80211_KEY_GENERATE_MMIE to let mac80211 generate and
initialize MMIE.
Signed-off-by: Michael-CY Lee <michael-cy.lee@mediatek.com >
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com >
Link: https://patch.msgid.link/20240816094635.2391-11-shayne.chen@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 11:14:31 +02:00
5353679ab4
wifi: mt76: connac: add IEEE 802.11 fragmentation support for mt7996
...
Add fragment index into TXD.DW2 to support IEEE 802.11 fragmentation.
Signed-off-by: Benjamin Lin <benjamin-jw.lin@mediatek.com >
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com >
Link: https://patch.msgid.link/20240816094635.2391-10-shayne.chen@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 11:14:31 +02:00
ded1a6d9e1
wifi: mt76: mt7996: fix handling mbss enable/disable
...
When mbss was previously enabled, the TLV needs to be included when
disabling it again, in order to clear the firmware state.
Fixes: a7908d5b61rex.lu@mediatek.com >
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com >
Link: https://patch.msgid.link/20240816094635.2391-9-shayne.chen@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-06 11:13:37 +02:00
5dae5d09fe
wifi: mt76: mt7996: set correct value in beamforming mcu command for mt7992
...
Configure correct bf number and bitmap in beamforming mcu command for
mt7992 chipsets, which only support dual-band.
Signed-off-by: Howard Hsu <howard-yh.hsu@mediatek.com >
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com >
Link: https://patch.msgid.link/20240816094635.2391-8-shayne.chen@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-05 13:01:55 +02:00
9ca65757f0
wifi: mt76: mt7996: fix EHT beamforming capability check
...
If a VIF acts as a beamformer, it should check peer's beamformee
capability, and vice versa.
Fixes: ba01944adehoward-yh.hsu@mediatek.com >
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com >
Link: https://patch.msgid.link/20240816094635.2391-7-shayne.chen@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-05 13:01:55 +02:00
0cca3fe745
wifi: mt76: mt7996: set correct beamformee SS capability
...
According to IEEE P802.11be/D6.0 Table 9-417n, beamformee SS field stands
for the maximum number of spatial streams that the STA can receive in an
EHT sounding NDP minus 1, and the minimum value of this field is 3.
This value indicates the decoding capability of a beamformee, which is
independent of current antenna settings. Correct the value for mt7996
and mt7992 chipsets based on their HW capability.
Signed-off-by: Howard Hsu <howard-yh.hsu@mediatek.com >
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com >
Link: https://patch.msgid.link/20240816094635.2391-6-shayne.chen@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-05 13:01:55 +02:00
e1f4847fdb
wifi: mt76: mt7996: fix HE and EHT beamforming capabilities
...
Fix HE and EHT beamforming capabilities for different bands and
interface types.
Fixes: 98686cd216348533eb96howard-yh.hsu@mediatek.com >
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com >
Link: https://patch.msgid.link/20240816094635.2391-5-shayne.chen@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-05 13:01:55 +02:00
948f652498
wifi: mt76: mt7996: advertize beacon_int_min_gcd
...
Advertize beacon_int_min_gcd as 100 to allow setting different beacon
intervals on different interfaces.
Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com >
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com >
Link: https://patch.msgid.link/20240816094635.2391-4-shayne.chen@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-05 13:01:55 +02:00
9265397caa
wifi: mt76: mt7996: fix wmm set of station interface to 3
...
According to connac3 HW design, the WMM index of AP and STA interface
should be 0 and 3, respectively.
Fixes: 98686cd216chui-hao.chiu@mediatek.com >
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com >
Link: https://patch.msgid.link/20240816094635.2391-3-shayne.chen@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-05 13:01:55 +02:00
376200f095
wifi: mt76: mt7996: fix traffic delay when switching back to working channel
...
During scanning, UNI_CHANNEL_RX_PATH tag is necessary for the firmware to
properly stop and resume MAC TX queue. Without this tag, HW needs more time
to resume traffic when switching back to working channel.
Fixes: 98686cd216chui-hao.chiu@mediatek.com >
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com >
Link: https://patch.msgid.link/20240816094635.2391-2-shayne.chen@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-05 13:01:55 +02:00
f98c3de92b
wifi: mt76: mt7996: use hweight16 to get correct tx antenna
...
The chainmask is u16 so using hweight8 cannot get correct tx_ant.
Without this patch, the tx_ant of band 2 would be -1 and lead to the
following issue:
BUG: KASAN: stack-out-of-bounds in mt7996_mcu_add_sta+0x12e0/0x16e0 [mt7996e]
Fixes: 98686cd216chui-hao.chiu@mediatek.com >
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com >
Link: https://patch.msgid.link/20240816094635.2391-1-shayne.chen@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-05 13:01:55 +02:00
723762a7a7
wifi: mt76: mt7921: fix wrong UNII-4 freq range check for the channel usage
...
The check should start from 5845 to 5925, which includes
channels 169, 173, and 177.
Fixes: 09382d8f86mingyen.hsieh@mediatek.com >
Link: https://patch.msgid.link/20240806013408.17874-1-mingyen.hsieh@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-05 13:01:55 +02:00
862bf7cbd7
wifi: mt76: mt7915: fix oops on non-dbdc mt7986
...
mt7915_band_config() sets band_idx = 1 on the main phy for mt7986
with MT7975_ONE_ADIE or MT7976_ONE_ADIE.
Commit 0335c034e7#1 ] SMP
Modules linked in: ... mt7915e mt76_connac_lib mt76 mac80211 cfg80211 ...
CPU: 2 PID: 1631 Comm: hostapd Not tainted 5.15.150 #0
Hardware name: ZyXEL EX5700 (Telenor) (DT)
pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : mt76_wcid_cleanup+0x84/0x22c [mt76]
lr : mt76_wcid_cleanup+0x64/0x22c [mt76]
sp : ffffffc00a803700
x29: ffffffc00a803700 x28: ffffff80008f7300 x27: ffffff80003f3c00
x26: ffffff80000a7880 x25: ffffffc008c26e00 x24: 0000000000000001
x23: ffffffc000a68114 x22: 0000000000000000 x21: ffffff8004172cc8
x20: ffffffc00a803748 x19: ffffff8004152020 x18: 0000000000000000
x17: 00000000000017c0 x16: ffffffc008ef5000 x15: 0000000000000be0
x14: ffffff8004172e28 x13: ffffff8004172e28 x12: 0000000000000000
x11: 0000000000000000 x10: ffffff8004172e30 x9 : ffffff8004172e28
x8 : 0000000000000000 x7 : ffffff8004156020 x6 : 0000000000000000
x5 : 0000000000000031 x4 : 0000000000000000 x3 : 0000000000000001
x2 : 0000000000000000 x1 : ffffff80008f7300 x0 : 0000000000000024
Call trace:
mt76_wcid_cleanup+0x84/0x22c [mt76]
__mt76_sta_remove+0x70/0xbc [mt76]
mt76_sta_state+0x8c/0x1a4 [mt76]
mt7915_eeprom_get_power_delta+0x11e4/0x23a0 [mt7915e]
drv_sta_state+0x144/0x274 [mac80211]
sta_info_move_state+0x1cc/0x2a4 [mac80211]
sta_set_sinfo+0xaf8/0xc24 [mac80211]
sta_info_destroy_addr_bss+0x4c/0x6c [mac80211]
ieee80211_color_change_finish+0x1c08/0x1e70 [mac80211]
cfg80211_check_station_change+0x1360/0x4710 [cfg80211]
genl_family_rcv_msg_doit+0xb4/0x110
genl_rcv_msg+0xd0/0x1bc
netlink_rcv_skb+0x58/0x120
genl_rcv+0x34/0x50
netlink_unicast+0x1f0/0x2ec
netlink_sendmsg+0x198/0x3d0
____sys_sendmsg+0x1b0/0x210
___sys_sendmsg+0x80/0xf0
__sys_sendmsg+0x44/0xa0
__arm64_sys_sendmsg+0x20/0x30
invoke_syscall.constprop.0+0x4c/0xe0
do_el0_svc+0x40/0xd0
el0_svc+0x14/0x4c
el0t_64_sync_handler+0x100/0x110
el0t_64_sync+0x15c/0x160
Code: d2800002 910092c0 52800023 f9800011 (885f7c01)
---[ end trace 7e42dd9a39ed2281 ]---
Fix by using mt76_dev_phy() which will map band_idx to the correct phy
for all hardware combinations.
Fixes: 0335c034e7https://github.com/openwrt/openwrt/issues/14548
Signed-off-by: Bjørn Mork <bjorn@mork.no >
Link: https://patch.msgid.link/20240713130010.516037-1-bjorn@mork.no
Signed-off-by: Felix Fietkau <nbd@nbd.name >
2024-09-05 13:01:55 +02:00
479ffee68d
wifi: mt76: mt7921: fix NULL pointer access in mt7921_ipv6_addr_change
...
When disabling wifi mt7921_ipv6_addr_change() is called as a notifier.
At this point mvif->phy is already NULL so we cannot use it here.
Signed-off-by: Bert Karwatzki <spasswolf@web.de >
Signed-off-by: Felix Fietkau <nbd@nbd.name >
Signed-off-by: Kalle Valo <kvalo@kernel.org >
Link: https://patch.msgid.link/20240812104542.80760-1-spasswolf@web.de
2024-08-13 12:48:56 +03:00
Kalle Valo
Ming Yen Hsieh
Ma Ke
Chen Ni
Michael Lo
Gustavo A. R. Silva
Felix Fietkau
Howard Hsu
Benjamin Lin
Aditya Kumar Singh
Peter Chiu
Michael-CY Lee
Rex Lu
Bjørn Mork
Bert Karwatzki