mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-04-08 12:02:33 +02:00
c66f4711f7
For CCS formats on affected platforms, CCS can be used freely, but display engine requires a multiple of 64k physical pages. No other changes are needed. At the BO creation time we don't know if the BO will be used for CCS or not. If the scanout flag is set, and the BO is a multiple of 64k, we take the safe route and force the physical alignment of 64k pages. If the BO is not a multiple of 64k, or the scanout flag was not set at BO creation, we reject it for usage as CCS in display. The physical pages are likely not aligned correctly, and this will cause corruption when used as FB. The scanout flag and size being a multiple of 64k are used together to enforce 64k physical placement. VM_BIND is completely unaffected, mappings to a VM can still be aligned to 4k, just like for normal buffers. Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Matthew Auld <matthew.auld@intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Juha-Pekka Heikkilä <juha-pekka.heikkila@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240826170117.327709-3-maarten.lankhorst@linux.intel.com Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
89 lines
2.1 KiB
C
89 lines
2.1 KiB
C
/* SPDX-License-Identifier: MIT */
|
|
/*
|
|
* Copyright © 2021 Intel Corporation
|
|
*/
|
|
|
|
#include <drm/drm_modeset_helper.h>
|
|
#include <drm/ttm/ttm_bo.h>
|
|
|
|
#include "intel_display_types.h"
|
|
#include "intel_fb.h"
|
|
#include "intel_fb_bo.h"
|
|
#include "xe_bo.h"
|
|
|
|
void intel_fb_bo_framebuffer_fini(struct xe_bo *bo)
|
|
{
|
|
if (bo->flags & XE_BO_FLAG_PINNED) {
|
|
/* Unpin our kernel fb first */
|
|
xe_bo_lock(bo, false);
|
|
xe_bo_unpin(bo);
|
|
xe_bo_unlock(bo);
|
|
}
|
|
xe_bo_put(bo);
|
|
}
|
|
|
|
int intel_fb_bo_framebuffer_init(struct intel_framebuffer *intel_fb,
|
|
struct xe_bo *bo,
|
|
struct drm_mode_fb_cmd2 *mode_cmd)
|
|
{
|
|
struct xe_device *xe = to_xe_device(bo->ttm.base.dev);
|
|
int ret;
|
|
|
|
/*
|
|
* Some modifiers require physical alignment of 64KiB VRAM pages;
|
|
* require that the BO in those cases is created correctly.
|
|
*/
|
|
if (XE_IOCTL_DBG(xe, intel_fb_needs_64k_phys(mode_cmd->modifier[0]) &&
|
|
!(bo->flags & XE_BO_FLAG_NEEDS_64K)))
|
|
return -EINVAL;
|
|
|
|
xe_bo_get(bo);
|
|
|
|
ret = ttm_bo_reserve(&bo->ttm, true, false, NULL);
|
|
if (ret)
|
|
goto err;
|
|
|
|
if (!(bo->flags & XE_BO_FLAG_SCANOUT)) {
|
|
/*
|
|
* XE_BO_FLAG_SCANOUT should ideally be set at creation, or is
|
|
* automatically set when creating FB. We cannot change caching
|
|
* mode when the boect is VM_BINDed, so we can only set
|
|
* coherency with display when unbound.
|
|
*/
|
|
if (XE_IOCTL_DBG(xe, !list_empty(&bo->ttm.base.gpuva.list))) {
|
|
ttm_bo_unreserve(&bo->ttm);
|
|
ret = -EINVAL;
|
|
goto err;
|
|
}
|
|
bo->flags |= XE_BO_FLAG_SCANOUT;
|
|
}
|
|
ttm_bo_unreserve(&bo->ttm);
|
|
return 0;
|
|
|
|
err:
|
|
xe_bo_put(bo);
|
|
return ret;
|
|
}
|
|
|
|
struct xe_bo *intel_fb_bo_lookup_valid_bo(struct drm_i915_private *i915,
|
|
struct drm_file *filp,
|
|
const struct drm_mode_fb_cmd2 *mode_cmd)
|
|
{
|
|
struct drm_i915_gem_object *bo;
|
|
struct drm_gem_object *gem = drm_gem_object_lookup(filp, mode_cmd->handles[0]);
|
|
|
|
if (!gem)
|
|
return ERR_PTR(-ENOENT);
|
|
|
|
bo = gem_to_xe_bo(gem);
|
|
/* Require vram placement or dma-buf import */
|
|
if (IS_DGFX(i915) &&
|
|
!xe_bo_can_migrate(gem_to_xe_bo(gem), XE_PL_VRAM0) &&
|
|
bo->ttm.type != ttm_bo_type_sg) {
|
|
drm_gem_object_put(gem);
|
|
return ERR_PTR(-EREMOTE);
|
|
}
|
|
|
|
return bo;
|
|
}
|