mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-04-03 12:05:13 +02:00
[ Upstream commit 2048ec5b98 ]
The syzbot reported issue in hfs_find_set_zero_bits():
=====================================================
BUG: KMSAN: uninit-value in hfs_find_set_zero_bits+0x74d/0xb60 fs/hfs/bitmap.c:45
hfs_find_set_zero_bits+0x74d/0xb60 fs/hfs/bitmap.c:45
hfs_vbm_search_free+0x13c/0x5b0 fs/hfs/bitmap.c:151
hfs_extend_file+0x6a5/0x1b00 fs/hfs/extent.c:408
hfs_get_block+0x435/0x1150 fs/hfs/extent.c:353
__block_write_begin_int+0xa76/0x3030 fs/buffer.c:2151
block_write_begin fs/buffer.c:2262 [inline]
cont_write_begin+0x10e1/0x1bc0 fs/buffer.c:2601
hfs_write_begin+0x85/0x130 fs/hfs/inode.c:52
cont_expand_zero fs/buffer.c:2528 [inline]
cont_write_begin+0x35a/0x1bc0 fs/buffer.c:2591
hfs_write_begin+0x85/0x130 fs/hfs/inode.c:52
hfs_file_truncate+0x1d6/0xe60 fs/hfs/extent.c:494
hfs_inode_setattr+0x964/0xaa0 fs/hfs/inode.c:654
notify_change+0x1993/0x1aa0 fs/attr.c:552
do_truncate+0x28f/0x310 fs/open.c:68
do_ftruncate+0x698/0x730 fs/open.c:195
do_sys_ftruncate fs/open.c:210 [inline]
__do_sys_ftruncate fs/open.c:215 [inline]
__se_sys_ftruncate fs/open.c:213 [inline]
__x64_sys_ftruncate+0x11b/0x250 fs/open.c:213
x64_sys_call+0xfe3/0x3db0 arch/x86/include/generated/asm/syscalls_64.h:78
do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
do_syscall_64+0xd9/0x210 arch/x86/entry/syscall_64.c:94
entry_SYSCALL_64_after_hwframe+0x77/0x7f
Uninit was created at:
slab_post_alloc_hook mm/slub.c:4154 [inline]
slab_alloc_node mm/slub.c:4197 [inline]
__kmalloc_cache_noprof+0x7f7/0xed0 mm/slub.c:4354
kmalloc_noprof include/linux/slab.h:905 [inline]
hfs_mdb_get+0x1cc8/0x2a90 fs/hfs/mdb.c:175
hfs_fill_super+0x3d0/0xb80 fs/hfs/super.c:337
get_tree_bdev_flags+0x6e3/0x920 fs/super.c:1681
get_tree_bdev+0x38/0x50 fs/super.c:1704
hfs_get_tree+0x35/0x40 fs/hfs/super.c:388
vfs_get_tree+0xb0/0x5c0 fs/super.c:1804
do_new_mount+0x738/0x1610 fs/namespace.c:3902
path_mount+0x6db/0x1e90 fs/namespace.c:4226
do_mount fs/namespace.c:4239 [inline]
__do_sys_mount fs/namespace.c:4450 [inline]
__se_sys_mount+0x6eb/0x7d0 fs/namespace.c:4427
__x64_sys_mount+0xe4/0x150 fs/namespace.c:4427
x64_sys_call+0xfa7/0x3db0 arch/x86/include/generated/asm/syscalls_64.h:166
do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
do_syscall_64+0xd9/0x210 arch/x86/entry/syscall_64.c:94
entry_SYSCALL_64_after_hwframe+0x77/0x7f
CPU: 1 UID: 0 PID: 12609 Comm: syz.1.2692 Not tainted 6.16.0-syzkaller #0 PREEMPT(none)
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025
=====================================================
The HFS_SB(sb)->bitmap buffer is allocated in hfs_mdb_get():
HFS_SB(sb)->bitmap = kmalloc(8192, GFP_KERNEL);
Finally, it can trigger the reported issue because kmalloc()
doesn't clear the allocated memory. If allocated memory contains
only zeros, then everything will work pretty fine.
But if the allocated memory contains the "garbage", then
it can affect the bitmap operations and it triggers
the reported issue.
This patch simply exchanges the kmalloc() on kzalloc()
with the goal to guarantee the correctness of bitmap operations.
Because, newly created allocation bitmap should have all
available blocks free. Potentially, initialization bitmap's read
operation could not fill the whole allocated memory and
"garbage" in the not initialized memory will be the reason of
volume coruptions and file system driver bugs.
Reported-by: syzbot <syzbot+773fa9d79b29bd8b6831@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=773fa9d79b29bd8b6831
Signed-off-by: Viacheslav Dubeyko <slava@dubeyko.com>
cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
cc: Yangtao Li <frank.li@vivo.com>
cc: linux-fsdevel@vger.kernel.org
Link: https://lore.kernel.org/r/20250820230636.179085-1-slava@dubeyko.com
Signed-off-by: Viacheslav Dubeyko <slava@dubeyko.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
373 lines
10 KiB
C
373 lines
10 KiB
C
/*
|
|
* linux/fs/hfs/mdb.c
|
|
*
|
|
* Copyright (C) 1995-1997 Paul H. Hargrove
|
|
* (C) 2003 Ardis Technologies <roman@ardistech.com>
|
|
* This file may be distributed under the terms of the GNU General Public License.
|
|
*
|
|
* This file contains functions for reading/writing the MDB.
|
|
*/
|
|
|
|
#include <linux/cdrom.h>
|
|
#include <linux/blkdev.h>
|
|
#include <linux/nls.h>
|
|
#include <linux/slab.h>
|
|
|
|
#include "hfs_fs.h"
|
|
#include "btree.h"
|
|
|
|
/*================ File-local data types ================*/
|
|
|
|
/*
|
|
* The HFS Master Directory Block (MDB).
|
|
*
|
|
* Also known as the Volume Information Block (VIB), this structure is
|
|
* the HFS equivalent of a superblock.
|
|
*
|
|
* Reference: _Inside Macintosh: Files_ pages 2-59 through 2-62
|
|
*
|
|
* modified for HFS Extended
|
|
*/
|
|
|
|
static int hfs_get_last_session(struct super_block *sb,
|
|
sector_t *start, sector_t *size)
|
|
{
|
|
struct cdrom_device_info *cdi = disk_to_cdi(sb->s_bdev->bd_disk);
|
|
|
|
/* default values */
|
|
*start = 0;
|
|
*size = bdev_nr_sectors(sb->s_bdev);
|
|
|
|
if (HFS_SB(sb)->session >= 0) {
|
|
struct cdrom_tocentry te;
|
|
|
|
if (!cdi)
|
|
return -EINVAL;
|
|
|
|
te.cdte_track = HFS_SB(sb)->session;
|
|
te.cdte_format = CDROM_LBA;
|
|
if (cdrom_read_tocentry(cdi, &te) ||
|
|
(te.cdte_ctrl & CDROM_DATA_TRACK) != 4) {
|
|
pr_err("invalid session number or type of track\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
*start = (sector_t)te.cdte_addr.lba << 2;
|
|
} else if (cdi) {
|
|
struct cdrom_multisession ms_info;
|
|
|
|
ms_info.addr_format = CDROM_LBA;
|
|
if (cdrom_multisession(cdi, &ms_info) == 0 && ms_info.xa_flag)
|
|
*start = (sector_t)ms_info.addr.lba << 2;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* hfs_mdb_get()
|
|
*
|
|
* Build the in-core MDB for a filesystem, including
|
|
* the B-trees and the volume bitmap.
|
|
*/
|
|
int hfs_mdb_get(struct super_block *sb)
|
|
{
|
|
struct buffer_head *bh;
|
|
struct hfs_mdb *mdb, *mdb2;
|
|
unsigned int block;
|
|
char *ptr;
|
|
int off2, len, size, sect;
|
|
sector_t part_start, part_size;
|
|
loff_t off;
|
|
__be16 attrib;
|
|
|
|
/* set the device driver to 512-byte blocks */
|
|
size = sb_min_blocksize(sb, HFS_SECTOR_SIZE);
|
|
if (!size)
|
|
return -EINVAL;
|
|
|
|
if (hfs_get_last_session(sb, &part_start, &part_size))
|
|
return -EINVAL;
|
|
while (1) {
|
|
/* See if this is an HFS filesystem */
|
|
bh = sb_bread512(sb, part_start + HFS_MDB_BLK, mdb);
|
|
if (!bh)
|
|
goto out;
|
|
|
|
if (mdb->drSigWord == cpu_to_be16(HFS_SUPER_MAGIC))
|
|
break;
|
|
brelse(bh);
|
|
|
|
/* check for a partition block
|
|
* (should do this only for cdrom/loop though)
|
|
*/
|
|
if (hfs_part_find(sb, &part_start, &part_size))
|
|
goto out;
|
|
}
|
|
|
|
HFS_SB(sb)->alloc_blksz = size = be32_to_cpu(mdb->drAlBlkSiz);
|
|
if (!size || (size & (HFS_SECTOR_SIZE - 1))) {
|
|
pr_err("bad allocation block size %d\n", size);
|
|
goto out_bh;
|
|
}
|
|
|
|
size = min(HFS_SB(sb)->alloc_blksz, (u32)PAGE_SIZE);
|
|
/* size must be a multiple of 512 */
|
|
while (size & (size - 1))
|
|
size -= HFS_SECTOR_SIZE;
|
|
sect = be16_to_cpu(mdb->drAlBlSt) + part_start;
|
|
/* align block size to first sector */
|
|
while (sect & ((size - 1) >> HFS_SECTOR_SIZE_BITS))
|
|
size >>= 1;
|
|
/* align block size to weird alloc size */
|
|
while (HFS_SB(sb)->alloc_blksz & (size - 1))
|
|
size >>= 1;
|
|
brelse(bh);
|
|
if (!sb_set_blocksize(sb, size)) {
|
|
pr_err("unable to set blocksize to %u\n", size);
|
|
goto out;
|
|
}
|
|
|
|
bh = sb_bread512(sb, part_start + HFS_MDB_BLK, mdb);
|
|
if (!bh)
|
|
goto out;
|
|
if (mdb->drSigWord != cpu_to_be16(HFS_SUPER_MAGIC))
|
|
goto out_bh;
|
|
|
|
HFS_SB(sb)->mdb_bh = bh;
|
|
HFS_SB(sb)->mdb = mdb;
|
|
|
|
/* These parameters are read from the MDB, and never written */
|
|
HFS_SB(sb)->part_start = part_start;
|
|
HFS_SB(sb)->fs_ablocks = be16_to_cpu(mdb->drNmAlBlks);
|
|
HFS_SB(sb)->fs_div = HFS_SB(sb)->alloc_blksz >> sb->s_blocksize_bits;
|
|
HFS_SB(sb)->clumpablks = be32_to_cpu(mdb->drClpSiz) /
|
|
HFS_SB(sb)->alloc_blksz;
|
|
if (!HFS_SB(sb)->clumpablks)
|
|
HFS_SB(sb)->clumpablks = 1;
|
|
HFS_SB(sb)->fs_start = (be16_to_cpu(mdb->drAlBlSt) + part_start) >>
|
|
(sb->s_blocksize_bits - HFS_SECTOR_SIZE_BITS);
|
|
|
|
/* These parameters are read from and written to the MDB */
|
|
HFS_SB(sb)->free_ablocks = be16_to_cpu(mdb->drFreeBks);
|
|
HFS_SB(sb)->next_id = be32_to_cpu(mdb->drNxtCNID);
|
|
HFS_SB(sb)->root_files = be16_to_cpu(mdb->drNmFls);
|
|
HFS_SB(sb)->root_dirs = be16_to_cpu(mdb->drNmRtDirs);
|
|
HFS_SB(sb)->file_count = be32_to_cpu(mdb->drFilCnt);
|
|
HFS_SB(sb)->folder_count = be32_to_cpu(mdb->drDirCnt);
|
|
|
|
/* TRY to get the alternate (backup) MDB. */
|
|
sect = part_start + part_size - 2;
|
|
bh = sb_bread512(sb, sect, mdb2);
|
|
if (bh) {
|
|
if (mdb2->drSigWord == cpu_to_be16(HFS_SUPER_MAGIC)) {
|
|
HFS_SB(sb)->alt_mdb_bh = bh;
|
|
HFS_SB(sb)->alt_mdb = mdb2;
|
|
} else
|
|
brelse(bh);
|
|
}
|
|
|
|
if (!HFS_SB(sb)->alt_mdb) {
|
|
pr_warn("unable to locate alternate MDB\n");
|
|
pr_warn("continuing without an alternate MDB\n");
|
|
}
|
|
|
|
HFS_SB(sb)->bitmap = kzalloc(8192, GFP_KERNEL);
|
|
if (!HFS_SB(sb)->bitmap)
|
|
goto out;
|
|
|
|
/* read in the bitmap */
|
|
block = be16_to_cpu(mdb->drVBMSt) + part_start;
|
|
off = (loff_t)block << HFS_SECTOR_SIZE_BITS;
|
|
size = (HFS_SB(sb)->fs_ablocks + 8) / 8;
|
|
ptr = (u8 *)HFS_SB(sb)->bitmap;
|
|
while (size) {
|
|
bh = sb_bread(sb, off >> sb->s_blocksize_bits);
|
|
if (!bh) {
|
|
pr_err("unable to read volume bitmap\n");
|
|
goto out;
|
|
}
|
|
off2 = off & (sb->s_blocksize - 1);
|
|
len = min((int)sb->s_blocksize - off2, size);
|
|
memcpy(ptr, bh->b_data + off2, len);
|
|
brelse(bh);
|
|
ptr += len;
|
|
off += len;
|
|
size -= len;
|
|
}
|
|
|
|
HFS_SB(sb)->ext_tree = hfs_btree_open(sb, HFS_EXT_CNID, hfs_ext_keycmp);
|
|
if (!HFS_SB(sb)->ext_tree) {
|
|
pr_err("unable to open extent tree\n");
|
|
goto out;
|
|
}
|
|
HFS_SB(sb)->cat_tree = hfs_btree_open(sb, HFS_CAT_CNID, hfs_cat_keycmp);
|
|
if (!HFS_SB(sb)->cat_tree) {
|
|
pr_err("unable to open catalog tree\n");
|
|
goto out;
|
|
}
|
|
|
|
attrib = mdb->drAtrb;
|
|
if (!(attrib & cpu_to_be16(HFS_SB_ATTRIB_UNMNT))) {
|
|
pr_warn("filesystem was not cleanly unmounted, running fsck.hfs is recommended. mounting read-only.\n");
|
|
sb->s_flags |= SB_RDONLY;
|
|
}
|
|
if ((attrib & cpu_to_be16(HFS_SB_ATTRIB_SLOCK))) {
|
|
pr_warn("filesystem is marked locked, mounting read-only.\n");
|
|
sb->s_flags |= SB_RDONLY;
|
|
}
|
|
if (!sb_rdonly(sb)) {
|
|
/* Mark the volume uncleanly unmounted in case we crash */
|
|
attrib &= cpu_to_be16(~HFS_SB_ATTRIB_UNMNT);
|
|
attrib |= cpu_to_be16(HFS_SB_ATTRIB_INCNSTNT);
|
|
mdb->drAtrb = attrib;
|
|
be32_add_cpu(&mdb->drWrCnt, 1);
|
|
mdb->drLsMod = hfs_mtime();
|
|
|
|
mark_buffer_dirty(HFS_SB(sb)->mdb_bh);
|
|
sync_dirty_buffer(HFS_SB(sb)->mdb_bh);
|
|
}
|
|
|
|
return 0;
|
|
|
|
out_bh:
|
|
brelse(bh);
|
|
out:
|
|
hfs_mdb_put(sb);
|
|
return -EIO;
|
|
}
|
|
|
|
/*
|
|
* hfs_mdb_commit()
|
|
*
|
|
* Description:
|
|
* This updates the MDB on disk.
|
|
* It does not check, if the superblock has been modified, or
|
|
* if the filesystem has been mounted read-only. It is mainly
|
|
* called by hfs_sync_fs() and flush_mdb().
|
|
* Input Variable(s):
|
|
* struct hfs_mdb *mdb: Pointer to the hfs MDB
|
|
* int backup;
|
|
* Output Variable(s):
|
|
* NONE
|
|
* Returns:
|
|
* void
|
|
* Preconditions:
|
|
* 'mdb' points to a "valid" (struct hfs_mdb).
|
|
* Postconditions:
|
|
* The HFS MDB and on disk will be updated, by copying the possibly
|
|
* modified fields from the in memory MDB (in native byte order) to
|
|
* the disk block buffer.
|
|
* If 'backup' is non-zero then the alternate MDB is also written
|
|
* and the function doesn't return until it is actually on disk.
|
|
*/
|
|
void hfs_mdb_commit(struct super_block *sb)
|
|
{
|
|
struct hfs_mdb *mdb = HFS_SB(sb)->mdb;
|
|
|
|
if (sb_rdonly(sb))
|
|
return;
|
|
|
|
lock_buffer(HFS_SB(sb)->mdb_bh);
|
|
if (test_and_clear_bit(HFS_FLG_MDB_DIRTY, &HFS_SB(sb)->flags)) {
|
|
/* These parameters may have been modified, so write them back */
|
|
mdb->drLsMod = hfs_mtime();
|
|
mdb->drFreeBks = cpu_to_be16(HFS_SB(sb)->free_ablocks);
|
|
mdb->drNxtCNID = cpu_to_be32(HFS_SB(sb)->next_id);
|
|
mdb->drNmFls = cpu_to_be16(HFS_SB(sb)->root_files);
|
|
mdb->drNmRtDirs = cpu_to_be16(HFS_SB(sb)->root_dirs);
|
|
mdb->drFilCnt = cpu_to_be32(HFS_SB(sb)->file_count);
|
|
mdb->drDirCnt = cpu_to_be32(HFS_SB(sb)->folder_count);
|
|
|
|
/* write MDB to disk */
|
|
mark_buffer_dirty(HFS_SB(sb)->mdb_bh);
|
|
}
|
|
|
|
/* write the backup MDB, not returning until it is written.
|
|
* we only do this when either the catalog or extents overflow
|
|
* files grow. */
|
|
if (test_and_clear_bit(HFS_FLG_ALT_MDB_DIRTY, &HFS_SB(sb)->flags) &&
|
|
HFS_SB(sb)->alt_mdb) {
|
|
hfs_inode_write_fork(HFS_SB(sb)->ext_tree->inode, mdb->drXTExtRec,
|
|
&mdb->drXTFlSize, NULL);
|
|
hfs_inode_write_fork(HFS_SB(sb)->cat_tree->inode, mdb->drCTExtRec,
|
|
&mdb->drCTFlSize, NULL);
|
|
|
|
lock_buffer(HFS_SB(sb)->alt_mdb_bh);
|
|
memcpy(HFS_SB(sb)->alt_mdb, HFS_SB(sb)->mdb, HFS_SECTOR_SIZE);
|
|
HFS_SB(sb)->alt_mdb->drAtrb |= cpu_to_be16(HFS_SB_ATTRIB_UNMNT);
|
|
HFS_SB(sb)->alt_mdb->drAtrb &= cpu_to_be16(~HFS_SB_ATTRIB_INCNSTNT);
|
|
unlock_buffer(HFS_SB(sb)->alt_mdb_bh);
|
|
|
|
mark_buffer_dirty(HFS_SB(sb)->alt_mdb_bh);
|
|
sync_dirty_buffer(HFS_SB(sb)->alt_mdb_bh);
|
|
}
|
|
|
|
if (test_and_clear_bit(HFS_FLG_BITMAP_DIRTY, &HFS_SB(sb)->flags)) {
|
|
struct buffer_head *bh;
|
|
sector_t block;
|
|
char *ptr;
|
|
int off, size, len;
|
|
|
|
block = be16_to_cpu(HFS_SB(sb)->mdb->drVBMSt) + HFS_SB(sb)->part_start;
|
|
off = (block << HFS_SECTOR_SIZE_BITS) & (sb->s_blocksize - 1);
|
|
block >>= sb->s_blocksize_bits - HFS_SECTOR_SIZE_BITS;
|
|
size = (HFS_SB(sb)->fs_ablocks + 7) / 8;
|
|
ptr = (u8 *)HFS_SB(sb)->bitmap;
|
|
while (size) {
|
|
bh = sb_bread(sb, block);
|
|
if (!bh) {
|
|
pr_err("unable to read volume bitmap\n");
|
|
break;
|
|
}
|
|
len = min((int)sb->s_blocksize - off, size);
|
|
|
|
lock_buffer(bh);
|
|
memcpy(bh->b_data + off, ptr, len);
|
|
unlock_buffer(bh);
|
|
|
|
mark_buffer_dirty(bh);
|
|
brelse(bh);
|
|
block++;
|
|
off = 0;
|
|
ptr += len;
|
|
size -= len;
|
|
}
|
|
}
|
|
unlock_buffer(HFS_SB(sb)->mdb_bh);
|
|
}
|
|
|
|
void hfs_mdb_close(struct super_block *sb)
|
|
{
|
|
/* update volume attributes */
|
|
if (sb_rdonly(sb))
|
|
return;
|
|
HFS_SB(sb)->mdb->drAtrb |= cpu_to_be16(HFS_SB_ATTRIB_UNMNT);
|
|
HFS_SB(sb)->mdb->drAtrb &= cpu_to_be16(~HFS_SB_ATTRIB_INCNSTNT);
|
|
mark_buffer_dirty(HFS_SB(sb)->mdb_bh);
|
|
}
|
|
|
|
/*
|
|
* hfs_mdb_put()
|
|
*
|
|
* Release the resources associated with the in-core MDB. */
|
|
void hfs_mdb_put(struct super_block *sb)
|
|
{
|
|
if (!HFS_SB(sb))
|
|
return;
|
|
/* free the B-trees */
|
|
hfs_btree_close(HFS_SB(sb)->ext_tree);
|
|
hfs_btree_close(HFS_SB(sb)->cat_tree);
|
|
|
|
/* free the buffers holding the primary and alternate MDBs */
|
|
brelse(HFS_SB(sb)->mdb_bh);
|
|
brelse(HFS_SB(sb)->alt_mdb_bh);
|
|
|
|
unload_nls(HFS_SB(sb)->nls_io);
|
|
unload_nls(HFS_SB(sb)->nls_disk);
|
|
|
|
kfree(HFS_SB(sb)->bitmap);
|
|
kfree(HFS_SB(sb));
|
|
sb->s_fs_info = NULL;
|
|
}
|