Jakub Kicinski 0beea51b28 nfc: nci: clear NCI_DATA_EXCHANGE before calling completion callback ...

[ Upstream commit 0efdc02f4f ]

Move clear_bit(NCI_DATA_EXCHANGE) before invoking the data exchange
callback in nci_data_exchange_complete().

The callback (e.g. rawsock_data_exchange_complete) may immediately
schedule another data exchange via schedule_work(tx_work).  On a
multi-CPU system, tx_work can run and reach nci_transceive() before
the current nci_data_exchange_complete() clears the flag, causing
test_and_set_bit(NCI_DATA_EXCHANGE) to return -EBUSY and the new
transfer to fail.

This causes intermittent flakes in nci/nci_dev in NIPA:

  # #  RUN           NCI.NCI1_0.t4t_tag_read ...
  # # t4t_tag_read: Test terminated by timeout
  # #          FAIL  NCI.NCI1_0.t4t_tag_read
  # not ok 3 NCI.NCI1_0.t4t_tag_read

Fixes: 38f04c6b1b ("NFC: protect nci_data_exchange transactions")
Reviewed-by: Joe Damato <joe@dama.to>
Link: https://patch.msgid.link/20260303162346.2071888-5-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2026-03-13 17:20:45 +01:00

..

core.c

nfc: nci: free skb on nci_transceive early error paths

2026-03-13 17:20:44 +01:00

data.c

nfc: nci: clear NCI_DATA_EXCHANGE before calling completion callback

2026-03-13 17:20:45 +01:00

hci.c

…

Kconfig

…

lib.c

…

Makefile

…

ntf.c

net: nfc: nci: Fix parameter validation for packet data

2026-03-04 07:21:59 -05:00

rsp.c

…

spi.c

…

uart.c

…