Kuniyuki IwashimaandGreg Kroah-Hartman 119dcafe36 ipv6: Fix memleak of nhc_pcpu_rth_output in fib_check_nh_v6_gw(). ...

[ Upstream commit 9740890ee2 ]

fib_check_nh_v6_gw() expects that fib6_nh_init() cleans up everything
when it fails.

Commit 7dd73168e2 ("ipv6: Always allocate pcpu memory in a fib6_nh")
moved fib_nh_common_init() before alloc_percpu_gfp() within fib6_nh_init()
but forgot to add cleanup for fib6_nh->nh_common.nhc_pcpu_rth_output in
case it fails to allocate fib6_nh->rt6i_pcpu, resulting in memleak.

Let's call fib_nh_common_release() and clear nhc_pcpu_rth_output in the
error path.

Note that we can remove the fib6_nh_release() call in nh_create_ipv6()
later in net-next.git.

Fixes: 7dd73168e2 ("ipv6: Always allocate pcpu memory in a fib6_nh")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20250312010333.56001-1-kuniyu@amazon.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2025-03-28 21:59:53 +01:00

..

ila

net: ipv6: fix missing dst ref drop in ila lwtunnel

2025-03-13 12:58:32 +01:00

netfilter

netfilter: nf_reject_ipv6: fix potential crash in nf_send_reset6()

2024-11-08 16:28:19 +01:00

addrconf_core.c

…

addrconf.c

gre: Fix IPv6 link-local address generation.

2025-03-22 12:50:39 -07:00

addrlabel.c

…

af_inet6.c

net: inet6: do not leave a dangling sk pointer in inet6_create()

2024-12-14 20:00:04 +01:00

ah6.c

…

anycast.c

…

calipso.c

…

datagram.c

…

esp6_offload.c

…

esp6.c

…

exthdrs_core.c

…

exthdrs_offload.c

…

exthdrs.c

…

fib6_notifier.c

…

fib6_rules.c

…

fou6.c

…

icmp.c

ipv6: icmp: convert to dev_net_rcu()

2025-02-21 13:57:21 +01:00

inet6_connection_sock.c

…

inet6_hashtables.c

…

ioam6_iptunnel.c

…

ioam6.c

…

ip6_checksum.c

…

ip6_fib.c

ipv6: Fix soft lockups in fib6_select_path under high next hop churn

2025-02-01 18:37:52 +01:00

ip6_flowlabel.c

…

ip6_gre.c

…

ip6_icmp.c

…

ip6_input.c

…

ip6_offload.c

…

ip6_offload.h

…

ip6_output.c

inetpeer: do not get a refcount in inet_getpeer()

2025-02-08 09:51:53 +01:00

ip6_tunnel.c

ipv4: Convert ip_route_input() to dscp_t.

2025-03-07 16:45:39 +01:00

ip6_udp_tunnel.c

…

ip6_vti.c

…

ip6mr.c

inet: ipmr: fix data-races

2025-02-08 09:52:02 +01:00

ipcomp6.c

…

ipv6_sockglue.c

net: use unrcu_pointer() helper

2024-12-09 10:32:10 +01:00

Kconfig

net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL

2024-10-04 16:29:41 +02:00

Makefile

…

mcast_snoop.c

…

mcast.c

ipv6: mcast: add RCU protection to mld_newpack()

2025-02-21 13:57:24 +01:00

mip6.c

…

ndisc.c

ndisc: extend RCU protection in ndisc_send_skb()

2025-02-21 13:57:24 +01:00

netfilter.c

…

output_core.c

…

ping.c

ipv6: introduce dst_rt6_info() helper

2024-12-14 19:59:35 +01:00

proc.c

…

protocol.c

…

raw.c

ipv6: introduce dst_rt6_info() helper

2024-12-14 19:59:35 +01:00

reassembly.c

…

route.c

ipv6: Fix memleak of nhc_pcpu_rth_output in fib_check_nh_v6_gw().

2025-03-28 21:59:53 +01:00

rpl_iptunnel.c

net: ipv6: fix dst ref loop on input in rpl lwt

2025-03-07 16:45:42 +01:00

rpl.c

…

seg6_hmac.c

…

seg6_iptunnel.c

net: ipv6: fix dst ref loop on input in seg6 lwt

2025-03-07 16:45:42 +01:00

seg6_local.c

…

seg6.c

…

sit.c

…

syncookies.c

…

sysctl_net_ipv6.c

…

tcp_ipv6.c

net: fix data-races around sk->sk_forward_alloc

2025-01-23 17:21:19 +01:00

tcpv6_offload.c

…

tunnel6.c

…

udp_impl.h

…

udp_offload.c

…

udp.c

udp: gso: do not drop small packets when PMTU reduces

2025-02-17 09:40:12 +01:00

udplite.c

…

xfrm6_input.c

…

xfrm6_output.c

…

xfrm6_policy.c

ipv6: introduce dst_rt6_info() helper

2024-12-14 19:59:35 +01:00

xfrm6_protocol.c

…

xfrm6_state.c

…

xfrm6_tunnel.c

…