Felix Maurer d5d346deb6 xsk: Free skb when TX metadata options are invalid ...

[ Upstream commit 0c0d0f42ff ]

When a new skb is allocated for transmitting an xsk descriptor, i.e., for
every non-multibuf descriptor or the first frag of a multibuf descriptor,
but the descriptor is later found to have invalid options set for the TX
metadata, the new skb is never freed. This can leak skbs until the send
buffer is full which makes sending more packets impossible.

Fix this by freeing the skb in the error path if we are currently dealing
with the first frag, i.e., an skb allocated in this iteration of
xsk_build_skb.

Fixes: 48eb03dd26 ("xsk: Add TX timestamp and TX checksum offload support")
Reported-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: Felix Maurer <fmaurer@redhat.com>
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Acked-by: Martin KaFai Lau <martin.lau@kernel.org>
Link: https://patch.msgid.link/edb9b00fb19e680dff5a3350cd7581c5927975a8.1731581697.git.fmaurer@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2024-12-05 14:02:00 +01:00

..

Kconfig

…

Makefile

…

xdp_umem.c

…

xdp_umem.h

…

xsk_buff_pool.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2024-09-15 09:13:19 -07:00

xsk_diag.c

…

xsk_queue.c

…

xsk_queue.h

…

xsk.c

xsk: Free skb when TX metadata options are invalid

2024-12-05 14:02:00 +01:00

xsk.h

…

xskmap.c

…