mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-08-09 06:14:34 +02:00
Geert Uytterhoeven
7d4ea0365c
When building for m68k with CONFIG_M68000=y and C=1:
drivers/clk/rockchip/clk-rk3528.c: note: in included file (through include/linux/hash.h, include/linux/slab.h):
arch/m68k/include/asm/hash.h:57:24: warning: cast truncates bits from constant value (18720 becomes 8720)
arch/m68k/include/asm/hash.h:57:24: warning: cast truncates bits from constant value (1e8e8 becomes e8e8)
Sparse does not realize the truncation is intentional.
Make this explicit by using the lower_16_bits() helper instead, which
also masks the unwanted bits.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202605191434.PQkj2Rki-lkp@intel.com/
Reported-by: Heiko Stuebner <heiko@sntech.de>
Closes: https://lore.kernel.org/20260603213726.1025094-1-heiko@sntech.de/
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Daniel Palmer <daniel@thingy.jp>
Acked-by: Greg Ungerer <gerg@linux-m68k.org>
Link: https://patch.msgid.link/b55e9bd0532c0cad519809c86e0a8400060d75a1.1780559561.git.geert@linux-m68k.org
63 lines
2.1 KiB
C
63 lines
2.1 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _ASM_HASH_H
|
|
#define _ASM_HASH_H
|
|
|
|
#include <linux/wordpart.h>
|
|
|
|
/*
|
|
* If CONFIG_M68000=y (original mc68000/010), this file is #included
|
|
* to work around the lack of a MULU.L instruction.
|
|
*/
|
|
|
|
#define HAVE_ARCH__HASH_32 1
|
|
/*
|
|
* While it would be legal to substitute a different hash operation
|
|
* entirely, let's keep it simple and just use an optimized multiply
|
|
* by GOLDEN_RATIO_32 = 0x61C88647.
|
|
*
|
|
* The best way to do that appears to be to multiply by 0x8647 with
|
|
* shifts and adds, and use mulu.w to multiply the high half by 0x61C8.
|
|
*
|
|
* Because the 68000 has multi-cycle shifts, this addition chain is
|
|
* chosen to minimise the shift distances.
|
|
*
|
|
* Despite every attempt to spoon-feed it simple operations, GCC
|
|
* 6.1.1 doggedly insists on doing annoying things like converting
|
|
* "lsl.l #2,<reg>" (12 cycles) to two adds (8+8 cycles).
|
|
*
|
|
* It also likes to notice two shifts in a row, like "a = x << 2" and
|
|
* "a <<= 7", and convert that to "a = x << 9". But shifts longer
|
|
* than 8 bits are extra-slow on m68k, so that's a lose.
|
|
*
|
|
* Since the 68000 is a very simple in-order processor with no
|
|
* instruction scheduling effects on execution time, we can safely
|
|
* take it out of GCC's hands and write one big asm() block.
|
|
*
|
|
* Without calling overhead, this operation is 30 bytes (14 instructions
|
|
* plus one immediate constant) and 166 cycles.
|
|
*
|
|
* (Because %2 is fetched twice, it can't be postincrement, and thus it
|
|
* can't be a fully general "g" or "m". Register is preferred, but
|
|
* offsettable memory or immediate will work.)
|
|
*/
|
|
static inline u32 __attribute_const__ __hash_32(u32 x)
|
|
{
|
|
u32 a, b;
|
|
|
|
asm( "move.l %2,%0" /* a = x * 0x0001 */
|
|
"\n lsl.l #2,%0" /* a = x * 0x0004 */
|
|
"\n move.l %0,%1"
|
|
"\n lsl.l #7,%0" /* a = x * 0x0200 */
|
|
"\n add.l %2,%0" /* a = x * 0x0201 */
|
|
"\n add.l %0,%1" /* b = x * 0x0205 */
|
|
"\n add.l %0,%0" /* a = x * 0x0402 */
|
|
"\n add.l %0,%1" /* b = x * 0x0607 */
|
|
"\n lsl.l #5,%0" /* a = x * 0x8040 */
|
|
: "=&d,d" (a), "=&r,r" (b)
|
|
: "r,roi?" (x)); /* a+b = x*0x8647 */
|
|
|
|
return (lower_16_bits(x * 0x61c8) << 16) + a + b;
|
|
}
|
|
|
|
#endif /* _ASM_HASH_H */
|