mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-08-09 06:14:34 +02:00
Thorsten BlumandMadhavan Srinivasan
ea8b474b55
Replace sprintf() with sysfs_emit() and sysfs_emit_at() in sysfs show functions, which are preferred for formatting sysfs output because they provide safer bounds checking. While the current code only emits strings that fit easily within PAGE_SIZE, use sysfs_emit() and sysfs_emit_at() to follow secure coding best practices. This is a mechanical cleanup with a few simple edge cases: - In domains_show(), drop the redundant n < 0 check since neither sprintf() nor sysfs_emit() return negative values. - In powercap_show() and psr_show(), also drop the dead ret < 0 checks. - In ps3_fw_version_show(), normalize the output by adding a terminating newline as suggested by checkpatch. - In vio's modalias_show(), replace the deprecated strcpy() [1] followed by strlen() with sysfs_emit(). Leave validate_show() and the variable-length hv-gpci helpers unchanged since they already have explicit bounds handling, and converting those would be more than a mechanical conversion. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org> Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com> Link: https://patch.msgid.link/20260524130002.793476-2-thorsten.blum@linux.dev
74 lines
1.6 KiB
C
74 lines
1.6 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Interface for power-management for ppc64 compliant platform
|
|
*
|
|
* Manish Ahuja <mahuja@us.ibm.com>
|
|
*
|
|
* Feb 2007
|
|
*
|
|
* Copyright (C) 2007 IBM Corporation.
|
|
*/
|
|
|
|
#include <linux/kobject.h>
|
|
#include <linux/string.h>
|
|
#include <linux/sysfs.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/init.h>
|
|
#include <asm/machdep.h>
|
|
|
|
#include "pseries.h"
|
|
|
|
unsigned long rtas_poweron_auto; /* default and normal state is 0 */
|
|
|
|
static ssize_t auto_poweron_show(struct kobject *kobj,
|
|
struct kobj_attribute *attr, char *buf)
|
|
{
|
|
return sysfs_emit(buf, "%lu\n", rtas_poweron_auto);
|
|
}
|
|
|
|
static ssize_t auto_poweron_store(struct kobject *kobj,
|
|
struct kobj_attribute *attr,
|
|
const char *buf, size_t n)
|
|
{
|
|
int ret;
|
|
unsigned long ups_restart;
|
|
ret = sscanf(buf, "%lu", &ups_restart);
|
|
|
|
if ((ret == 1) && ((ups_restart == 1) || (ups_restart == 0))){
|
|
rtas_poweron_auto = ups_restart;
|
|
return n;
|
|
}
|
|
return -EINVAL;
|
|
}
|
|
|
|
static struct kobj_attribute auto_poweron_attr =
|
|
__ATTR(auto_poweron, 0644, auto_poweron_show, auto_poweron_store);
|
|
|
|
#ifndef CONFIG_PM
|
|
struct kobject *power_kobj;
|
|
|
|
static struct attribute *g[] = {
|
|
&auto_poweron_attr.attr,
|
|
NULL,
|
|
};
|
|
|
|
static const struct attribute_group attr_group = {
|
|
.attrs = g,
|
|
};
|
|
|
|
static int __init pm_init(void)
|
|
{
|
|
power_kobj = kobject_create_and_add("power", NULL);
|
|
if (!power_kobj)
|
|
return -ENOMEM;
|
|
return sysfs_create_group(power_kobj, &attr_group);
|
|
}
|
|
machine_core_initcall(pseries, pm_init);
|
|
#else
|
|
static int __init apo_pm_init(void)
|
|
{
|
|
return (sysfs_create_file(power_kobj, &auto_poweron_attr.attr));
|
|
}
|
|
machine_device_initcall(pseries, apo_pm_init);
|
|
#endif
|