mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-08-09 06:14:34 +02:00
The KMS framework uses two slightly different definitions for the state concept. For a given object (plane, CRTC, encoder, etc., so drm_$OBJECT_state), the state is the entire state of that object. However, at the device level, drm_atomic_state refers to a state update for a limited number of objects. Thus, drm_atomic_state isn't the entire device state, but only the full state of some objects in that device. This has been an endless source of confusion and thus bugs. We can rename the drm_atomic_state structure to drm_atomic_commit to make it less confusing. This patch was created using: rg -l drm_atomic_state | \ xargs sed -i 's/drm_atomic_state/drm_atomic_commit/g; s/drm_atomic_commit_helper/drm_atomic_state_helper/g' mv drivers/gpu/drm/tests/drm_atomic_state_test.c drivers/gpu/drm/tests/drm_atomic_commit_test.c Acked-by: Simona Vetter <simona.vetter@ffwll.ch> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Signed-off-by: Maxime Ripard <mripard@kernel.org> Signed-off-by: Dave Airlie <airlied@redhat.com> Link: https://patch.msgid.link/20260427-drm-drm-atomic-update-v4-1-c0e713bfdf25@kernel.org
309 lines
8.9 KiB
C
309 lines
8.9 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2012 Russell King
|
|
* Rewritten from the dovefb driver, and Armada510 manuals.
|
|
*/
|
|
|
|
#include <drm/drm_atomic.h>
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_fourcc.h>
|
|
#include <drm/drm_plane_helper.h>
|
|
#include <drm/drm_print.h>
|
|
|
|
#include "armada_crtc.h"
|
|
#include "armada_drm.h"
|
|
#include "armada_fb.h"
|
|
#include "armada_gem.h"
|
|
#include "armada_hw.h"
|
|
#include "armada_plane.h"
|
|
#include "armada_trace.h"
|
|
|
|
static const uint32_t armada_primary_formats[] = {
|
|
DRM_FORMAT_UYVY,
|
|
DRM_FORMAT_YUYV,
|
|
DRM_FORMAT_VYUY,
|
|
DRM_FORMAT_YVYU,
|
|
DRM_FORMAT_ARGB8888,
|
|
DRM_FORMAT_ABGR8888,
|
|
DRM_FORMAT_XRGB8888,
|
|
DRM_FORMAT_XBGR8888,
|
|
DRM_FORMAT_RGB888,
|
|
DRM_FORMAT_BGR888,
|
|
DRM_FORMAT_ARGB1555,
|
|
DRM_FORMAT_ABGR1555,
|
|
DRM_FORMAT_RGB565,
|
|
DRM_FORMAT_BGR565,
|
|
};
|
|
|
|
void armada_drm_plane_calc(struct drm_plane_state *state, u32 addrs[2][3],
|
|
u16 pitches[3], bool interlaced)
|
|
{
|
|
struct drm_framebuffer *fb = state->fb;
|
|
const struct drm_format_info *format = fb->format;
|
|
unsigned int num_planes = format->num_planes;
|
|
unsigned int x = state->src.x1 >> 16;
|
|
unsigned int y = state->src.y1 >> 16;
|
|
u32 addr = drm_fb_obj(fb)->dev_addr;
|
|
int i;
|
|
|
|
DRM_DEBUG_KMS("pitch %u x %d y %d bpp %d\n",
|
|
fb->pitches[0], x, y, format->cpp[0] * 8);
|
|
|
|
if (num_planes > 3)
|
|
num_planes = 3;
|
|
|
|
addrs[0][0] = addr + fb->offsets[0] + y * fb->pitches[0] +
|
|
x * format->cpp[0];
|
|
pitches[0] = fb->pitches[0];
|
|
|
|
y /= format->vsub;
|
|
x /= format->hsub;
|
|
|
|
for (i = 1; i < num_planes; i++) {
|
|
addrs[0][i] = addr + fb->offsets[i] + y * fb->pitches[i] +
|
|
x * format->cpp[i];
|
|
pitches[i] = fb->pitches[i];
|
|
}
|
|
for (; i < 3; i++) {
|
|
addrs[0][i] = 0;
|
|
pitches[i] = 0;
|
|
}
|
|
if (interlaced) {
|
|
for (i = 0; i < 3; i++) {
|
|
addrs[1][i] = addrs[0][i] + pitches[i];
|
|
pitches[i] *= 2;
|
|
}
|
|
} else {
|
|
for (i = 0; i < 3; i++)
|
|
addrs[1][i] = addrs[0][i];
|
|
}
|
|
}
|
|
|
|
int armada_drm_plane_atomic_check(struct drm_plane *plane,
|
|
struct drm_atomic_commit *state)
|
|
{
|
|
struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state,
|
|
plane);
|
|
struct armada_plane_state *st = to_armada_plane_state(new_plane_state);
|
|
struct drm_crtc *crtc = new_plane_state->crtc;
|
|
struct drm_crtc_state *crtc_state;
|
|
bool interlace;
|
|
int ret;
|
|
|
|
if (!new_plane_state->fb || WARN_ON(!new_plane_state->crtc)) {
|
|
new_plane_state->visible = false;
|
|
return 0;
|
|
}
|
|
|
|
crtc_state = drm_atomic_get_new_crtc_state(state, crtc);
|
|
ret = drm_atomic_helper_check_plane_state(new_plane_state, crtc_state,
|
|
0,
|
|
INT_MAX, true, false);
|
|
if (ret)
|
|
return ret;
|
|
|
|
interlace = crtc_state->adjusted_mode.flags & DRM_MODE_FLAG_INTERLACE;
|
|
if (interlace) {
|
|
if ((new_plane_state->dst.y1 | new_plane_state->dst.y2) & 1)
|
|
return -EINVAL;
|
|
st->src_hw = drm_rect_height(&new_plane_state->src) >> 17;
|
|
st->dst_yx = new_plane_state->dst.y1 >> 1;
|
|
st->dst_hw = drm_rect_height(&new_plane_state->dst) >> 1;
|
|
} else {
|
|
st->src_hw = drm_rect_height(&new_plane_state->src) >> 16;
|
|
st->dst_yx = new_plane_state->dst.y1;
|
|
st->dst_hw = drm_rect_height(&new_plane_state->dst);
|
|
}
|
|
|
|
st->src_hw <<= 16;
|
|
st->src_hw |= drm_rect_width(&new_plane_state->src) >> 16;
|
|
st->dst_yx <<= 16;
|
|
st->dst_yx |= new_plane_state->dst.x1 & 0x0000ffff;
|
|
st->dst_hw <<= 16;
|
|
st->dst_hw |= drm_rect_width(&new_plane_state->dst) & 0x0000ffff;
|
|
|
|
armada_drm_plane_calc(new_plane_state, st->addrs, st->pitches,
|
|
interlace);
|
|
st->interlace = interlace;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void armada_drm_primary_plane_atomic_update(struct drm_plane *plane,
|
|
struct drm_atomic_commit *state)
|
|
{
|
|
struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state,
|
|
plane);
|
|
struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state,
|
|
plane);
|
|
struct armada_crtc *dcrtc;
|
|
struct armada_regs *regs;
|
|
u32 cfg, cfg_mask, val;
|
|
unsigned int idx;
|
|
|
|
DRM_DEBUG_KMS("[PLANE:%d:%s]\n", plane->base.id, plane->name);
|
|
|
|
if (!new_state->fb || WARN_ON(!new_state->crtc))
|
|
return;
|
|
|
|
DRM_DEBUG_KMS("[PLANE:%d:%s] is on [CRTC:%d:%s] with [FB:%d] visible %u->%u\n",
|
|
plane->base.id, plane->name,
|
|
new_state->crtc->base.id, new_state->crtc->name,
|
|
new_state->fb->base.id,
|
|
old_state->visible, new_state->visible);
|
|
|
|
dcrtc = drm_to_armada_crtc(new_state->crtc);
|
|
regs = dcrtc->regs + dcrtc->regs_idx;
|
|
|
|
idx = 0;
|
|
if (!old_state->visible && new_state->visible) {
|
|
val = CFG_PDWN64x66;
|
|
if (drm_fb_to_armada_fb(new_state->fb)->fmt > CFG_420)
|
|
val |= CFG_PDWN256x24;
|
|
armada_reg_queue_mod(regs, idx, 0, val, LCD_SPU_SRAM_PARA1);
|
|
}
|
|
val = armada_src_hw(new_state);
|
|
if (armada_src_hw(old_state) != val)
|
|
armada_reg_queue_set(regs, idx, val, LCD_SPU_GRA_HPXL_VLN);
|
|
val = armada_dst_yx(new_state);
|
|
if (armada_dst_yx(old_state) != val)
|
|
armada_reg_queue_set(regs, idx, val, LCD_SPU_GRA_OVSA_HPXL_VLN);
|
|
val = armada_dst_hw(new_state);
|
|
if (armada_dst_hw(old_state) != val)
|
|
armada_reg_queue_set(regs, idx, val, LCD_SPU_GZM_HPXL_VLN);
|
|
if (old_state->src.x1 != new_state->src.x1 ||
|
|
old_state->src.y1 != new_state->src.y1 ||
|
|
old_state->fb != new_state->fb ||
|
|
new_state->crtc->state->mode_changed) {
|
|
armada_reg_queue_set(regs, idx, armada_addr(new_state, 0, 0),
|
|
LCD_CFG_GRA_START_ADDR0);
|
|
armada_reg_queue_set(regs, idx, armada_addr(new_state, 1, 0),
|
|
LCD_CFG_GRA_START_ADDR1);
|
|
armada_reg_queue_mod(regs, idx, armada_pitch(new_state, 0),
|
|
0xffff,
|
|
LCD_CFG_GRA_PITCH);
|
|
}
|
|
if (old_state->fb != new_state->fb ||
|
|
new_state->crtc->state->mode_changed) {
|
|
cfg = CFG_GRA_FMT(drm_fb_to_armada_fb(new_state->fb)->fmt) |
|
|
CFG_GRA_MOD(drm_fb_to_armada_fb(new_state->fb)->mod);
|
|
if (drm_fb_to_armada_fb(new_state->fb)->fmt > CFG_420)
|
|
cfg |= CFG_PALETTE_ENA;
|
|
if (new_state->visible)
|
|
cfg |= CFG_GRA_ENA;
|
|
if (to_armada_plane_state(new_state)->interlace)
|
|
cfg |= CFG_GRA_FTOGGLE;
|
|
cfg_mask = CFG_GRAFORMAT |
|
|
CFG_GRA_MOD(CFG_SWAPRB | CFG_SWAPUV |
|
|
CFG_SWAPYU | CFG_YUV2RGB) |
|
|
CFG_PALETTE_ENA | CFG_GRA_FTOGGLE |
|
|
CFG_GRA_ENA;
|
|
} else if (old_state->visible != new_state->visible) {
|
|
cfg = new_state->visible ? CFG_GRA_ENA : 0;
|
|
cfg_mask = CFG_GRA_ENA;
|
|
} else {
|
|
cfg = cfg_mask = 0;
|
|
}
|
|
if (drm_rect_width(&old_state->src) != drm_rect_width(&new_state->src) ||
|
|
drm_rect_width(&old_state->dst) != drm_rect_width(&new_state->dst)) {
|
|
cfg_mask |= CFG_GRA_HSMOOTH;
|
|
if (drm_rect_width(&new_state->src) >> 16 !=
|
|
drm_rect_width(&new_state->dst))
|
|
cfg |= CFG_GRA_HSMOOTH;
|
|
}
|
|
|
|
if (cfg_mask)
|
|
armada_reg_queue_mod(regs, idx, cfg, cfg_mask,
|
|
LCD_SPU_DMA_CTRL0);
|
|
|
|
dcrtc->regs_idx += idx;
|
|
}
|
|
|
|
static void armada_drm_primary_plane_atomic_disable(struct drm_plane *plane,
|
|
struct drm_atomic_commit *state)
|
|
{
|
|
struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state,
|
|
plane);
|
|
struct armada_crtc *dcrtc;
|
|
struct armada_regs *regs;
|
|
unsigned int idx = 0;
|
|
|
|
DRM_DEBUG_KMS("[PLANE:%d:%s]\n", plane->base.id, plane->name);
|
|
|
|
if (!old_state->crtc)
|
|
return;
|
|
|
|
DRM_DEBUG_KMS("[PLANE:%d:%s] was on [CRTC:%d:%s] with [FB:%d]\n",
|
|
plane->base.id, plane->name,
|
|
old_state->crtc->base.id, old_state->crtc->name,
|
|
old_state->fb->base.id);
|
|
|
|
dcrtc = drm_to_armada_crtc(old_state->crtc);
|
|
regs = dcrtc->regs + dcrtc->regs_idx;
|
|
|
|
/* Disable plane and power down most RAMs and FIFOs */
|
|
armada_reg_queue_mod(regs, idx, 0, CFG_GRA_ENA, LCD_SPU_DMA_CTRL0);
|
|
armada_reg_queue_mod(regs, idx, CFG_PDWN256x32 | CFG_PDWN256x24 |
|
|
CFG_PDWN32x32 | CFG_PDWN64x66,
|
|
0, LCD_SPU_SRAM_PARA1);
|
|
|
|
dcrtc->regs_idx += idx;
|
|
}
|
|
|
|
static const struct drm_plane_helper_funcs armada_primary_plane_helper_funcs = {
|
|
.atomic_check = armada_drm_plane_atomic_check,
|
|
.atomic_update = armada_drm_primary_plane_atomic_update,
|
|
.atomic_disable = armada_drm_primary_plane_atomic_disable,
|
|
};
|
|
|
|
void armada_plane_reset(struct drm_plane *plane)
|
|
{
|
|
struct armada_plane_state *st;
|
|
if (plane->state)
|
|
__drm_atomic_helper_plane_destroy_state(plane->state);
|
|
kfree(plane->state);
|
|
st = kzalloc_obj(*st);
|
|
if (st)
|
|
__drm_atomic_helper_plane_reset(plane, &st->base);
|
|
}
|
|
|
|
struct drm_plane_state *armada_plane_duplicate_state(struct drm_plane *plane)
|
|
{
|
|
struct armada_plane_state *st;
|
|
|
|
if (WARN_ON(!plane->state))
|
|
return NULL;
|
|
|
|
st = kmemdup(plane->state, sizeof(*st), GFP_KERNEL);
|
|
if (st)
|
|
__drm_atomic_helper_plane_duplicate_state(plane, &st->base);
|
|
|
|
return &st->base;
|
|
}
|
|
|
|
static const struct drm_plane_funcs armada_primary_plane_funcs = {
|
|
.update_plane = drm_atomic_helper_update_plane,
|
|
.disable_plane = drm_atomic_helper_disable_plane,
|
|
.destroy = drm_plane_helper_destroy,
|
|
.reset = armada_plane_reset,
|
|
.atomic_duplicate_state = armada_plane_duplicate_state,
|
|
.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
|
|
};
|
|
|
|
int armada_drm_primary_plane_init(struct drm_device *drm,
|
|
struct drm_plane *primary)
|
|
{
|
|
int ret;
|
|
|
|
drm_plane_helper_add(primary, &armada_primary_plane_helper_funcs);
|
|
|
|
ret = drm_universal_plane_init(drm, primary, 0,
|
|
&armada_primary_plane_funcs,
|
|
armada_primary_formats,
|
|
ARRAY_SIZE(armada_primary_formats),
|
|
NULL,
|
|
DRM_PLANE_TYPE_PRIMARY, NULL);
|
|
|
|
return ret;
|
|
}
|