mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-08-09 06:14:34 +02:00
intel_crtc_put_color_blobs() drops the CRTC color blob references, but
leaves the corresponding pointers unchanged.
This can matter in intel_crtc_prepare_cleared_state(), which frees the
old CRTC hw state before calling intel_dp_tunnel_atomic_clear_stream_bw().
The latter can fail while looking up the DP tunnel group state, for
example with -EDEADLK.
If that happens, the function returns without completing the cleared
state preparation. The failed atomic state will then be cleared by the
atomic core and intel_crtc_free_hw_state() can be called again for the
same state, dropping the same blob references again.
Clear the blob pointers after dropping the references so repeated cleanup
of the same CRTC hw state is safe.
Fixes: 77fcf58df1 ("drm/i915/dp_tunnel: Fix error handling when clearing stream BW in atomic state")
Suggested-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://patch.msgid.link/20260612035310.3013066-1-lgs201920130244@gmail.com
(cherry picked from commit d5005addb5f68e8a0edce249506757bdc9e3d8c8)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
375 lines
12 KiB
C
375 lines
12 KiB
C
/*
|
|
* Copyright © 2015 Intel Corporation
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
* DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
|
|
/**
|
|
* DOC: atomic modeset support
|
|
*
|
|
* The functions here implement the state management and hardware programming
|
|
* dispatch required by the atomic modeset infrastructure.
|
|
* See intel_plane.c for the plane-specific atomic functionality.
|
|
*/
|
|
|
|
#include <drm/display/drm_dp_tunnel.h>
|
|
#include <drm/drm_atomic.h>
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_fourcc.h>
|
|
#include <drm/drm_print.h>
|
|
|
|
#include "intel_atomic.h"
|
|
#include "intel_cdclk.h"
|
|
#include "intel_display_core.h"
|
|
#include "intel_display_types.h"
|
|
#include "intel_dp_tunnel.h"
|
|
#include "intel_fb.h"
|
|
#include "intel_global_state.h"
|
|
#include "intel_hdcp.h"
|
|
#include "intel_psr.h"
|
|
#include "skl_universal_plane.h"
|
|
|
|
/**
|
|
* intel_digital_connector_atomic_get_property - hook for connector->atomic_get_property.
|
|
* @connector: Connector to get the property for.
|
|
* @state: Connector state to retrieve the property from.
|
|
* @property: Property to retrieve.
|
|
* @val: Return value for the property.
|
|
*
|
|
* Returns the atomic property value for a digital connector.
|
|
*/
|
|
int intel_digital_connector_atomic_get_property(struct drm_connector *connector,
|
|
const struct drm_connector_state *state,
|
|
struct drm_property *property,
|
|
u64 *val)
|
|
{
|
|
struct intel_display *display = to_intel_display(connector->dev);
|
|
const struct intel_digital_connector_state *intel_conn_state =
|
|
to_intel_digital_connector_state(state);
|
|
|
|
if (property == display->properties.force_audio)
|
|
*val = intel_conn_state->force_audio;
|
|
else if (property == display->properties.broadcast_rgb)
|
|
*val = intel_conn_state->broadcast_rgb;
|
|
else {
|
|
drm_dbg_atomic(display->drm,
|
|
"Unknown property [PROP:%d:%s]\n",
|
|
property->base.id, property->name);
|
|
return -EINVAL;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* intel_digital_connector_atomic_set_property - hook for connector->atomic_set_property.
|
|
* @connector: Connector to set the property for.
|
|
* @state: Connector state to set the property on.
|
|
* @property: Property to set.
|
|
* @val: New value for the property.
|
|
*
|
|
* Sets the atomic property value for a digital connector.
|
|
*/
|
|
int intel_digital_connector_atomic_set_property(struct drm_connector *connector,
|
|
struct drm_connector_state *state,
|
|
struct drm_property *property,
|
|
u64 val)
|
|
{
|
|
struct intel_display *display = to_intel_display(connector->dev);
|
|
struct intel_digital_connector_state *intel_conn_state =
|
|
to_intel_digital_connector_state(state);
|
|
|
|
if (property == display->properties.force_audio) {
|
|
intel_conn_state->force_audio = val;
|
|
return 0;
|
|
}
|
|
|
|
if (property == display->properties.broadcast_rgb) {
|
|
intel_conn_state->broadcast_rgb = val;
|
|
return 0;
|
|
}
|
|
|
|
drm_dbg_atomic(display->drm, "Unknown property [PROP:%d:%s]\n",
|
|
property->base.id, property->name);
|
|
return -EINVAL;
|
|
}
|
|
|
|
int intel_digital_connector_atomic_check(struct drm_connector *conn,
|
|
struct drm_atomic_commit *state)
|
|
{
|
|
struct drm_connector_state *new_state =
|
|
drm_atomic_get_new_connector_state(state, conn);
|
|
struct intel_digital_connector_state *new_conn_state =
|
|
to_intel_digital_connector_state(new_state);
|
|
struct drm_connector_state *old_state =
|
|
drm_atomic_get_old_connector_state(state, conn);
|
|
struct intel_digital_connector_state *old_conn_state =
|
|
to_intel_digital_connector_state(old_state);
|
|
struct drm_crtc_state *crtc_state;
|
|
|
|
intel_hdcp_atomic_check(conn, old_state, new_state);
|
|
|
|
if (!new_state->crtc)
|
|
return 0;
|
|
|
|
crtc_state = drm_atomic_get_new_crtc_state(state, new_state->crtc);
|
|
|
|
/*
|
|
* These properties are handled by fastset, and might not end
|
|
* up in a modeset.
|
|
*/
|
|
if (new_conn_state->force_audio != old_conn_state->force_audio ||
|
|
new_conn_state->broadcast_rgb != old_conn_state->broadcast_rgb ||
|
|
new_conn_state->base.colorspace != old_conn_state->base.colorspace ||
|
|
new_conn_state->base.picture_aspect_ratio != old_conn_state->base.picture_aspect_ratio ||
|
|
new_conn_state->base.content_type != old_conn_state->base.content_type ||
|
|
new_conn_state->base.scaling_mode != old_conn_state->base.scaling_mode ||
|
|
new_conn_state->base.privacy_screen_sw_state != old_conn_state->base.privacy_screen_sw_state ||
|
|
!drm_connector_atomic_hdr_metadata_equal(old_state, new_state))
|
|
crtc_state->mode_changed = true;
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* intel_digital_connector_duplicate_state - duplicate connector state
|
|
* @connector: digital connector
|
|
*
|
|
* Allocates and returns a copy of the connector state (both common and
|
|
* digital connector specific) for the specified connector.
|
|
*
|
|
* Returns: The newly allocated connector state, or NULL on failure.
|
|
*/
|
|
struct drm_connector_state *
|
|
intel_digital_connector_duplicate_state(struct drm_connector *connector)
|
|
{
|
|
struct intel_digital_connector_state *state;
|
|
|
|
state = kmemdup(connector->state, sizeof(*state), GFP_KERNEL);
|
|
if (!state)
|
|
return NULL;
|
|
|
|
__drm_atomic_helper_connector_duplicate_state(connector, &state->base);
|
|
return &state->base;
|
|
}
|
|
|
|
/**
|
|
* intel_connector_needs_modeset - check if connector needs a modeset
|
|
* @state: the atomic state corresponding to this modeset
|
|
* @connector: the connector
|
|
*/
|
|
bool
|
|
intel_connector_needs_modeset(struct intel_atomic_state *state,
|
|
struct drm_connector *connector)
|
|
{
|
|
const struct drm_connector_state *old_conn_state, *new_conn_state;
|
|
|
|
old_conn_state = drm_atomic_get_old_connector_state(&state->base, connector);
|
|
new_conn_state = drm_atomic_get_new_connector_state(&state->base, connector);
|
|
|
|
return old_conn_state->crtc != new_conn_state->crtc ||
|
|
(new_conn_state->crtc &&
|
|
drm_atomic_crtc_needs_modeset(drm_atomic_get_new_crtc_state(&state->base,
|
|
new_conn_state->crtc)));
|
|
}
|
|
|
|
/**
|
|
* intel_any_crtc_needs_modeset - check if any CRTC needs a modeset
|
|
* @state: the atomic state corresponding to this modeset
|
|
*
|
|
* Returns true if any CRTC in @state needs a modeset.
|
|
*/
|
|
bool intel_any_crtc_needs_modeset(struct intel_atomic_state *state)
|
|
{
|
|
struct intel_crtc *crtc;
|
|
struct intel_crtc_state *crtc_state;
|
|
|
|
for_each_new_intel_crtc_in_state(state, crtc, crtc_state) {
|
|
if (intel_crtc_needs_modeset(crtc_state))
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
struct intel_digital_connector_state *
|
|
intel_atomic_get_digital_connector_state(struct intel_atomic_state *state,
|
|
struct intel_connector *connector)
|
|
{
|
|
struct drm_connector_state *conn_state;
|
|
|
|
conn_state = drm_atomic_get_connector_state(&state->base,
|
|
&connector->base);
|
|
if (IS_ERR(conn_state))
|
|
return ERR_CAST(conn_state);
|
|
|
|
return to_intel_digital_connector_state(conn_state);
|
|
}
|
|
|
|
/**
|
|
* intel_crtc_duplicate_state - duplicate crtc state
|
|
* @crtc: drm crtc
|
|
*
|
|
* Allocates and returns a copy of the crtc state (both common and
|
|
* Intel-specific) for the specified crtc.
|
|
*
|
|
* Returns: The newly allocated crtc state, or NULL on failure.
|
|
*/
|
|
struct drm_crtc_state *
|
|
intel_crtc_duplicate_state(struct drm_crtc *crtc)
|
|
{
|
|
const struct intel_crtc_state *old_crtc_state = to_intel_crtc_state(crtc->state);
|
|
struct intel_crtc_state *crtc_state;
|
|
|
|
crtc_state = kmemdup(old_crtc_state, sizeof(*crtc_state), GFP_KERNEL);
|
|
if (!crtc_state)
|
|
return NULL;
|
|
|
|
__drm_atomic_helper_crtc_duplicate_state(crtc, &crtc_state->uapi);
|
|
|
|
/* copy color blobs */
|
|
if (crtc_state->hw.degamma_lut)
|
|
drm_property_blob_get(crtc_state->hw.degamma_lut);
|
|
if (crtc_state->hw.ctm)
|
|
drm_property_blob_get(crtc_state->hw.ctm);
|
|
if (crtc_state->hw.gamma_lut)
|
|
drm_property_blob_get(crtc_state->hw.gamma_lut);
|
|
|
|
if (crtc_state->pre_csc_lut)
|
|
drm_property_blob_get(crtc_state->pre_csc_lut);
|
|
if (crtc_state->post_csc_lut)
|
|
drm_property_blob_get(crtc_state->post_csc_lut);
|
|
|
|
if (crtc_state->dp_tunnel_ref.tunnel)
|
|
drm_dp_tunnel_ref_get(crtc_state->dp_tunnel_ref.tunnel,
|
|
&crtc_state->dp_tunnel_ref);
|
|
|
|
crtc_state->update_pipe = false;
|
|
crtc_state->update_m_n = false;
|
|
crtc_state->update_lrr = false;
|
|
crtc_state->disable_cxsr = false;
|
|
crtc_state->update_wm_pre = false;
|
|
crtc_state->update_wm_post = false;
|
|
crtc_state->fifo_changed = false;
|
|
crtc_state->preload_luts = false;
|
|
crtc_state->wm.need_postvbl_update = false;
|
|
crtc_state->do_async_flip = false;
|
|
crtc_state->fb_bits = 0;
|
|
crtc_state->update_planes = 0;
|
|
crtc_state->dsb_color = NULL;
|
|
crtc_state->dsb_commit = NULL;
|
|
crtc_state->use_dsb = false;
|
|
|
|
return &crtc_state->uapi;
|
|
}
|
|
|
|
static void intel_crtc_put_color_blobs(struct intel_crtc_state *crtc_state)
|
|
{
|
|
drm_property_blob_put(crtc_state->hw.degamma_lut);
|
|
drm_property_blob_put(crtc_state->hw.gamma_lut);
|
|
drm_property_blob_put(crtc_state->hw.ctm);
|
|
|
|
drm_property_blob_put(crtc_state->pre_csc_lut);
|
|
drm_property_blob_put(crtc_state->post_csc_lut);
|
|
|
|
crtc_state->hw.degamma_lut = NULL;
|
|
crtc_state->hw.gamma_lut = NULL;
|
|
crtc_state->hw.ctm = NULL;
|
|
crtc_state->pre_csc_lut = NULL;
|
|
crtc_state->post_csc_lut = NULL;
|
|
}
|
|
|
|
void intel_crtc_free_hw_state(struct intel_crtc_state *crtc_state)
|
|
{
|
|
intel_crtc_put_color_blobs(crtc_state);
|
|
}
|
|
|
|
/**
|
|
* intel_crtc_destroy_state - destroy crtc state
|
|
* @crtc: drm crtc
|
|
* @state: the state to destroy
|
|
*
|
|
* Destroys the crtc state (both common and Intel-specific) for the
|
|
* specified crtc.
|
|
*/
|
|
void
|
|
intel_crtc_destroy_state(struct drm_crtc *crtc,
|
|
struct drm_crtc_state *state)
|
|
{
|
|
struct intel_crtc_state *crtc_state = to_intel_crtc_state(state);
|
|
|
|
drm_WARN_ON(crtc->dev, crtc_state->dsb_color);
|
|
drm_WARN_ON(crtc->dev, crtc_state->dsb_commit);
|
|
|
|
__drm_atomic_helper_crtc_destroy_state(&crtc_state->uapi);
|
|
intel_crtc_free_hw_state(crtc_state);
|
|
if (crtc_state->dp_tunnel_ref.tunnel)
|
|
drm_dp_tunnel_ref_put(&crtc_state->dp_tunnel_ref);
|
|
kfree(crtc_state);
|
|
}
|
|
|
|
struct drm_atomic_commit *
|
|
intel_atomic_state_alloc(struct drm_device *dev)
|
|
{
|
|
struct intel_atomic_state *state = kzalloc_obj(*state);
|
|
|
|
if (!state || drm_atomic_commit_init(dev, &state->base) < 0) {
|
|
kfree(state);
|
|
return NULL;
|
|
}
|
|
|
|
return &state->base;
|
|
}
|
|
|
|
void intel_atomic_state_free(struct drm_atomic_commit *_state)
|
|
{
|
|
struct intel_atomic_state *state = to_intel_atomic_state(_state);
|
|
|
|
drm_atomic_commit_default_release(&state->base);
|
|
kfree(state->global_objs);
|
|
kfree(state);
|
|
}
|
|
|
|
void intel_atomic_state_clear(struct drm_atomic_commit *s)
|
|
{
|
|
struct intel_atomic_state *state = to_intel_atomic_state(s);
|
|
|
|
drm_atomic_commit_default_clear(&state->base);
|
|
intel_atomic_clear_global_state(state);
|
|
|
|
/* state->internal not reset on purpose */
|
|
|
|
state->dpll_set = state->modeset = false;
|
|
|
|
intel_dp_tunnel_atomic_cleanup_inherited_state(state);
|
|
}
|
|
|
|
struct intel_crtc_state *
|
|
intel_atomic_get_crtc_state(struct drm_atomic_commit *state,
|
|
struct intel_crtc *crtc)
|
|
{
|
|
struct drm_crtc_state *crtc_state;
|
|
crtc_state = drm_atomic_get_crtc_state(state, &crtc->base);
|
|
if (IS_ERR(crtc_state))
|
|
return ERR_CAST(crtc_state);
|
|
|
|
return to_intel_crtc_state(crtc_state);
|
|
}
|