mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-08-09 06:14:34 +02:00
Runyu XiaoandJonathan Cameron
6e1b9bff12
devm_adis_probe_trigger() registers iio_trigger_generic_data_rdy_poll()
through devm_request_irq() on the non-FIFO path, but it does not add
IRQF_NO_THREAD to the IRQ flags.
When the kernel is booted with forced IRQ threading, the parent IRQ can
otherwise be threaded by the IRQ core and the subsequent IIO trigger
child IRQ is then dispatched from irq/... thread context instead of
hardirq context. Because iio_trigger_generic_data_rdy_poll()
immediately drives iio_trigger_poll(), this violates the hardirq-only
IIO trigger helper contract and can push downstream trigger consumers
through the wrong execution context.
Add IRQF_NO_THREAD on top of the existing adis->irq_flag value for the
non-FIFO request_irq() path, while preserving the current trigger
polarity and IRQF_NO_AUTOEN behavior.
Fixes: fec86c6b83 ("iio: imu: adis: Add Managed device functions")
Cc: stable@vger.kernel.org
Signed-off-by: Runyu Xiao <runyu.xiao@seu.edu.cn>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
107 lines
3.0 KiB
C
107 lines
3.0 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* Common library for ADIS16XXX devices
|
|
*
|
|
* Copyright 2012 Analog Devices Inc.
|
|
* Author: Lars-Peter Clausen <lars@metafoo.de>
|
|
*/
|
|
|
|
#include <linux/interrupt.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/spi/spi.h>
|
|
#include <linux/export.h>
|
|
|
|
#include <linux/iio/iio.h>
|
|
#include <linux/iio/trigger.h>
|
|
#include <linux/iio/imu/adis.h>
|
|
|
|
static int adis_data_rdy_trigger_set_state(struct iio_trigger *trig, bool state)
|
|
{
|
|
struct adis *adis = iio_trigger_get_drvdata(trig);
|
|
|
|
return adis_enable_irq(adis, state);
|
|
}
|
|
|
|
static const struct iio_trigger_ops adis_trigger_ops = {
|
|
.set_trigger_state = &adis_data_rdy_trigger_set_state,
|
|
};
|
|
|
|
static int adis_validate_irq_flag(struct adis *adis)
|
|
{
|
|
unsigned long direction = adis->irq_flag & IRQF_TRIGGER_MASK;
|
|
|
|
/* We cannot mask the interrupt so ensure it's not enabled at request */
|
|
if (adis->data->unmasked_drdy)
|
|
adis->irq_flag |= IRQF_NO_AUTOEN;
|
|
/*
|
|
* Typically adis devices without FIFO have data ready either on the
|
|
* rising edge or on the falling edge of the data ready pin.
|
|
* IMU devices with FIFO support have the watermark pin level driven
|
|
* either high or low when the FIFO is filled with the desired number
|
|
* of samples.
|
|
* It defaults to IRQF_TRIGGER_RISING for backward compatibility with
|
|
* devices that don't support changing the pin polarity.
|
|
*/
|
|
if (direction == IRQF_TRIGGER_NONE) {
|
|
adis->irq_flag |= IRQF_TRIGGER_RISING;
|
|
return 0;
|
|
} else if (direction != IRQF_TRIGGER_RISING &&
|
|
direction != IRQF_TRIGGER_FALLING && !adis->data->has_fifo) {
|
|
dev_err(&adis->spi->dev, "Invalid IRQ mask: %08lx\n",
|
|
adis->irq_flag);
|
|
return -EINVAL;
|
|
} else if (direction != IRQF_TRIGGER_HIGH &&
|
|
direction != IRQF_TRIGGER_LOW && adis->data->has_fifo) {
|
|
dev_err(&adis->spi->dev, "Invalid IRQ mask: %08lx\n",
|
|
adis->irq_flag);
|
|
return -EINVAL;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* devm_adis_probe_trigger() - Sets up trigger for a managed adis device
|
|
* @adis: The adis device
|
|
* @indio_dev: The IIO device
|
|
*
|
|
* Returns 0 on success or a negative error code
|
|
*/
|
|
int devm_adis_probe_trigger(struct adis *adis, struct iio_dev *indio_dev)
|
|
{
|
|
int ret;
|
|
|
|
adis->trig = devm_iio_trigger_alloc(&adis->spi->dev, "%s-dev%d",
|
|
indio_dev->name,
|
|
iio_device_id(indio_dev));
|
|
if (!adis->trig)
|
|
return -ENOMEM;
|
|
|
|
adis->trig->ops = &adis_trigger_ops;
|
|
iio_trigger_set_drvdata(adis->trig, adis);
|
|
|
|
ret = adis_validate_irq_flag(adis);
|
|
if (ret)
|
|
return ret;
|
|
|
|
if (adis->data->has_fifo)
|
|
ret = devm_request_threaded_irq(&adis->spi->dev, adis->spi->irq,
|
|
NULL,
|
|
&iio_trigger_generic_data_rdy_poll,
|
|
adis->irq_flag | IRQF_ONESHOT,
|
|
indio_dev->name,
|
|
adis->trig);
|
|
else
|
|
ret = devm_request_irq(&adis->spi->dev, adis->spi->irq,
|
|
&iio_trigger_generic_data_rdy_poll,
|
|
adis->irq_flag | IRQF_NO_THREAD,
|
|
indio_dev->name,
|
|
adis->trig);
|
|
if (ret)
|
|
return ret;
|
|
|
|
return devm_iio_trigger_register(&adis->spi->dev, adis->trig);
|
|
}
|
|
EXPORT_SYMBOL_NS_GPL(devm_adis_probe_trigger, "IIO_ADISLIB");
|
|
|