mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-08-09 06:14:34 +02:00
[BUG] The following script (already submitted as generic/798) will report incorrect dirty page numbers, with 64K page size systems and 4K fs block size: # mkfs.btrfs -s 4k -f $dev # mount $dev $mnt # xfs_io -f -c "pwrite 0 64K" -c fsync -c "cachestat 0 64K" $mnt/foobar Cached: 1, Dirty: 1, Writeback: 0, Evicted: 0, Recently Evicted: 0 Note that the dirtied page number is still 1. [CAUSE] The cachestat() goes through the XArray of the page cache, but instead of checking each folio's flag, it uses the PAGECACHE_TAG_DIRTY tag to report dirty pages. Since commit095be159f3("btrfs: unify folio dirty flag clearing"), btrfs replaced a folio_clear_dirty_for_io() call inside extent_write_cache_pages() with folio_test_dirty(). This will cause the following call sequence for the folio at file offset 0: extent_write_cache_pages() |- folio_test_dirty() | The folio is still dirty, continue to writeback. | |- extent_writepage() |- extent_writepage_io() |- submit_one_sector() for range [0, 4K) | |- btrfs_folio_clear_dirty() | |- btrfs_folio_set_writeback() | |- folio_start_writeback() | It's the first writeback block, we set the writeback | flag for the folio. | But the folio is still dirty, PAGECACHE_TAG_DIRTY is | kept | |- submit_one_sector() for range [4K, 8K) | |- btrfs_folio_clear_dirty() | |- btrfs_folio_set_writeback() | The folio already has writeback flag, no need to call | folio_start_writeback() | | ... |- submit_one_sector() for range [60K, 64K) |- btrfs_folio_clear_dirty() |- btrfs_folio_set_writeback() The folio already has writeback flag, no need to call folio_start_writeback() So the PAGECACHE_TAG_DIRTY is never cleared. Meanwhile for the old code, before that commit, the sequence looks like: extent_write_cache_pages() |- folio_clear_dirty_for_io() | The folio is still dirty, so continue to writeback. | But the folio dirty flag is cleared now. | |- extent_writepage() |- extent_writepage_io() |- submit_one_sector() for range [0, 4K) | |- btrfs_folio_clear_dirty() | |- btrfs_folio_set_writeback() | |- folio_start_writeback() | |- xas_clear(PAGECACHE_TAG) | | It's the first writeback block, we set the writeback | flag for the folio. | And the folio is not dirty, PAGECACHE_TAG_DIRTY is | cleared | |- submit_one_sector() for range [4K, 8K) | |- btrfs_folio_clear_dirty() | |- btrfs_folio_set_writeback() | The folio already has writeback flag, no need to call | folio_start_writeback() | | ... |- submit_one_sector() for range [60K, 64K) |- btrfs_folio_clear_dirty() |- btrfs_folio_set_writeback() The folio already has writeback flag, no need to call folio_start_writeback() Unlike the new code, old code will clear PAGECACHE_TAG_DIRTY for the first writeback block. There is a deeper problem, dirty and writeback folio flags are updated at very different timing. The dirty flag is only cleared when the last sub-folio block has dirty flag cleared. But the writeback flag is set when the first block starts writeback, and later blocks that go through writeback will not call folio_start_writeback() again. If we rely on folio_start_writeback() to update the PAGECACHE_TAG_DIRTY and PAGECACHE_TAG_TOWRITE, it will always be incorrect in one way or another. [FIX] Do not let folio_start_writeback() do any PAGECACHE_TAG_TOWRITE handling. Instead, manually clear both PAGECACHE_TAG_TOWRITE and PAGECACHE_TAG_DIRTY flags when the folio is no longer dirty during btrfs_subpage_set_writeback(). However this is only a hot-fix, for the long term solution we will follow iomap, by calling folio_start_writeback() immediately for the whole folio, and folio_end_writeback() after all writeback finished for the folio. Fixes:095be159f3("btrfs: unify folio dirty flag clearing") Reviewed-by: Boris Burkov <boris@bur.io> Signed-off-by: Qu Wenruo <wqu@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
787 lines
25 KiB
C
787 lines
25 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
#include <linux/slab.h>
|
|
#include "messages.h"
|
|
#include "subpage.h"
|
|
#include "btrfs_inode.h"
|
|
|
|
/*
|
|
* Subpage (block size < folio size) support overview:
|
|
*
|
|
* Limitations:
|
|
*
|
|
* - Metadata must be fully aligned to node size
|
|
* So when nodesize <= page size, the metadata can never cross folio boundaries.
|
|
*
|
|
* - Only support blocks per folio <= min(BTRFS_MAX_FOLIO_SIZE / fs block size,
|
|
* BTRFS_MAX_BLOCKS_PER_FOLIO)
|
|
* This is to ensure we can afford an on-stack bitmap, without the need to allocate
|
|
* bitmap memory at runtime.
|
|
*
|
|
* Implementation:
|
|
*
|
|
* - Common
|
|
* Both metadata and data will use a new structure, btrfs_folio_state, to
|
|
* record the status of each sector inside a page. This provides the extra
|
|
* granularity needed.
|
|
*
|
|
* - Metadata
|
|
* Since we have multiple tree blocks inside one page, we can't rely on page
|
|
* locking anymore, or we will have greatly reduced concurrency or even
|
|
* deadlocks (hold one tree lock while trying to lock another tree lock in
|
|
* the same page).
|
|
*
|
|
* Thus for metadata locking, subpage support relies on io_tree locking only.
|
|
* This means a slightly higher tree locking latency.
|
|
*/
|
|
|
|
int btrfs_attach_folio_state(const struct btrfs_fs_info *fs_info,
|
|
struct folio *folio, enum btrfs_folio_type type)
|
|
{
|
|
struct btrfs_folio_state *bfs;
|
|
|
|
/* For metadata we don't support large folio yet. */
|
|
if (type == BTRFS_SUBPAGE_METADATA)
|
|
ASSERT(!folio_test_large(folio));
|
|
|
|
/*
|
|
* We have cases like a dummy extent buffer page, which is not mapped
|
|
* and doesn't need to be locked.
|
|
*/
|
|
if (folio->mapping)
|
|
ASSERT(folio_test_locked(folio));
|
|
|
|
/* Either not subpage, or the folio already has private attached. */
|
|
if (folio_test_private(folio))
|
|
return 0;
|
|
if (type == BTRFS_SUBPAGE_METADATA && !btrfs_meta_is_subpage(fs_info))
|
|
return 0;
|
|
if (type == BTRFS_SUBPAGE_DATA && !btrfs_is_subpage(fs_info, folio))
|
|
return 0;
|
|
|
|
bfs = btrfs_alloc_folio_state(fs_info, folio_size(folio), type);
|
|
if (IS_ERR(bfs))
|
|
return PTR_ERR(bfs);
|
|
|
|
folio_attach_private(folio, bfs);
|
|
return 0;
|
|
}
|
|
|
|
void btrfs_detach_folio_state(const struct btrfs_fs_info *fs_info, struct folio *folio,
|
|
enum btrfs_folio_type type)
|
|
{
|
|
struct btrfs_folio_state *bfs;
|
|
|
|
/* Either not subpage, or the folio already has private attached. */
|
|
if (!folio_test_private(folio))
|
|
return;
|
|
if (type == BTRFS_SUBPAGE_METADATA && !btrfs_meta_is_subpage(fs_info))
|
|
return;
|
|
if (type == BTRFS_SUBPAGE_DATA && !btrfs_is_subpage(fs_info, folio))
|
|
return;
|
|
|
|
bfs = folio_detach_private(folio);
|
|
ASSERT(bfs);
|
|
btrfs_free_folio_state(bfs);
|
|
}
|
|
|
|
struct btrfs_folio_state *btrfs_alloc_folio_state(const struct btrfs_fs_info *fs_info,
|
|
size_t fsize, enum btrfs_folio_type type)
|
|
{
|
|
struct btrfs_folio_state *ret;
|
|
unsigned int real_size;
|
|
|
|
ASSERT(fs_info->sectorsize < fsize);
|
|
|
|
real_size = struct_size(ret, bitmaps,
|
|
BITS_TO_LONGS(btrfs_bitmap_nr_max *
|
|
(fsize >> fs_info->sectorsize_bits)));
|
|
ret = kzalloc(real_size, GFP_NOFS);
|
|
if (!ret)
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
spin_lock_init(&ret->lock);
|
|
if (type == BTRFS_SUBPAGE_METADATA)
|
|
atomic_set(&ret->eb_refs, 0);
|
|
else
|
|
atomic_set(&ret->nr_locked, 0);
|
|
return ret;
|
|
}
|
|
|
|
/*
|
|
* Increase the eb_refs of current subpage.
|
|
*
|
|
* This is important for eb allocation, to prevent race with last eb freeing
|
|
* of the same page.
|
|
* With the eb_refs increased before the eb inserted into radix tree,
|
|
* detach_extent_buffer_page() won't detach the folio private while we're still
|
|
* allocating the extent buffer.
|
|
*/
|
|
void btrfs_folio_inc_eb_refs(const struct btrfs_fs_info *fs_info, struct folio *folio)
|
|
{
|
|
struct btrfs_folio_state *bfs;
|
|
|
|
if (!btrfs_meta_is_subpage(fs_info))
|
|
return;
|
|
|
|
ASSERT(folio_test_private(folio) && folio->mapping);
|
|
lockdep_assert_held(&folio->mapping->i_private_lock);
|
|
|
|
bfs = folio_get_private(folio);
|
|
atomic_inc(&bfs->eb_refs);
|
|
}
|
|
|
|
void btrfs_folio_dec_eb_refs(const struct btrfs_fs_info *fs_info, struct folio *folio)
|
|
{
|
|
struct btrfs_folio_state *bfs;
|
|
|
|
if (!btrfs_meta_is_subpage(fs_info))
|
|
return;
|
|
|
|
ASSERT(folio_test_private(folio) && folio->mapping);
|
|
lockdep_assert_held(&folio->mapping->i_private_lock);
|
|
|
|
bfs = folio_get_private(folio);
|
|
ASSERT(atomic_read(&bfs->eb_refs));
|
|
atomic_dec(&bfs->eb_refs);
|
|
}
|
|
|
|
static void btrfs_subpage_assert(const struct btrfs_fs_info *fs_info,
|
|
struct folio *folio, u64 start, u32 len)
|
|
{
|
|
/* Basic checks */
|
|
ASSERT(folio_test_private(folio) && folio_get_private(folio));
|
|
ASSERT(IS_ALIGNED(start, fs_info->sectorsize) &&
|
|
IS_ALIGNED(len, fs_info->sectorsize), "start=%llu len=%u", start, len);
|
|
/*
|
|
* The range check only works for mapped page, we can still have
|
|
* unmapped page like dummy extent buffer pages.
|
|
*/
|
|
if (folio->mapping)
|
|
ASSERT(folio_pos(folio) <= start &&
|
|
start + len <= folio_next_pos(folio),
|
|
"start=%llu len=%u folio_pos=%llu folio_size=%zu",
|
|
start, len, folio_pos(folio), folio_size(folio));
|
|
}
|
|
|
|
#define subpage_calc_start_bit(fs_info, folio, name, start, len) \
|
|
({ \
|
|
unsigned int __start_bit; \
|
|
const unsigned int __bpf = btrfs_blocks_per_folio(fs_info, folio); \
|
|
\
|
|
btrfs_subpage_assert(fs_info, folio, start, len); \
|
|
__start_bit = offset_in_folio(folio, start) >> fs_info->sectorsize_bits; \
|
|
__start_bit += __bpf * btrfs_bitmap_nr_##name; \
|
|
__start_bit; \
|
|
})
|
|
|
|
static void btrfs_subpage_clamp_range(struct folio *folio, u64 *start, u32 *len)
|
|
{
|
|
u64 orig_start = *start;
|
|
u32 orig_len = *len;
|
|
|
|
*start = max_t(u64, folio_pos(folio), orig_start);
|
|
/*
|
|
* For certain call sites like btrfs_drop_pages(), we may have pages
|
|
* beyond the target range. In that case, just set @len to 0, subpage
|
|
* helpers can handle @len == 0 without any problem.
|
|
*/
|
|
if (folio_pos(folio) >= orig_start + orig_len)
|
|
*len = 0;
|
|
else
|
|
*len = min_t(u64, folio_next_pos(folio), orig_start + orig_len) - *start;
|
|
}
|
|
|
|
static bool btrfs_subpage_end_and_test_lock(const struct btrfs_fs_info *fs_info,
|
|
struct folio *folio, u64 start, u32 len)
|
|
{
|
|
struct btrfs_folio_state *bfs = folio_get_private(folio);
|
|
const int nbits = (len >> fs_info->sectorsize_bits);
|
|
unsigned long flags;
|
|
bool last;
|
|
|
|
btrfs_subpage_assert(fs_info, folio, start, len);
|
|
|
|
spin_lock_irqsave(&bfs->lock, flags);
|
|
/*
|
|
* We have call sites passing @lock_page into
|
|
* extent_clear_unlock_delalloc() for compression path.
|
|
*
|
|
* This @locked_page is locked by plain lock_page(), thus its
|
|
* subpage::locked is 0. Handle them in a special way.
|
|
*/
|
|
if (atomic_read(&bfs->nr_locked) == 0) {
|
|
spin_unlock_irqrestore(&bfs->lock, flags);
|
|
return true;
|
|
}
|
|
ASSERT(atomic_read(&bfs->nr_locked) >= nbits,
|
|
"atomic_read(&bfs->nr_locked)=%d nbits=%d",
|
|
atomic_read(&bfs->nr_locked), nbits);
|
|
last = atomic_sub_and_test(nbits, &bfs->nr_locked);
|
|
spin_unlock_irqrestore(&bfs->lock, flags);
|
|
return last;
|
|
}
|
|
|
|
/*
|
|
* Handle different locked folios:
|
|
*
|
|
* - Non-subpage folio
|
|
* Just unlock it.
|
|
*
|
|
* - folio locked but without any subpage locked
|
|
* This happens either before writepage_delalloc() or the delalloc range is
|
|
* already handled by previous folio.
|
|
* We can simple unlock it.
|
|
*
|
|
* - folio locked with subpage range locked.
|
|
* We go through the locked sectors inside the range and clear their locked
|
|
* bitmap, reduce the writer lock number, and unlock the page if that's
|
|
* the last locked range.
|
|
*/
|
|
void btrfs_folio_end_lock(const struct btrfs_fs_info *fs_info,
|
|
struct folio *folio, u64 start, u32 len)
|
|
{
|
|
struct btrfs_folio_state *bfs = folio_get_private(folio);
|
|
|
|
ASSERT(folio_test_locked(folio));
|
|
|
|
if (unlikely(!fs_info) || !btrfs_is_subpage(fs_info, folio)) {
|
|
folio_unlock(folio);
|
|
return;
|
|
}
|
|
|
|
/*
|
|
* For subpage case, there are two types of locked page. With or
|
|
* without locked number.
|
|
*
|
|
* Since we own the page lock, no one else could touch subpage::locked
|
|
* and we are safe to do several atomic operations without spinlock.
|
|
*/
|
|
if (atomic_read(&bfs->nr_locked) == 0) {
|
|
/* No subpage lock, locked by plain lock_page(). */
|
|
folio_unlock(folio);
|
|
return;
|
|
}
|
|
|
|
btrfs_subpage_clamp_range(folio, &start, &len);
|
|
if (btrfs_subpage_end_and_test_lock(fs_info, folio, start, len))
|
|
folio_unlock(folio);
|
|
}
|
|
|
|
void btrfs_folio_end_lock_bitmap(const struct btrfs_fs_info *fs_info,
|
|
struct folio *folio, unsigned long *bitmap)
|
|
{
|
|
struct btrfs_folio_state *bfs = folio_get_private(folio);
|
|
const unsigned int blocks_per_folio = btrfs_blocks_per_folio(fs_info, folio);
|
|
const unsigned int nbits = bitmap_weight(bitmap, blocks_per_folio);
|
|
unsigned long flags;
|
|
bool last = false;
|
|
|
|
if (!btrfs_is_subpage(fs_info, folio)) {
|
|
folio_unlock(folio);
|
|
return;
|
|
}
|
|
|
|
if (atomic_read(&bfs->nr_locked) == 0) {
|
|
/* No subpage lock, locked by plain lock_page(). */
|
|
folio_unlock(folio);
|
|
return;
|
|
}
|
|
|
|
spin_lock_irqsave(&bfs->lock, flags);
|
|
ASSERT(atomic_read(&bfs->nr_locked) >= nbits,
|
|
"atomic_read(&bfs->nr_locked)=%d nbits=%d",
|
|
atomic_read(&bfs->nr_locked), nbits);
|
|
last = atomic_sub_and_test(nbits, &bfs->nr_locked);
|
|
spin_unlock_irqrestore(&bfs->lock, flags);
|
|
if (last)
|
|
folio_unlock(folio);
|
|
}
|
|
|
|
#define subpage_test_bitmap_all_set(fs_info, folio, name) \
|
|
({ \
|
|
struct btrfs_folio_state *__bfs = folio_get_private(folio); \
|
|
const unsigned int __bpf = btrfs_blocks_per_folio(fs_info, folio); \
|
|
\
|
|
bitmap_test_range_all_set(__bfs->bitmaps, \
|
|
__bpf * btrfs_bitmap_nr_##name, __bpf); \
|
|
})
|
|
|
|
#define subpage_test_bitmap_all_zero(fs_info, folio, name) \
|
|
({ \
|
|
struct btrfs_folio_state *__bfs = folio_get_private(folio); \
|
|
const unsigned int __bpf = btrfs_blocks_per_folio(fs_info, folio); \
|
|
\
|
|
bitmap_test_range_all_zero(__bfs->bitmaps, \
|
|
__bpf * btrfs_bitmap_nr_##name, __bpf); \
|
|
})
|
|
|
|
void btrfs_subpage_set_uptodate(const struct btrfs_fs_info *fs_info,
|
|
struct folio *folio, u64 start, u32 len)
|
|
{
|
|
struct btrfs_folio_state *bfs = folio_get_private(folio);
|
|
unsigned int start_bit = subpage_calc_start_bit(fs_info, folio,
|
|
uptodate, start, len);
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&bfs->lock, flags);
|
|
bitmap_set(bfs->bitmaps, start_bit, len >> fs_info->sectorsize_bits);
|
|
if (subpage_test_bitmap_all_set(fs_info, folio, uptodate))
|
|
folio_mark_uptodate(folio);
|
|
spin_unlock_irqrestore(&bfs->lock, flags);
|
|
}
|
|
|
|
void btrfs_subpage_clear_uptodate(const struct btrfs_fs_info *fs_info,
|
|
struct folio *folio, u64 start, u32 len)
|
|
{
|
|
struct btrfs_folio_state *bfs = folio_get_private(folio);
|
|
unsigned int start_bit = subpage_calc_start_bit(fs_info, folio,
|
|
uptodate, start, len);
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&bfs->lock, flags);
|
|
bitmap_clear(bfs->bitmaps, start_bit, len >> fs_info->sectorsize_bits);
|
|
folio_clear_uptodate(folio);
|
|
spin_unlock_irqrestore(&bfs->lock, flags);
|
|
}
|
|
|
|
void btrfs_subpage_set_dirty(const struct btrfs_fs_info *fs_info,
|
|
struct folio *folio, u64 start, u32 len)
|
|
{
|
|
struct btrfs_folio_state *bfs = folio_get_private(folio);
|
|
unsigned int start_bit = subpage_calc_start_bit(fs_info, folio,
|
|
dirty, start, len);
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&bfs->lock, flags);
|
|
bitmap_set(bfs->bitmaps, start_bit, len >> fs_info->sectorsize_bits);
|
|
spin_unlock_irqrestore(&bfs->lock, flags);
|
|
folio_mark_dirty(folio);
|
|
}
|
|
|
|
static void folio_clear_tags(struct folio *folio)
|
|
{
|
|
struct address_space *mapping = folio_mapping(folio);
|
|
XA_STATE(xas, &mapping->i_pages, folio->index);
|
|
unsigned long flags;
|
|
|
|
ASSERT(folio_test_locked(folio));
|
|
ASSERT(mapping);
|
|
ASSERT(mapping_use_writeback_tags(mapping));
|
|
|
|
xas_lock_irqsave(&xas, flags);
|
|
xas_load(&xas);
|
|
xas_clear_mark(&xas, PAGECACHE_TAG_DIRTY);
|
|
xas_clear_mark(&xas, PAGECACHE_TAG_TOWRITE);
|
|
xas_unlock_irqrestore(&xas, flags);
|
|
}
|
|
|
|
/*
|
|
* Extra clear_and_test function for subpage dirty bitmap.
|
|
*
|
|
* Return true if we're the last bits in the dirty_bitmap and clear the
|
|
* dirty_bitmap.
|
|
* Return false otherwise.
|
|
*
|
|
* NOTE: Callers should manually clear page dirty for true case, as we have
|
|
* extra handling for tree blocks.
|
|
*/
|
|
bool btrfs_subpage_clear_and_test_dirty(const struct btrfs_fs_info *fs_info,
|
|
struct folio *folio, u64 start, u32 len)
|
|
{
|
|
struct btrfs_folio_state *bfs = folio_get_private(folio);
|
|
unsigned int start_bit = subpage_calc_start_bit(fs_info, folio,
|
|
dirty, start, len);
|
|
unsigned long flags;
|
|
bool last = false;
|
|
|
|
spin_lock_irqsave(&bfs->lock, flags);
|
|
bitmap_clear(bfs->bitmaps, start_bit, len >> fs_info->sectorsize_bits);
|
|
if (subpage_test_bitmap_all_zero(fs_info, folio, dirty))
|
|
last = true;
|
|
spin_unlock_irqrestore(&bfs->lock, flags);
|
|
return last;
|
|
}
|
|
|
|
void btrfs_subpage_clear_dirty(const struct btrfs_fs_info *fs_info,
|
|
struct folio *folio, u64 start, u32 len)
|
|
{
|
|
bool last;
|
|
|
|
last = btrfs_subpage_clear_and_test_dirty(fs_info, folio, start, len);
|
|
if (last)
|
|
folio_clear_dirty_for_io(folio);
|
|
}
|
|
|
|
void btrfs_subpage_set_writeback(const struct btrfs_fs_info *fs_info,
|
|
struct folio *folio, u64 start, u32 len)
|
|
{
|
|
struct btrfs_folio_state *bfs = folio_get_private(folio);
|
|
unsigned int start_bit = subpage_calc_start_bit(fs_info, folio,
|
|
writeback, start, len);
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&bfs->lock, flags);
|
|
bitmap_set(bfs->bitmaps, start_bit, len >> fs_info->sectorsize_bits);
|
|
|
|
/*
|
|
* Don't clear the TOWRITE tag when starting writeback on a still-dirty
|
|
* folio. Doing so can cause WB_SYNC_ALL writepages() to overlook it,
|
|
* assume writeback is complete, and exit too early — violating sync
|
|
* ordering guarantees.
|
|
*
|
|
* Instead we manually clear the DIRTY and TOWRITE tags after the folio
|
|
* is no longer dirty.
|
|
*/
|
|
if (!folio_test_writeback(folio))
|
|
__folio_start_writeback(folio, true);
|
|
if (!folio_test_dirty(folio))
|
|
folio_clear_tags(folio);
|
|
spin_unlock_irqrestore(&bfs->lock, flags);
|
|
}
|
|
|
|
void btrfs_subpage_clear_writeback(const struct btrfs_fs_info *fs_info,
|
|
struct folio *folio, u64 start, u32 len)
|
|
{
|
|
struct btrfs_folio_state *bfs = folio_get_private(folio);
|
|
unsigned int start_bit = subpage_calc_start_bit(fs_info, folio,
|
|
writeback, start, len);
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&bfs->lock, flags);
|
|
bitmap_clear(bfs->bitmaps, start_bit, len >> fs_info->sectorsize_bits);
|
|
if (subpage_test_bitmap_all_zero(fs_info, folio, writeback)) {
|
|
ASSERT(folio_test_writeback(folio));
|
|
folio_end_writeback(folio);
|
|
}
|
|
spin_unlock_irqrestore(&bfs->lock, flags);
|
|
}
|
|
|
|
/*
|
|
* Unlike set/clear which is dependent on each page status, for test all bits
|
|
* are tested in the same way.
|
|
*/
|
|
#define IMPLEMENT_BTRFS_SUBPAGE_TEST_OP(name) \
|
|
bool btrfs_subpage_test_##name(const struct btrfs_fs_info *fs_info, \
|
|
struct folio *folio, u64 start, u32 len) \
|
|
{ \
|
|
struct btrfs_folio_state *bfs = folio_get_private(folio); \
|
|
unsigned int start_bit = subpage_calc_start_bit(fs_info, folio, \
|
|
name, start, len); \
|
|
unsigned long flags; \
|
|
bool ret; \
|
|
\
|
|
spin_lock_irqsave(&bfs->lock, flags); \
|
|
ret = bitmap_test_range_all_set(bfs->bitmaps, start_bit, \
|
|
len >> fs_info->sectorsize_bits); \
|
|
spin_unlock_irqrestore(&bfs->lock, flags); \
|
|
return ret; \
|
|
}
|
|
IMPLEMENT_BTRFS_SUBPAGE_TEST_OP(uptodate);
|
|
IMPLEMENT_BTRFS_SUBPAGE_TEST_OP(dirty);
|
|
IMPLEMENT_BTRFS_SUBPAGE_TEST_OP(writeback);
|
|
|
|
/*
|
|
* Note that, in selftests (extent-io-tests), we can have empty fs_info passed
|
|
* in. We only test sectorsize == PAGE_SIZE cases so far, thus we can fall
|
|
* back to regular sectorsize branch.
|
|
*/
|
|
#define IMPLEMENT_BTRFS_PAGE_OPS(name, folio_set_func, \
|
|
folio_clear_func, folio_test_func) \
|
|
void btrfs_folio_set_##name(const struct btrfs_fs_info *fs_info, \
|
|
struct folio *folio, u64 start, u32 len) \
|
|
{ \
|
|
if (unlikely(!fs_info) || \
|
|
!btrfs_is_subpage(fs_info, folio)) { \
|
|
folio_set_func(folio); \
|
|
return; \
|
|
} \
|
|
btrfs_subpage_set_##name(fs_info, folio, start, len); \
|
|
} \
|
|
void btrfs_folio_clear_##name(const struct btrfs_fs_info *fs_info, \
|
|
struct folio *folio, u64 start, u32 len) \
|
|
{ \
|
|
if (unlikely(!fs_info) || \
|
|
!btrfs_is_subpage(fs_info, folio)) { \
|
|
folio_clear_func(folio); \
|
|
return; \
|
|
} \
|
|
btrfs_subpage_clear_##name(fs_info, folio, start, len); \
|
|
} \
|
|
bool btrfs_folio_test_##name(const struct btrfs_fs_info *fs_info, \
|
|
struct folio *folio, u64 start, u32 len) \
|
|
{ \
|
|
if (unlikely(!fs_info) || \
|
|
!btrfs_is_subpage(fs_info, folio)) \
|
|
return folio_test_func(folio); \
|
|
return btrfs_subpage_test_##name(fs_info, folio, start, len); \
|
|
} \
|
|
void btrfs_folio_clamp_set_##name(const struct btrfs_fs_info *fs_info, \
|
|
struct folio *folio, u64 start, u32 len) \
|
|
{ \
|
|
if (unlikely(!fs_info) || \
|
|
!btrfs_is_subpage(fs_info, folio)) { \
|
|
folio_set_func(folio); \
|
|
return; \
|
|
} \
|
|
btrfs_subpage_clamp_range(folio, &start, &len); \
|
|
btrfs_subpage_set_##name(fs_info, folio, start, len); \
|
|
} \
|
|
void btrfs_folio_clamp_clear_##name(const struct btrfs_fs_info *fs_info, \
|
|
struct folio *folio, u64 start, u32 len) \
|
|
{ \
|
|
if (unlikely(!fs_info) || \
|
|
!btrfs_is_subpage(fs_info, folio)) { \
|
|
folio_clear_func(folio); \
|
|
return; \
|
|
} \
|
|
btrfs_subpage_clamp_range(folio, &start, &len); \
|
|
btrfs_subpage_clear_##name(fs_info, folio, start, len); \
|
|
} \
|
|
bool btrfs_folio_clamp_test_##name(const struct btrfs_fs_info *fs_info, \
|
|
struct folio *folio, u64 start, u32 len) \
|
|
{ \
|
|
if (unlikely(!fs_info) || \
|
|
!btrfs_is_subpage(fs_info, folio)) \
|
|
return folio_test_func(folio); \
|
|
btrfs_subpage_clamp_range(folio, &start, &len); \
|
|
return btrfs_subpage_test_##name(fs_info, folio, start, len); \
|
|
} \
|
|
void btrfs_meta_folio_set_##name(struct folio *folio, const struct extent_buffer *eb) \
|
|
{ \
|
|
if (!btrfs_meta_is_subpage(eb->fs_info)) { \
|
|
folio_set_func(folio); \
|
|
return; \
|
|
} \
|
|
btrfs_subpage_set_##name(eb->fs_info, folio, eb->start, eb->len); \
|
|
} \
|
|
void btrfs_meta_folio_clear_##name(struct folio *folio, const struct extent_buffer *eb) \
|
|
{ \
|
|
if (!btrfs_meta_is_subpage(eb->fs_info)) { \
|
|
folio_clear_func(folio); \
|
|
return; \
|
|
} \
|
|
btrfs_subpage_clear_##name(eb->fs_info, folio, eb->start, eb->len); \
|
|
} \
|
|
bool btrfs_meta_folio_test_##name(struct folio *folio, const struct extent_buffer *eb) \
|
|
{ \
|
|
if (!btrfs_meta_is_subpage(eb->fs_info)) \
|
|
return folio_test_func(folio); \
|
|
return btrfs_subpage_test_##name(eb->fs_info, folio, eb->start, eb->len); \
|
|
}
|
|
IMPLEMENT_BTRFS_PAGE_OPS(uptodate, folio_mark_uptodate, folio_clear_uptodate,
|
|
folio_test_uptodate);
|
|
IMPLEMENT_BTRFS_PAGE_OPS(dirty, folio_mark_dirty, folio_clear_dirty_for_io,
|
|
folio_test_dirty);
|
|
IMPLEMENT_BTRFS_PAGE_OPS(writeback, folio_start_writeback, folio_end_writeback,
|
|
folio_test_writeback);
|
|
|
|
#define DEFINE_GET_SUBPAGE_BITMAP(name) \
|
|
static inline unsigned long get_bitmap_value_##name( \
|
|
const struct btrfs_fs_info *fs_info, \
|
|
struct folio *folio) \
|
|
{ \
|
|
const unsigned int __bpf = btrfs_blocks_per_folio(fs_info, folio); \
|
|
const struct btrfs_folio_state *__bfs = folio_get_private(folio); \
|
|
unsigned long value; \
|
|
\
|
|
ASSERT(__bpf <= BITS_PER_LONG); \
|
|
value = bitmap_read(__bfs->bitmaps, __bpf * btrfs_bitmap_nr_##name, \
|
|
__bpf); \
|
|
return value; \
|
|
} \
|
|
static inline const unsigned long *get_bitmap_pointer_##name( \
|
|
const struct btrfs_fs_info *fs_info, \
|
|
struct folio *folio) \
|
|
{ \
|
|
const unsigned int __bpf = btrfs_blocks_per_folio(fs_info, folio); \
|
|
struct btrfs_folio_state *__bfs = folio_get_private(folio); \
|
|
unsigned long *pointer; \
|
|
\
|
|
ASSERT(__bpf >= BITS_PER_LONG); \
|
|
ASSERT(IS_ALIGNED(__bpf, BITS_PER_LONG)); \
|
|
pointer = __bfs->bitmaps + (BIT_WORD(__bpf) * btrfs_bitmap_nr_##name); \
|
|
return pointer; \
|
|
}
|
|
|
|
DEFINE_GET_SUBPAGE_BITMAP(uptodate);
|
|
DEFINE_GET_SUBPAGE_BITMAP(dirty);
|
|
DEFINE_GET_SUBPAGE_BITMAP(writeback);
|
|
|
|
#define SUBPAGE_DUMP_BITMAP(fs_info, folio, name, start, len) \
|
|
{ \
|
|
const unsigned int __bpf = btrfs_blocks_per_folio(fs_info, folio); \
|
|
\
|
|
if (__bpf <= BITS_PER_LONG) { \
|
|
unsigned long bitmap = get_bitmap_value_##name(fs_info, folio); \
|
|
\
|
|
btrfs_warn(fs_info, \
|
|
"dumping bitmap start=%llu len=%u folio=%llu " #name "_bitmap=%*pbl", \
|
|
start, len, folio_pos(folio), __bpf, &bitmap); \
|
|
} else { \
|
|
btrfs_warn(fs_info, \
|
|
"dumping bitmap start=%llu len=%u folio=%llu " #name "_bitmap=%*pbl", \
|
|
start, len, folio_pos(folio), __bpf, \
|
|
get_bitmap_pointer_##name(fs_info, folio)); \
|
|
} \
|
|
}
|
|
|
|
/*
|
|
* Make sure not only the page dirty bit is cleared, but also subpage dirty bit
|
|
* is cleared.
|
|
*/
|
|
void btrfs_folio_assert_not_dirty(const struct btrfs_fs_info *fs_info,
|
|
struct folio *folio, u64 start, u32 len)
|
|
{
|
|
struct btrfs_folio_state *bfs;
|
|
unsigned int start_bit;
|
|
unsigned int nbits;
|
|
unsigned long flags;
|
|
|
|
if (!IS_ENABLED(CONFIG_BTRFS_ASSERT))
|
|
return;
|
|
|
|
if (!btrfs_is_subpage(fs_info, folio)) {
|
|
ASSERT(!folio_test_dirty(folio));
|
|
return;
|
|
}
|
|
|
|
start_bit = subpage_calc_start_bit(fs_info, folio, dirty, start, len);
|
|
nbits = len >> fs_info->sectorsize_bits;
|
|
bfs = folio_get_private(folio);
|
|
ASSERT(bfs);
|
|
spin_lock_irqsave(&bfs->lock, flags);
|
|
if (unlikely(!bitmap_test_range_all_zero(bfs->bitmaps, start_bit, nbits))) {
|
|
SUBPAGE_DUMP_BITMAP(fs_info, folio, dirty, start, len);
|
|
ASSERT(bitmap_test_range_all_zero(bfs->bitmaps, start_bit, nbits));
|
|
}
|
|
ASSERT(bitmap_test_range_all_zero(bfs->bitmaps, start_bit, nbits));
|
|
spin_unlock_irqrestore(&bfs->lock, flags);
|
|
}
|
|
|
|
/*
|
|
* This is for folio already locked by plain lock_page()/folio_lock(), which
|
|
* doesn't have any subpage awareness.
|
|
*
|
|
* This populates the involved subpage ranges so that subpage helpers can
|
|
* properly unlock them.
|
|
*/
|
|
void btrfs_folio_set_lock(const struct btrfs_fs_info *fs_info,
|
|
struct folio *folio, u64 start, u32 len)
|
|
{
|
|
struct btrfs_folio_state *bfs;
|
|
unsigned long flags;
|
|
unsigned int nbits;
|
|
int ret;
|
|
|
|
ASSERT(folio_test_locked(folio));
|
|
if (unlikely(!fs_info) || !btrfs_is_subpage(fs_info, folio))
|
|
return;
|
|
|
|
bfs = folio_get_private(folio);
|
|
nbits = len >> fs_info->sectorsize_bits;
|
|
spin_lock_irqsave(&bfs->lock, flags);
|
|
ret = atomic_add_return(nbits, &bfs->nr_locked);
|
|
ASSERT(ret <= btrfs_blocks_per_folio(fs_info, folio));
|
|
spin_unlock_irqrestore(&bfs->lock, flags);
|
|
}
|
|
|
|
/*
|
|
* Clear the dirty flag for the folio.
|
|
*
|
|
* If the affected folio is no longer dirty, return true. Otherwise return false.
|
|
*/
|
|
bool btrfs_meta_folio_clear_and_test_dirty(struct folio *folio, const struct extent_buffer *eb)
|
|
{
|
|
bool last;
|
|
|
|
if (!btrfs_meta_is_subpage(eb->fs_info)) {
|
|
folio_clear_dirty_for_io(folio);
|
|
return true;
|
|
}
|
|
|
|
last = btrfs_subpage_clear_and_test_dirty(eb->fs_info, folio, eb->start, eb->len);
|
|
if (last) {
|
|
folio_clear_dirty_for_io(folio);
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
void __cold btrfs_subpage_dump_bitmap(const struct btrfs_fs_info *fs_info,
|
|
struct folio *folio, u64 start, u32 len)
|
|
{
|
|
struct btrfs_folio_state *bfs;
|
|
const unsigned int blocks_per_folio = btrfs_blocks_per_folio(fs_info, folio);
|
|
unsigned long flags;
|
|
|
|
ASSERT(folio_test_private(folio) && folio_get_private(folio));
|
|
ASSERT(blocks_per_folio > 1);
|
|
bfs = folio_get_private(folio);
|
|
|
|
dump_page(folio_page(folio, 0), "btrfs folio state dump");
|
|
|
|
if (blocks_per_folio <= BITS_PER_LONG) {
|
|
unsigned long uptodate;
|
|
unsigned long dirty;
|
|
unsigned long writeback;
|
|
|
|
spin_lock_irqsave(&bfs->lock, flags);
|
|
uptodate = get_bitmap_value_uptodate(fs_info, folio);
|
|
dirty = get_bitmap_value_dirty(fs_info, folio);
|
|
writeback = get_bitmap_value_writeback(fs_info, folio);
|
|
|
|
spin_unlock_irqrestore(&bfs->lock, flags);
|
|
|
|
btrfs_warn(fs_info,
|
|
"start=%llu len=%u page=%llu, bitmaps uptodate=%*pbl dirty=%*pbl writeback=%*pbl",
|
|
start, len, folio_pos(folio),
|
|
blocks_per_folio, &uptodate,
|
|
blocks_per_folio, &dirty,
|
|
blocks_per_folio, &writeback);
|
|
return;
|
|
}
|
|
|
|
spin_lock_irqsave(&bfs->lock, flags);
|
|
btrfs_warn(fs_info,
|
|
"start=%llu len=%u page=%llu, bitmaps uptodate=%*pbl dirty=%*pbl writeback=%*pbl",
|
|
start, len, folio_pos(folio),
|
|
blocks_per_folio, get_bitmap_pointer_uptodate(fs_info, folio),
|
|
blocks_per_folio, get_bitmap_pointer_dirty(fs_info, folio),
|
|
blocks_per_folio, get_bitmap_pointer_writeback(fs_info, folio));
|
|
spin_unlock_irqrestore(&bfs->lock, flags);
|
|
}
|
|
|
|
void btrfs_copy_subpage_dirty_bitmap(struct btrfs_fs_info *fs_info,
|
|
struct folio *folio,
|
|
unsigned long *dst)
|
|
{
|
|
struct btrfs_folio_state *bfs;
|
|
const unsigned int blocks_per_folio = btrfs_blocks_per_folio(fs_info, folio);
|
|
unsigned long flags;
|
|
unsigned long value;
|
|
|
|
if (blocks_per_folio == 1) {
|
|
value = 1;
|
|
bitmap_copy(dst, &value, 1);
|
|
return;
|
|
}
|
|
|
|
ASSERT(folio_test_private(folio) && folio_get_private(folio));
|
|
ASSERT(blocks_per_folio > 1);
|
|
bfs = folio_get_private(folio);
|
|
|
|
if (blocks_per_folio <= BITS_PER_LONG) {
|
|
spin_lock_irqsave(&bfs->lock, flags);
|
|
value = bitmap_read(bfs->bitmaps, btrfs_bitmap_nr_dirty * blocks_per_folio,
|
|
blocks_per_folio);
|
|
spin_unlock_irqrestore(&bfs->lock, flags);
|
|
bitmap_copy(dst, &value, blocks_per_folio);
|
|
return;
|
|
}
|
|
spin_lock_irqsave(&bfs->lock, flags);
|
|
bitmap_copy(dst, get_bitmap_pointer_dirty(fs_info, folio),
|
|
blocks_per_folio);
|
|
spin_unlock_irqrestore(&bfs->lock, flags);
|
|
}
|