mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-08-09 06:14:34 +02:00
Sven Eckelmann
8669a550c7
When an mesh interface is registered, it creates an untagged struct
batadv_meshif_vlan on top of it via the NETDEV_REGISTER notifier. But in
this process, another receiver of this notification can veto the
registration. The netdev registration will be aborted because of this veto.
The register_netdevice() call will try to clean up the net_device using
unregister_netdevice_queue() - which only uses the .priv_destructor to
free private resources. In this situation, .dellink will not be called.
The cleanup of the untagged batadv_meshif_vlan must thefore be done in the
destructor to avoid a leak of this object.
Cc: stable@vger.kernel.org
Fixes: 5d2c05b213 ("batman-adv: add per VLAN interface attribute framework")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
44 lines
1.3 KiB
C
44 lines
1.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/* Copyright (C) B.A.T.M.A.N. contributors:
|
|
*
|
|
* Marek Lindner
|
|
*/
|
|
|
|
#ifndef _NET_BATMAN_ADV_MESH_INTERFACE_H_
|
|
#define _NET_BATMAN_ADV_MESH_INTERFACE_H_
|
|
|
|
#include "main.h"
|
|
|
|
#include <linux/kref.h>
|
|
#include <linux/netdevice.h>
|
|
#include <linux/skbuff.h>
|
|
#include <linux/types.h>
|
|
|
|
int batadv_skb_head_push(struct sk_buff *skb, unsigned int len);
|
|
void batadv_interface_rx(struct net_device *mesh_iface,
|
|
struct sk_buff *skb, int hdr_size,
|
|
struct batadv_orig_node *orig_node);
|
|
bool batadv_meshif_is_valid(const struct net_device *net_dev);
|
|
extern struct rtnl_link_ops batadv_link_ops;
|
|
int batadv_meshif_create_vlan(struct batadv_priv *bat_priv, unsigned short vid);
|
|
void batadv_meshif_destroy_vlan(struct batadv_priv *bat_priv,
|
|
struct batadv_meshif_vlan *vlan);
|
|
void batadv_meshif_vlan_release(struct kref *ref);
|
|
struct batadv_meshif_vlan *batadv_meshif_vlan_get(struct batadv_priv *bat_priv,
|
|
unsigned short vid);
|
|
|
|
/**
|
|
* batadv_meshif_vlan_put() - decrease the vlan object refcounter and
|
|
* possibly release it
|
|
* @vlan: the vlan object to release
|
|
*/
|
|
static inline void batadv_meshif_vlan_put(struct batadv_meshif_vlan *vlan)
|
|
{
|
|
if (!vlan)
|
|
return;
|
|
|
|
kref_put(&vlan->refcount, batadv_meshif_vlan_release);
|
|
}
|
|
|
|
#endif /* _NET_BATMAN_ADV_MESH_INTERFACE_H_ */
|