mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-08-09 06:14:34 +02:00
Ian RogersandArnaldo Carvalho de Melo
165daffc7c
Code in tools/perf/arch causes portability issues/opaqueness and LTO issues due to the use of weak symbols. Move the adding of LR to the sample_user_regs into arm64-frame-pointer-unwind-support.c conditional on EM_HOST == EM_AARCH64 (false on all non-ARM64 builds). This also better encapsulates the use of the sampled registers by get_leaf_frame_caller_aarch64 and the set up by the new add_leaf_frame_caller_opts_aarch64, exposing opportunities for possibly sampling PC and SP to help the unwinder. Reviewed-by: James Clark <james.clark@linaro.org> Signed-off-by: Ian Rogers <irogers@google.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Dapeng Mi <dapeng1.mi@linux.intel.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: John Garry <john.g.garry@oracle.com> Cc: Leo Yan <leo.yan@linux.dev> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Mike Leach <mike.leach@arm.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Shimin Guo <shimin.guo@skydio.com> Cc: Will Deacon <will@kernel.org> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
78 lines
2.0 KiB
C
78 lines
2.0 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include "arm64-frame-pointer-unwind-support.h"
|
|
#include "callchain.h"
|
|
#include "event.h"
|
|
#include "record.h"
|
|
#include "unwind.h"
|
|
#include <string.h>
|
|
|
|
#define perf_event_arm_regs perf_event_arm64_regs
|
|
#include "../../arch/arm64/include/uapi/asm/perf_regs.h"
|
|
#undef perf_event_arm_regs
|
|
|
|
struct entries {
|
|
u64 stack[2];
|
|
size_t length;
|
|
};
|
|
|
|
#define SMPL_REG_MASK(b) (1ULL << (b))
|
|
|
|
void add_leaf_frame_caller_opts_aarch64(struct record_opts *opts)
|
|
{
|
|
opts->sample_user_regs |= SMPL_REG_MASK(PERF_REG_ARM64_LR);
|
|
}
|
|
|
|
static bool get_leaf_frame_caller_enabled(struct perf_sample *sample)
|
|
{
|
|
struct regs_dump *regs;
|
|
|
|
if (callchain_param.record_mode != CALLCHAIN_FP)
|
|
return false;
|
|
|
|
regs = perf_sample__user_regs(sample);
|
|
return regs->regs && regs->mask & SMPL_REG_MASK(PERF_REG_ARM64_LR);
|
|
}
|
|
|
|
static int add_entry(struct unwind_entry *entry, void *arg)
|
|
{
|
|
struct entries *entries = arg;
|
|
|
|
entries->stack[entries->length++] = entry->ip;
|
|
return 0;
|
|
}
|
|
|
|
u64 get_leaf_frame_caller_aarch64(struct perf_sample *sample, struct thread *thread, int usr_idx)
|
|
{
|
|
int ret;
|
|
struct entries entries = {};
|
|
struct regs_dump old_regs, *regs;
|
|
|
|
if (!get_leaf_frame_caller_enabled(sample))
|
|
return 0;
|
|
|
|
/*
|
|
* If PC and SP are not recorded, get the value of PC from the stack
|
|
* and set its mask. SP is not used when doing the unwinding but it
|
|
* still needs to be set to prevent failures.
|
|
*/
|
|
regs = perf_sample__user_regs(sample);
|
|
memcpy(&old_regs, regs, sizeof(*regs));
|
|
if (!(regs->mask & SMPL_REG_MASK(PERF_REG_ARM64_PC))) {
|
|
regs->cache_mask |= SMPL_REG_MASK(PERF_REG_ARM64_PC);
|
|
regs->cache_regs[PERF_REG_ARM64_PC] = sample->callchain->ips[usr_idx+1];
|
|
}
|
|
|
|
if (!(regs->mask & SMPL_REG_MASK(PERF_REG_ARM64_SP))) {
|
|
regs->cache_mask |= SMPL_REG_MASK(PERF_REG_ARM64_SP);
|
|
regs->cache_regs[PERF_REG_ARM64_SP] = 0;
|
|
}
|
|
|
|
ret = unwind__get_entries(add_entry, &entries, thread, sample, 2, true);
|
|
memcpy(regs, &old_regs, sizeof(*regs));
|
|
|
|
if (ret || entries.length != 2)
|
|
return ret;
|
|
|
|
return callchain_param.order == ORDER_CALLER ? entries.stack[0] : entries.stack[1];
|
|
}
|