mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-08-14 06:22:34 +02:00
Cao Ruichuang
808c447df2
test_ownership.tc is sourced by ftracetest under /bin/sh.
The script currently declares mount_point with local at file scope,
which makes /bin/sh abort with "local: not in a function" before the
test can reach the eventfs ownership checks.
Replace the top-level local declaration with a normal shell variable so
kernels that support the gid= tracefs mount option can run the test at
all.
Link: https://lore.kernel.org/r/20260407102613.81419-1-create0818@163.com
Fixes: 8b55572e51 ("tracing/selftests: Add tracefs mount options test")
Signed-off-by: Cao Ruichuang <create0818@163.com>
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
123 lines
2.9 KiB
Bash
123 lines
2.9 KiB
Bash
#!/bin/sh
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
# description: Test file and directory ownership changes for eventfs
|
|
# requires: "[gid=<gid>]":README
|
|
|
|
original_group=`stat -c "%g" .`
|
|
original_owner=`stat -c "%u" .`
|
|
|
|
mount_point=$(get_mount_point)
|
|
|
|
mount_options=$(get_mnt_options "$mount_point")
|
|
|
|
# find another owner and group that is not the original
|
|
other_group=`tac /etc/group | grep -v ":$original_group:" | head -1 | cut -d: -f3`
|
|
other_owner=`tac /etc/passwd | grep -v ":$original_owner:" | head -1 | cut -d: -f3`
|
|
|
|
# Remove any group ownership already
|
|
new_options=`echo "$mount_options" | sed -e "s/gid=[0-9]*/gid=$other_group/"`
|
|
|
|
if [ "$new_options" = "$mount_options" ]; then
|
|
new_options="$mount_options,gid=$other_group"
|
|
mount_options="$mount_options,gid=$original_group"
|
|
fi
|
|
|
|
canary="events/timer events/timer/timer_cancel events/timer/timer_cancel/format"
|
|
|
|
test() {
|
|
file=$1
|
|
test_group=$2
|
|
|
|
owner=`stat -c "%u" $file`
|
|
group=`stat -c "%g" $file`
|
|
|
|
echo "testing $file $owner=$original_owner and $group=$test_group"
|
|
if [ $owner -ne $original_owner ]; then
|
|
exit_fail
|
|
fi
|
|
if [ $group -ne $test_group ]; then
|
|
exit_fail
|
|
fi
|
|
|
|
# Note, the remount does not update ownership so test going to and from owner
|
|
echo "test owner $file to $other_owner"
|
|
chown $other_owner $file
|
|
owner=`stat -c "%u" $file`
|
|
if [ $owner -ne $other_owner ]; then
|
|
exit_fail
|
|
fi
|
|
|
|
chown $original_owner $file
|
|
owner=`stat -c "%u" $file`
|
|
if [ $owner -ne $original_owner ]; then
|
|
exit_fail
|
|
fi
|
|
|
|
}
|
|
|
|
run_tests() {
|
|
for d in "." "events" "events/sched" "events/sched/sched_switch" "events/sched/sched_switch/enable" $canary; do
|
|
test "$d" $other_group
|
|
done
|
|
|
|
chgrp $original_group events
|
|
test "events" $original_group
|
|
for d in "." "events/sched" "events/sched/sched_switch" "events/sched/sched_switch/enable" $canary; do
|
|
test "$d" $other_group
|
|
done
|
|
|
|
chgrp $original_group events/sched
|
|
test "events/sched" $original_group
|
|
for d in "." "events/sched/sched_switch" "events/sched/sched_switch/enable" $canary; do
|
|
test "$d" $other_group
|
|
done
|
|
|
|
chgrp $original_group events/sched/sched_switch
|
|
test "events/sched/sched_switch" $original_group
|
|
for d in "." "events/sched/sched_switch/enable" $canary; do
|
|
test "$d" $other_group
|
|
done
|
|
|
|
chgrp $original_group events/sched/sched_switch/enable
|
|
test "events/sched/sched_switch/enable" $original_group
|
|
for d in "." $canary; do
|
|
test "$d" $other_group
|
|
done
|
|
}
|
|
|
|
# Run the tests twice as leftovers can cause issues
|
|
for loop in 1 2 ; do
|
|
|
|
echo "Running iteration $loop"
|
|
|
|
mount -o remount,"$new_options" .
|
|
|
|
run_tests
|
|
|
|
mount -o remount,"$mount_options" .
|
|
|
|
for d in "." "events" "events/sched" "events/sched/sched_switch" "events/sched/sched_switch/enable" $canary; do
|
|
test "$d" $original_group
|
|
done
|
|
|
|
# check instances as well
|
|
|
|
chgrp $other_group instances
|
|
|
|
instance="$(mktemp -u test-XXXXXX)"
|
|
|
|
mkdir instances/$instance
|
|
|
|
cd instances/$instance
|
|
|
|
run_tests
|
|
|
|
cd ../..
|
|
|
|
rmdir instances/$instance
|
|
|
|
chgrp $original_group instances
|
|
done
|
|
|
|
exit 0
|