
Mukesh OjhaandGreg Kroah-Hartman
ddcfc5708d
leds: class: Protect brightness_show() with led_cdev->led_access mutex
[ Upstream commit 4ca7cd9387 ]
There is NULL pointer issue observed if from Process A where hid device
being added which results in adding a led_cdev addition and later a
another call to access of led_cdev attribute from Process B can result
in NULL pointer issue.
Use mutex led_cdev->led_access to protect access to led->cdev and its
attribute inside brightness_show() and max_brightness_show() and also
update the comment for mutex that it should be used to protect the led
class device fields.
Process A Process B
kthread+0x114
worker_thread+0x244
process_scheduled_works+0x248
uhid_device_add_worker+0x24
hid_add_device+0x120
device_add+0x268
bus_probe_device+0x94
device_initial_probe+0x14
__device_attach+0xfc
bus_for_each_drv+0x10c
__device_attach_driver+0x14c
driver_probe_device+0x3c
__driver_probe_device+0xa0
really_probe+0x190
hid_device_probe+0x130
ps_probe+0x990
ps_led_register+0x94
devm_led_classdev_register_ext+0x58
led_classdev_register_ext+0x1f8
device_create_with_groups+0x48
device_create_groups_vargs+0xc8
device_add+0x244
kobject_uevent+0x14
kobject_uevent_env[jt]+0x224
mutex_unlock[jt]+0xc4
__mutex_unlock_slowpath+0xd4
wake_up_q+0x70
try_to_wake_up[jt]+0x48c
preempt_schedule_common+0x28
__schedule+0x628
__switch_to+0x174
el0t_64_sync+0x1a8/0x1ac
el0t_64_sync_handler+0x68/0xbc
el0_svc+0x38/0x68
do_el0_svc+0x1c/0x28
el0_svc_common+0x80/0xe0
invoke_syscall+0x58/0x114
__arm64_sys_read+0x1c/0x2c
ksys_read+0x78/0xe8
vfs_read+0x1e0/0x2c8
kernfs_fop_read_iter+0x68/0x1b4
seq_read_iter+0x158/0x4ec
kernfs_seq_show+0x44/0x54
sysfs_kf_seq_show+0xb4/0x130
dev_attr_show+0x38/0x74
brightness_show+0x20/0x4c
dualshock4_led_get_brightness+0xc/0x74
[ 3313.874295][ T4013] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000060
[ 3313.874301][ T4013] Mem abort info:
[ 3313.874303][ T4013] ESR = 0x0000000096000006
[ 3313.874305][ T4013] EC = 0x25: DABT (current EL), IL = 32 bits
[ 3313.874307][ T4013] SET = 0, FnV = 0
[ 3313.874309][ T4013] EA = 0, S1PTW = 0
[ 3313.874311][ T4013] FSC = 0x06: level 2 translation fault
[ 3313.874313][ T4013] Data abort info:
[ 3313.874314][ T4013] ISV = 0, ISS = 0x00000006, ISS2 = 0x00000000
[ 3313.874316][ T4013] CM = 0, WnR = 0, TnD = 0, TagAccess = 0
[ 3313.874318][ T4013] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
[ 3313.874320][ T4013] user pgtable: 4k pages, 39-bit VAs, pgdp=00000008f2b0a000
..
[ 3313.874332][ T4013] Dumping ftrace buffer:
[ 3313.874334][ T4013] (ftrace buffer empty)
..
..
[ dd3313.874639][ T4013] CPU: 6 PID: 4013 Comm: InputReader
[ 3313.874648][ T4013] pc : dualshock4_led_get_brightness+0xc/0x74
[ 3313.874653][ T4013] lr : led_update_brightness+0x38/0x60
[ 3313.874656][ T4013] sp : ffffffc0b910bbd0
..
..
[ 3313.874685][ T4013] Call trace:
[ 3313.874687][ T4013] dualshock4_led_get_brightness+0xc/0x74
[ 3313.874690][ T4013] brightness_show+0x20/0x4c
[ 3313.874692][ T4013] dev_attr_show+0x38/0x74
[ 3313.874696][ T4013] sysfs_kf_seq_show+0xb4/0x130
[ 3313.874700][ T4013] kernfs_seq_show+0x44/0x54
[ 3313.874703][ T4013] seq_read_iter+0x158/0x4ec
[ 3313.874705][ T4013] kernfs_fop_read_iter+0x68/0x1b4
[ 3313.874708][ T4013] vfs_read+0x1e0/0x2c8
[ 3313.874711][ T4013] ksys_read+0x78/0xe8
[ 3313.874714][ T4013] __arm64_sys_read+0x1c/0x2c
[ 3313.874718][ T4013] invoke_syscall+0x58/0x114
[ 3313.874721][ T4013] el0_svc_common+0x80/0xe0
[ 3313.874724][ T4013] do_el0_svc+0x1c/0x28
[ 3313.874727][ T4013] el0_svc+0x38/0x68
[ 3313.874730][ T4013] el0t_64_sync_handler+0x68/0xbc
[ 3313.874732][ T4013] el0t_64_sync+0x1a8/0x1ac
Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
Reviewed-by: Anish Kumar <yesanishhere@gmail.com>
Link: https://lore.kernel.org/r/20241103160527.82487-1-quic_mojha@quicinc.com
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-12-14 19:48:30 +01:00
..
2023-08-30 16:23:11 +02:00
2023-11-08 17:30:47 +01:00
2024-06-16 13:32:19 +02:00
2024-10-22 15:39:23 +02:00
2024-12-14 19:48:21 +01:00
2024-01-25 14:37:54 -08:00
2024-10-22 15:39:29 +02:00
2024-06-21 14:54:12 +02:00
2023-11-20 11:06:52 +01:00
2024-03-26 18:21:46 -04:00
2024-06-16 13:32:33 +02:00
2024-02-23 08:42:31 +01:00
2024-04-13 12:58:29 +02:00
2023-12-13 18:26:57 +01:00
2024-08-19 05:40:47 +02:00
2024-08-19 05:41:03 +02:00
2024-11-17 14:59:37 +01:00
2024-12-14 19:48:16 +01:00
2023-09-19 12:20:23 +02:00
2023-09-23 11:01:05 +02:00
2023-10-10 21:53:33 +02:00
2023-09-19 12:20:28 +02:00
2024-02-23 08:41:53 +01:00
2024-09-04 13:17:42 +02:00
2024-09-04 13:17:30 +02:00
2024-12-14 19:48:14 +01:00
2024-07-18 13:05:43 +02:00
2023-10-10 21:53:35 +02:00
2024-10-17 15:07:38 +02:00
2024-09-12 11:06:42 +02:00
2024-01-25 14:37:49 -08:00
2023-08-30 16:23:19 +02:00
2024-07-05 09:12:55 +02:00
2024-08-19 05:41:22 +02:00
2024-11-08 16:22:02 +01:00
2024-04-13 12:58:59 +02:00
2023-12-13 18:26:56 +01:00
2024-09-04 13:17:30 +02:00
2023-08-30 16:23:17 +02:00
2023-12-20 15:44:30 +01:00
2024-12-14 19:47:56 +01:00
2024-01-25 14:37:50 -08:00
2024-02-23 08:42:18 +01:00
2024-06-21 14:53:27 +02:00
2024-07-18 13:05:50 +02:00
2024-06-21 14:53:19 +02:00
2024-05-02 16:23:44 +02:00
2023-09-19 12:20:06 +02:00
2024-06-21 14:54:13 +02:00
2024-06-16 13:32:17 +02:00
2024-06-21 14:53:46 +02:00
2024-06-21 14:52:49 +02:00
2024-03-26 18:21:50 -04:00
2024-11-17 14:59:37 +01:00
2024-09-12 11:06:41 +02:00
2024-07-18 13:05:43 +02:00
2024-04-13 12:59:22 +02:00
2023-12-08 08:46:08 +01:00
2024-02-23 08:42:22 +01:00
2024-03-15 10:48:22 -04:00
2024-09-12 11:06:41 +02:00
2024-04-13 12:58:48 +02:00
2024-10-17 15:07:44 +02:00
2023-11-20 11:06:56 +01:00
2023-09-19 12:20:22 +02:00
2023-10-10 21:53:28 +02:00
2023-12-20 15:44:28 +01:00
2024-03-26 18:21:53 -04:00
2024-03-26 18:21:45 -04:00
2024-07-05 09:12:27 +02:00
2023-08-26 15:26:43 +02:00
2023-10-25 11:54:20 +02:00
2023-10-25 11:54:14 +02:00
2024-08-19 05:41:10 +02:00
2024-08-19 05:41:07 +02:00
2024-05-02 16:23:36 +02:00
2024-06-21 14:52:45 +02:00
2024-08-19 05:40:58 +02:00
2024-12-14 19:47:45 +01:00
2024-10-17 15:08:29 +02:00
2023-11-08 17:30:43 +01:00
2024-07-05 09:12:41 +02:00
2024-01-05 15:12:25 +01:00
2024-06-21 14:53:28 +02:00
2024-12-14 19:48:30 +01:00
2023-10-10 21:53:35 +02:00
2024-12-14 19:48:09 +01:00
2024-07-18 13:05:44 +02:00
2024-03-15 10:48:20 -04:00
2023-10-25 11:54:15 +02:00
2023-08-26 15:26:48 +02:00
2024-11-08 16:22:03 +01:00
2024-12-14 19:47:40 +01:00
2024-07-18 13:05:45 +02:00
2024-07-05 09:12:43 +02:00
2024-10-17 15:08:29 +02:00
2023-09-02 09:18:12 +02:00
2024-06-16 13:32:26 +02:00
2024-03-26 18:21:53 -04:00
2024-12-14 19:48:05 +01:00
2023-11-20 11:06:46 +01:00
2024-12-14 19:47:56 +01:00
2024-06-21 14:54:09 +02:00
2024-10-17 15:08:33 +02:00
2024-04-13 12:58:31 +02:00
2023-10-10 21:53:24 +02:00
2024-06-21 14:54:10 +02:00
2024-06-21 14:53:36 +02:00
2024-06-21 14:53:03 +02:00
2023-09-19 12:20:04 +02:00
2023-07-27 08:43:40 +02:00
2024-07-05 09:12:50 +02:00
2024-08-19 05:40:45 +02:00
2024-04-13 12:59:39 +02:00
2024-01-25 14:37:40 -08:00
2023-11-20 11:06:44 +01:00
2023-11-20 11:06:52 +01:00
2024-10-17 15:08:31 +02:00
2024-07-05 09:12:45 +02:00
2023-12-13 18:27:04 +01:00
2023-07-27 08:43:58 +02:00
2024-11-17 14:59:35 +01:00
2024-06-21 14:53:16 +02:00
2024-02-23 08:41:59 +01:00
2023-11-08 17:30:47 +01:00
2024-02-23 08:42:32 +01:00
2023-08-11 11:57:55 +02:00
2024-03-26 18:21:47 -04:00
2024-10-17 15:07:44 +02:00
2023-11-28 16:54:53 +00:00
2023-10-25 11:54:13 +02:00
2023-10-25 11:54:13 +02:00
2023-08-30 16:23:18 +02:00
2023-07-27 08:44:13 +02:00
2024-03-26 18:22:04 -04:00
2024-03-15 10:48:23 -04:00
2024-03-26 18:22:01 -04:00
2023-11-08 17:30:47 +01:00
2024-05-17 11:48:07 +02:00
2024-07-18 13:05:44 +02:00
2024-12-14 19:47:45 +01:00
2023-07-27 08:44:31 +02:00
2024-05-02 16:23:46 +02:00
2024-10-17 15:07:37 +02:00
2024-07-27 10:40:22 +02:00
2024-03-01 13:16:50 +01:00
2024-03-15 10:48:20 -04:00
2024-02-23 08:41:54 +01:00
2024-07-05 09:12:55 +02:00
2024-06-21 14:53:18 +02:00
2024-08-19 05:40:57 +02:00
2023-07-27 08:44:43 +02:00
2024-04-13 12:57:58 +02:00
2024-08-19 05:41:16 +02:00
2024-05-02 16:23:33 +02:00
2024-04-13 12:59:31 +02:00
2024-02-23 08:41:51 +01:00
2023-12-08 08:46:15 +01:00
2024-06-21 14:53:06 +02:00
2024-12-14 19:48:17 +01:00
2024-10-17 15:07:57 +02:00
2024-04-13 12:59:20 +02:00
2023-08-26 15:26:53 +02:00
2024-02-23 08:41:55 +01:00
2023-12-08 08:46:13 +01:00