Xiu Jianfeng ffbb1f15ba cgroup: Fix potential overflow issue when checking max_depth ...

[ Upstream commit 3cc4e13bb1 ]

cgroup.max.depth is the maximum allowed descent depth below the current
cgroup. If the actual descent depth is equal or larger, an attempt to
create a new child cgroup will fail. However due to the cgroup->max_depth
is of int type and having the default value INT_MAX, the condition
'level > cgroup->max_depth' will never be satisfied, and it will cause
an overflow of the level after it reaches to INT_MAX.

Fix it by starting the level from 0 and using '>=' instead.

It's worth mentioning that this issue is unlikely to occur in reality,
as it's impossible to have a depth of INT_MAX hierarchy, but should be
be avoided logically.

Fixes: 1a926e0bba ("cgroup: implement hierarchy limits")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Reviewed-by: Michal Koutný <mkoutny@suse.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2024-11-08 16:22:00 +01:00

..

cgroup-internal.h

cgroup: Make operations on the cgroup root_list RCU safe

2024-10-17 15:07:36 +02:00

cgroup-v1.c

cgroup: Remove duplicates in cgroup v1 tasks file

2023-10-25 11:54:16 +02:00

cgroup.c

cgroup: Fix potential overflow issue when checking max_depth

2024-11-08 16:22:00 +01:00

cpuset.c

cgroup/cpuset: Prevent UAF in proc_cpuset_show()

2024-09-04 13:17:45 +02:00

debug.c

…

freezer.c

…

legacy_freezer.c

…

Makefile

…

namespace.c

cgroup:namespace: Remove unused cgroup_namespaces_init()

2023-09-19 12:20:19 +02:00

pids.c

…

rdma.c

…

rstat.c

cgroup: Fix rootcg cpu.stat guest double counting

2021-11-18 14:04:13 +01:00