mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-06-21 15:43:21 +02:00
Daniel Golle
28019885a3
main() called JobserverExec().run() and discarded its return value,
then the script exited with the implicit status 0. As a result, any
Makefile that wired a build step through jobserver-exec saw the step
silently succeed even when the wrapped command had failed.
Two in-tree callers were affected:
Documentation/devicetree/bindings/Makefile
cmd_chk_style runs a python checker via jobserver-exec and uses
"&& touch $@ || true" so failures leave the stamp file untouched
and the next make rerun reports them again. The swallowed exit
code made the stamp file get created even on failure, caching the
failed run and hiding the reported issues until the inputs change.
scripts/Makefile.vmlinux_o
cmd_gen_initcalls_lds runs scripts/generate_initcall_order.pl via
jobserver-exec; a perl failure was masked by the wrapper.
Return the subprocess exit code from main() and pass it to sys.exit()
so the wrapped command's status reaches make.
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/660368ca16e2d3845577a9fd157d2f37f0e09e85.1779908995.git.daniel@makrotopia.org
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
36 lines
931 B
Python
Executable File
36 lines
931 B
Python
Executable File
#!/usr/bin/env python3
|
|
# SPDX-License-Identifier: GPL-2.0+
|
|
|
|
"""
|
|
Determines how many parallel tasks "make" is expecting, as it is
|
|
not exposed via any special variables, reserves them all, runs a subprocess
|
|
with PARALLELISM environment variable set, and releases the jobs back again.
|
|
|
|
See:
|
|
https://www.gnu.org/software/make/manual/html_node/POSIX-Jobserver.html#POSIX-Jobserver
|
|
"""
|
|
|
|
import os
|
|
import sys
|
|
|
|
LIB_DIR = "../tools/lib/python"
|
|
SRC_DIR = os.path.dirname(os.path.realpath(__file__))
|
|
|
|
sys.path.insert(0, os.path.join(SRC_DIR, LIB_DIR))
|
|
|
|
from jobserver import JobserverExec # pylint: disable=C0415
|
|
|
|
|
|
def main():
|
|
"""Main program"""
|
|
if len(sys.argv) < 2:
|
|
name = os.path.basename(__file__)
|
|
sys.exit("usage: " + name +" command [args ...]\n" + __doc__)
|
|
|
|
with JobserverExec() as jobserver:
|
|
return jobserver.run(sys.argv[1:])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
sys.exit(main())
|