mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-04-29 12:28:27 +02:00
0da3087472
The user of k3_udma_glue_reset_rx_chn() e.g. ti_am65_cpsw_nuss can run on multiple platforms having different DMA architectures. On some platforms there can be one FDQ for all flows in the RX channel while for others there is a separate FDQ for each flow in the RX channel. So far we have been relying on the skip_fdq argument of k3_udma_glue_reset_rx_chn(). Instead of relying on the user to provide this information, infer it based on DMA architecture during k3_udma_glue_request_rx_chn() and save it in an internal flag 'single_fdq'. Use that flag at k3_udma_glue_reset_rx_chn() to deicide if the FDQ needs to be cleared for every flow or just for flow 0. Fixes the below issue on ti_am65_cpsw_nuss driver on AM62-SK. > ip link set eth1 down > ip link set eth0 down > ethtool -L eth0 rx 8 > ip link set eth0 up > modprobe -r ti_am65_cpsw_nuss [ 103.045726] ------------[ cut here ]------------ [ 103.050505] k3_knav_desc_pool size 512000 != avail 64000 [ 103.050703] WARNING: CPU: 1 PID: 450 at drivers/net/ethernet/ti/k3-cppi-desc-pool.c:33 k3_cppi_desc_pool_destroy+0xa0/0xa8 [k3_cppi_desc_pool] [ 103.068810] Modules linked in: ti_am65_cpsw_nuss(-) k3_cppi_desc_pool snd_soc_hdmi_codec crct10dif_ce snd_soc_simple_card snd_soc_simple_card_utils display_connector rtc_ti_k3 k3_j72xx_bandgap tidss drm_client_lib snd_soc_davinci_mcas p drm_dma_helper tps6598x phylink snd_soc_ti_udma rti_wdt drm_display_helper snd_soc_tlv320aic3x_i2c typec at24 phy_gmii_sel snd_soc_ti_edma snd_soc_tlv320aic3x sii902x snd_soc_ti_sdma sa2ul omap_mailbox drm_kms_helper authenc cfg80211 r fkill fuse drm drm_panel_orientation_quirks backlight ip_tables x_tables ipv6 [last unloaded: k3_cppi_desc_pool] [ 103.119950] CPU: 1 UID: 0 PID: 450 Comm: modprobe Not tainted 6.13.0-rc7-00001-g9c5e3435fa66 #1011 [ 103.119968] Hardware name: Texas Instruments AM625 SK (DT) [ 103.119974] pstate: 80000005 (Nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 103.119983] pc : k3_cppi_desc_pool_destroy+0xa0/0xa8 [k3_cppi_desc_pool] [ 103.148007] lr : k3_cppi_desc_pool_destroy+0xa0/0xa8 [k3_cppi_desc_pool] [ 103.154709] sp : ffff8000826ebbc0 [ 103.158015] x29: ffff8000826ebbc0 x28: ffff0000090b6300 x27: 0000000000000000 [ 103.165145] x26: 0000000000000000 x25: 0000000000000000 x24: ffff0000019df6b0 [ 103.172271] x23: ffff0000019df6b8 x22: ffff0000019df410 x21: ffff8000826ebc88 [ 103.179397] x20: 000000000007d000 x19: ffff00000a3b3000 x18: 0000000000000000 [ 103.186522] x17: 0000000000000000 x16: 0000000000000000 x15: 000001e8c35e1cde [ 103.193647] x14: 0000000000000396 x13: 000000000000035c x12: 0000000000000000 [ 103.200772] x11: 000000000000003a x10: 00000000000009c0 x9 : ffff8000826eba20 [ 103.207897] x8 : ffff0000090b6d20 x7 : ffff00007728c180 x6 : ffff00007728c100 [ 103.215022] x5 : 0000000000000001 x4 : ffff000000508a50 x3 : ffff7ffff6146000 [ 103.222147] x2 : 0000000000000000 x1 : e300b4173ee6b200 x0 : 0000000000000000 [ 103.229274] Call trace: [ 103.231714] k3_cppi_desc_pool_destroy+0xa0/0xa8 [k3_cppi_desc_pool] (P) [ 103.238408] am65_cpsw_nuss_free_rx_chns+0x28/0x4c [ti_am65_cpsw_nuss] [ 103.244942] devm_action_release+0x14/0x20 [ 103.249040] release_nodes+0x3c/0x68 [ 103.252610] devres_release_all+0x8c/0xdc [ 103.256614] device_unbind_cleanup+0x18/0x60 [ 103.260876] device_release_driver_internal+0xf8/0x178 [ 103.266004] driver_detach+0x50/0x9c [ 103.269571] bus_remove_driver+0x6c/0xbc [ 103.273485] driver_unregister+0x30/0x60 [ 103.277401] platform_driver_unregister+0x14/0x20 [ 103.282096] am65_cpsw_nuss_driver_exit+0x18/0xff4 [ti_am65_cpsw_nuss] [ 103.288620] __arm64_sys_delete_module+0x17c/0x25c [ 103.293404] invoke_syscall+0x44/0x100 [ 103.297149] el0_svc_common.constprop.0+0xc0/0xe0 [ 103.301845] do_el0_svc+0x1c/0x28 [ 103.305155] el0_svc+0x28/0x98 [ 103.308207] el0t_64_sync_handler+0xc8/0xcc [ 103.312384] el0t_64_sync+0x198/0x19c [ 103.316040] ---[ end trace 0000000000000000 ]--- Signed-off-by: Roger Quadros <rogerq@kernel.org> Acked-by: Jakub Kicinski <kuba@kernel.org> Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com> Link: https://lore.kernel.org/r/20250224-k3-udma-glue-single-fdq-v2-1-cbe7621f2507@kernel.org Signed-off-by: Vinod Koul <vkoul@kernel.org>
154 lines
5.7 KiB
C
154 lines
5.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Copyright (C) 2019 Texas Instruments Incorporated - https://www.ti.com
|
|
*/
|
|
|
|
#ifndef K3_UDMA_GLUE_H_
|
|
#define K3_UDMA_GLUE_H_
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/soc/ti/k3-ringacc.h>
|
|
#include <linux/dma/ti-cppi5.h>
|
|
|
|
struct k3_udma_glue_tx_channel_cfg {
|
|
struct k3_ring_cfg tx_cfg;
|
|
struct k3_ring_cfg txcq_cfg;
|
|
|
|
bool tx_pause_on_err;
|
|
bool tx_filt_einfo;
|
|
bool tx_filt_pswords;
|
|
bool tx_supr_tdpkt;
|
|
u32 swdata_size;
|
|
};
|
|
|
|
struct k3_udma_glue_tx_channel;
|
|
|
|
struct k3_udma_glue_tx_channel *k3_udma_glue_request_tx_chn(struct device *dev,
|
|
const char *name, struct k3_udma_glue_tx_channel_cfg *cfg);
|
|
|
|
struct k3_udma_glue_tx_channel *
|
|
k3_udma_glue_request_tx_chn_for_thread_id(struct device *dev,
|
|
struct k3_udma_glue_tx_channel_cfg *cfg,
|
|
struct device_node *udmax_np, u32 thread_id);
|
|
|
|
void k3_udma_glue_release_tx_chn(struct k3_udma_glue_tx_channel *tx_chn);
|
|
int k3_udma_glue_push_tx_chn(struct k3_udma_glue_tx_channel *tx_chn,
|
|
struct cppi5_host_desc_t *desc_tx,
|
|
dma_addr_t desc_dma);
|
|
int k3_udma_glue_pop_tx_chn(struct k3_udma_glue_tx_channel *tx_chn,
|
|
dma_addr_t *desc_dma);
|
|
int k3_udma_glue_enable_tx_chn(struct k3_udma_glue_tx_channel *tx_chn);
|
|
void k3_udma_glue_disable_tx_chn(struct k3_udma_glue_tx_channel *tx_chn);
|
|
void k3_udma_glue_tdown_tx_chn(struct k3_udma_glue_tx_channel *tx_chn,
|
|
bool sync);
|
|
void k3_udma_glue_reset_tx_chn(struct k3_udma_glue_tx_channel *tx_chn,
|
|
void *data, void (*cleanup)(void *data, dma_addr_t desc_dma));
|
|
u32 k3_udma_glue_tx_get_hdesc_size(struct k3_udma_glue_tx_channel *tx_chn);
|
|
u32 k3_udma_glue_tx_get_txcq_id(struct k3_udma_glue_tx_channel *tx_chn);
|
|
int k3_udma_glue_tx_get_irq(struct k3_udma_glue_tx_channel *tx_chn);
|
|
struct device *
|
|
k3_udma_glue_tx_get_dma_device(struct k3_udma_glue_tx_channel *tx_chn);
|
|
void k3_udma_glue_tx_dma_to_cppi5_addr(struct k3_udma_glue_tx_channel *tx_chn,
|
|
dma_addr_t *addr);
|
|
void k3_udma_glue_tx_cppi5_to_dma_addr(struct k3_udma_glue_tx_channel *tx_chn,
|
|
dma_addr_t *addr);
|
|
|
|
enum {
|
|
K3_UDMA_GLUE_SRC_TAG_LO_KEEP = 0,
|
|
K3_UDMA_GLUE_SRC_TAG_LO_USE_FLOW_REG = 1,
|
|
K3_UDMA_GLUE_SRC_TAG_LO_USE_REMOTE_FLOW_ID = 2,
|
|
K3_UDMA_GLUE_SRC_TAG_LO_USE_REMOTE_SRC_TAG = 4,
|
|
};
|
|
|
|
/**
|
|
* k3_udma_glue_rx_flow_cfg - UDMA RX flow cfg
|
|
*
|
|
* @rx_cfg: RX ring configuration
|
|
* @rxfdq_cfg: RX free Host PD ring configuration
|
|
* @ring_rxq_id: RX ring id (or -1 for any)
|
|
* @ring_rxfdq0_id: RX free Host PD ring (FDQ) if (or -1 for any)
|
|
* @rx_error_handling: Rx Error Handling Mode (0 - drop, 1 - re-try)
|
|
* @src_tag_lo_sel: Rx Source Tag Low Byte Selector in Host PD
|
|
*/
|
|
struct k3_udma_glue_rx_flow_cfg {
|
|
struct k3_ring_cfg rx_cfg;
|
|
struct k3_ring_cfg rxfdq_cfg;
|
|
int ring_rxq_id;
|
|
int ring_rxfdq0_id;
|
|
bool rx_error_handling;
|
|
int src_tag_lo_sel;
|
|
};
|
|
|
|
/**
|
|
* k3_udma_glue_rx_channel_cfg - UDMA RX channel cfg
|
|
*
|
|
* @psdata_size: SW Data is present in Host PD of @swdata_size bytes
|
|
* @flow_id_base: first flow_id used by channel.
|
|
* if @flow_id_base = -1 - range of GP rflows will be
|
|
* allocated dynamically.
|
|
* @flow_id_num: number of RX flows used by channel
|
|
* @flow_id_use_rxchan_id: use RX channel id as flow id,
|
|
* used only if @flow_id_num = 1
|
|
* @remote indication that RX channel is remote - some remote CPU
|
|
* core owns and control the RX channel. Linux Host only
|
|
* allowed to attach and configure RX Flow within RX
|
|
* channel. if set - not RX channel operation will be
|
|
* performed by K3 NAVSS DMA glue interface.
|
|
* @def_flow_cfg default RX flow configuration,
|
|
* used only if @flow_id_num = 1
|
|
*/
|
|
struct k3_udma_glue_rx_channel_cfg {
|
|
u32 swdata_size;
|
|
int flow_id_base;
|
|
int flow_id_num;
|
|
bool flow_id_use_rxchan_id;
|
|
bool remote;
|
|
|
|
struct k3_udma_glue_rx_flow_cfg *def_flow_cfg;
|
|
};
|
|
|
|
struct k3_udma_glue_rx_channel;
|
|
|
|
struct k3_udma_glue_rx_channel *k3_udma_glue_request_rx_chn(
|
|
struct device *dev,
|
|
const char *name,
|
|
struct k3_udma_glue_rx_channel_cfg *cfg);
|
|
|
|
struct k3_udma_glue_rx_channel *
|
|
k3_udma_glue_request_remote_rx_chn_for_thread_id(struct device *dev,
|
|
struct k3_udma_glue_rx_channel_cfg *cfg,
|
|
struct device_node *udmax_np, u32 thread_id);
|
|
|
|
void k3_udma_glue_release_rx_chn(struct k3_udma_glue_rx_channel *rx_chn);
|
|
int k3_udma_glue_enable_rx_chn(struct k3_udma_glue_rx_channel *rx_chn);
|
|
void k3_udma_glue_disable_rx_chn(struct k3_udma_glue_rx_channel *rx_chn);
|
|
void k3_udma_glue_tdown_rx_chn(struct k3_udma_glue_rx_channel *rx_chn,
|
|
bool sync);
|
|
int k3_udma_glue_push_rx_chn(struct k3_udma_glue_rx_channel *rx_chn,
|
|
u32 flow_num, struct cppi5_host_desc_t *desc_tx,
|
|
dma_addr_t desc_dma);
|
|
int k3_udma_glue_pop_rx_chn(struct k3_udma_glue_rx_channel *rx_chn,
|
|
u32 flow_num, dma_addr_t *desc_dma);
|
|
int k3_udma_glue_rx_flow_init(struct k3_udma_glue_rx_channel *rx_chn,
|
|
u32 flow_idx, struct k3_udma_glue_rx_flow_cfg *flow_cfg);
|
|
u32 k3_udma_glue_rx_flow_get_fdq_id(struct k3_udma_glue_rx_channel *rx_chn,
|
|
u32 flow_idx);
|
|
u32 k3_udma_glue_rx_get_flow_id_base(struct k3_udma_glue_rx_channel *rx_chn);
|
|
int k3_udma_glue_rx_get_irq(struct k3_udma_glue_rx_channel *rx_chn,
|
|
u32 flow_num);
|
|
void k3_udma_glue_reset_rx_chn(struct k3_udma_glue_rx_channel *rx_chn,
|
|
u32 flow_num, void *data,
|
|
void (*cleanup)(void *data, dma_addr_t desc_dma));
|
|
int k3_udma_glue_rx_flow_enable(struct k3_udma_glue_rx_channel *rx_chn,
|
|
u32 flow_idx);
|
|
int k3_udma_glue_rx_flow_disable(struct k3_udma_glue_rx_channel *rx_chn,
|
|
u32 flow_idx);
|
|
struct device *
|
|
k3_udma_glue_rx_get_dma_device(struct k3_udma_glue_rx_channel *rx_chn);
|
|
void k3_udma_glue_rx_dma_to_cppi5_addr(struct k3_udma_glue_rx_channel *rx_chn,
|
|
dma_addr_t *addr);
|
|
void k3_udma_glue_rx_cppi5_to_dma_addr(struct k3_udma_glue_rx_channel *rx_chn,
|
|
dma_addr_t *addr);
|
|
|
|
#endif /* K3_UDMA_GLUE_H_ */
|