mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2026-04-24 10:49:54 +02:00
385aab8fcc
MT7996 driver can use both wed and wed_hif2 devices to offload traffic
from/to the wireless NIC. In the current codebase we assume to always
use the primary wed device in wed callbacks resulting in the following
crash if the hw runs wed_hif2 (e.g. 6GHz link).
[ 297.455876] Unable to handle kernel read from unreadable memory at virtual address 000000000000080a
[ 297.464928] Mem abort info:
[ 297.467722] ESR = 0x0000000096000005
[ 297.471461] EC = 0x25: DABT (current EL), IL = 32 bits
[ 297.476766] SET = 0, FnV = 0
[ 297.479809] EA = 0, S1PTW = 0
[ 297.482940] FSC = 0x05: level 1 translation fault
[ 297.487809] Data abort info:
[ 297.490679] ISV = 0, ISS = 0x00000005, ISS2 = 0x00000000
[ 297.496156] CM = 0, WnR = 0, TnD = 0, TagAccess = 0
[ 297.501196] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
[ 297.506500] user pgtable: 4k pages, 39-bit VAs, pgdp=0000000107480000
[ 297.512927] [000000000000080a] pgd=08000001097fb003, p4d=08000001097fb003, pud=08000001097fb003, pmd=0000000000000000
[ 297.523532] Internal error: Oops: 0000000096000005 [#1] SMP
[ 297.715393] CPU: 2 UID: 0 PID: 45 Comm: kworker/u16:2 Tainted: G O 6.12.50 #0
[ 297.723908] Tainted: [O]=OOT_MODULE
[ 297.727384] Hardware name: Banana Pi BPI-R4 (2x SFP+) (DT)
[ 297.732857] Workqueue: nf_ft_offload_del nf_flow_rule_route_ipv6 [nf_flow_table]
[ 297.740254] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[ 297.747205] pc : mt76_wed_offload_disable+0x64/0xa0 [mt76]
[ 297.752688] lr : mtk_wed_flow_remove+0x58/0x80
[ 297.757126] sp : ffffffc080fe3ae0
[ 297.760430] x29: ffffffc080fe3ae0 x28: ffffffc080fe3be0 x27: 00000000deadbef7
[ 297.767557] x26: ffffff80c5ebca00 x25: 0000000000000001 x24: ffffff80c85f4c00
[ 297.774683] x23: ffffff80c1875b78 x22: ffffffc080d42cd0 x21: ffffffc080660018
[ 297.781809] x20: ffffff80c6a076d0 x19: ffffff80c6a043c8 x18: 0000000000000000
[ 297.788935] x17: 0000000000000000 x16: 0000000000000001 x15: 0000000000000000
[ 297.796060] x14: 0000000000000019 x13: ffffff80c0ad8ec0 x12: 00000000fa83b2da
[ 297.803185] x11: ffffff80c02700c0 x10: ffffff80c0ad8ec0 x9 : ffffff81fef96200
[ 297.810311] x8 : ffffff80c02700c0 x7 : ffffff80c02700d0 x6 : 0000000000000002
[ 297.817435] x5 : 0000000000000400 x4 : 0000000000000000 x3 : 0000000000000000
[ 297.824561] x2 : 0000000000000001 x1 : 0000000000000800 x0 : ffffff80c6a063c8
[ 297.831686] Call trace:
[ 297.834123] mt76_wed_offload_disable+0x64/0xa0 [mt76]
[ 297.839254] mtk_wed_flow_remove+0x58/0x80
[ 297.843342] mtk_flow_offload_cmd+0x434/0x574
[ 297.847689] mtk_wed_setup_tc_block_cb+0x30/0x40
[ 297.852295] nf_flow_offload_ipv6_hook+0x7f4/0x964 [nf_flow_table]
[ 297.858466] nf_flow_rule_route_ipv6+0x438/0x4a4 [nf_flow_table]
[ 297.864463] process_one_work+0x174/0x300
[ 297.868465] worker_thread+0x278/0x430
[ 297.872204] kthread+0xd8/0xdc
[ 297.875251] ret_from_fork+0x10/0x20
[ 297.878820] Code: 928b5ae0 8b000273 91400a60 f943fa61 (79401421)
[ 297.884901] ---[ end trace 0000000000000000 ]---
Fix the issue detecting the proper wed reference to use running wed
callabacks.
Fixes: 83eafc9251 ("wifi: mt76: mt7996: add wed tx support")
Tested-by: Daniel Pawlik <pawlik.dan@gmail.com>
Tested-by: Matteo Croce <teknoraver@meta.com>
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Link: https://patch.msgid.link/20251008-wed-fixes-v1-1-8f7678583385@kernel.org
Signed-off-by: Felix Fietkau <nbd@nbd.name>
334 lines
9.3 KiB
C
334 lines
9.3 KiB
C
#ifndef __MTK_WED_H
|
|
#define __MTK_WED_H
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/rcupdate.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/pci.h>
|
|
#include <linux/skbuff.h>
|
|
#include <linux/netdevice.h>
|
|
|
|
#define MTK_WED_TX_QUEUES 2
|
|
#define MTK_WED_RX_QUEUES 2
|
|
#define MTK_WED_RX_PAGE_QUEUES 3
|
|
|
|
#define WED_WO_STA_REC 0x6
|
|
|
|
struct mtk_wed_hw;
|
|
struct mtk_wdma_desc;
|
|
|
|
enum mtk_wed_wo_cmd {
|
|
MTK_WED_WO_CMD_WED_CFG,
|
|
MTK_WED_WO_CMD_WED_RX_STAT,
|
|
MTK_WED_WO_CMD_RRO_SER,
|
|
MTK_WED_WO_CMD_DBG_INFO,
|
|
MTK_WED_WO_CMD_DEV_INFO,
|
|
MTK_WED_WO_CMD_BSS_INFO,
|
|
MTK_WED_WO_CMD_STA_REC,
|
|
MTK_WED_WO_CMD_DEV_INFO_DUMP,
|
|
MTK_WED_WO_CMD_BSS_INFO_DUMP,
|
|
MTK_WED_WO_CMD_STA_REC_DUMP,
|
|
MTK_WED_WO_CMD_BA_INFO_DUMP,
|
|
MTK_WED_WO_CMD_FBCMD_Q_DUMP,
|
|
MTK_WED_WO_CMD_FW_LOG_CTRL,
|
|
MTK_WED_WO_CMD_LOG_FLUSH,
|
|
MTK_WED_WO_CMD_CHANGE_STATE,
|
|
MTK_WED_WO_CMD_CPU_STATS_ENABLE,
|
|
MTK_WED_WO_CMD_CPU_STATS_DUMP,
|
|
MTK_WED_WO_CMD_EXCEPTION_INIT,
|
|
MTK_WED_WO_CMD_PROF_CTRL,
|
|
MTK_WED_WO_CMD_STA_BA_DUMP,
|
|
MTK_WED_WO_CMD_BA_CTRL_DUMP,
|
|
MTK_WED_WO_CMD_RXCNT_CTRL,
|
|
MTK_WED_WO_CMD_RXCNT_INFO,
|
|
MTK_WED_WO_CMD_SET_CAP,
|
|
MTK_WED_WO_CMD_CCIF_RING_DUMP,
|
|
MTK_WED_WO_CMD_WED_END
|
|
};
|
|
|
|
struct mtk_wed_bm_desc {
|
|
__le32 buf0;
|
|
__le32 token;
|
|
} __packed __aligned(4);
|
|
|
|
enum mtk_wed_bus_tye {
|
|
MTK_WED_BUS_PCIE,
|
|
MTK_WED_BUS_AXI,
|
|
};
|
|
|
|
#define MTK_WED_RING_CONFIGURED BIT(0)
|
|
struct mtk_wed_ring {
|
|
struct mtk_wdma_desc *desc;
|
|
dma_addr_t desc_phys;
|
|
u32 desc_size;
|
|
int size;
|
|
u32 flags;
|
|
|
|
u32 reg_base;
|
|
void __iomem *wpdma;
|
|
};
|
|
|
|
struct mtk_wed_wo_rx_stats {
|
|
__le16 wlan_idx;
|
|
__le16 tid;
|
|
__le32 rx_pkt_cnt;
|
|
__le32 rx_byte_cnt;
|
|
__le32 rx_err_cnt;
|
|
__le32 rx_drop_cnt;
|
|
};
|
|
|
|
struct mtk_wed_buf {
|
|
void *p;
|
|
dma_addr_t phy_addr;
|
|
};
|
|
|
|
struct mtk_wed_device {
|
|
#ifdef CONFIG_NET_MEDIATEK_SOC_WED
|
|
const struct mtk_wed_ops *ops;
|
|
struct device *dev;
|
|
struct mtk_wed_hw *hw;
|
|
bool init_done, running;
|
|
int wdma_idx;
|
|
int irq;
|
|
u8 version;
|
|
|
|
/* used by wlan driver */
|
|
u32 rev_id;
|
|
|
|
struct mtk_wed_ring tx_ring[MTK_WED_TX_QUEUES];
|
|
struct mtk_wed_ring rx_ring[MTK_WED_RX_QUEUES];
|
|
struct mtk_wed_ring txfree_ring;
|
|
struct mtk_wed_ring tx_wdma[MTK_WED_TX_QUEUES];
|
|
struct mtk_wed_ring rx_wdma[MTK_WED_RX_QUEUES];
|
|
struct mtk_wed_ring rx_rro_ring[MTK_WED_RX_QUEUES];
|
|
struct mtk_wed_ring rx_page_ring[MTK_WED_RX_PAGE_QUEUES];
|
|
struct mtk_wed_ring ind_cmd_ring;
|
|
|
|
struct {
|
|
int size;
|
|
struct mtk_wed_buf *pages;
|
|
struct mtk_wdma_desc *desc;
|
|
dma_addr_t desc_phys;
|
|
} tx_buf_ring;
|
|
|
|
struct {
|
|
int size;
|
|
struct mtk_wed_bm_desc *desc;
|
|
dma_addr_t desc_phys;
|
|
} rx_buf_ring;
|
|
|
|
struct {
|
|
struct mtk_wed_ring ring;
|
|
dma_addr_t miod_phys;
|
|
dma_addr_t fdbk_phys;
|
|
} rro;
|
|
|
|
struct {
|
|
int size;
|
|
struct mtk_wed_buf *pages;
|
|
struct mtk_wed_bm_desc *desc;
|
|
dma_addr_t desc_phys;
|
|
} hw_rro;
|
|
|
|
/* filled by driver: */
|
|
struct {
|
|
union {
|
|
struct platform_device *platform_dev;
|
|
struct pci_dev *pci_dev;
|
|
};
|
|
enum mtk_wed_bus_tye bus_type;
|
|
void __iomem *base;
|
|
u32 phy_base;
|
|
u32 id;
|
|
|
|
u32 wpdma_phys;
|
|
u32 wpdma_int;
|
|
u32 wpdma_mask;
|
|
u32 wpdma_tx;
|
|
u32 wpdma_txfree;
|
|
u32 wpdma_rx_glo;
|
|
u32 wpdma_rx[MTK_WED_RX_QUEUES];
|
|
u32 wpdma_rx_rro[MTK_WED_RX_QUEUES];
|
|
u32 wpdma_rx_pg;
|
|
|
|
bool wcid_512;
|
|
bool hw_rro;
|
|
bool msi;
|
|
bool hif2;
|
|
|
|
u16 token_start;
|
|
unsigned int nbuf;
|
|
unsigned int rx_nbuf;
|
|
unsigned int rx_npkt;
|
|
unsigned int rx_size;
|
|
unsigned int amsdu_max_len;
|
|
|
|
u8 tx_tbit[MTK_WED_TX_QUEUES];
|
|
u8 rx_tbit[MTK_WED_RX_QUEUES];
|
|
u8 rro_rx_tbit[MTK_WED_RX_QUEUES];
|
|
u8 rx_pg_tbit[MTK_WED_RX_PAGE_QUEUES];
|
|
u8 txfree_tbit;
|
|
u8 amsdu_max_subframes;
|
|
|
|
struct {
|
|
u8 se_group_nums;
|
|
u16 win_size;
|
|
u16 particular_sid;
|
|
u32 ack_sn_addr;
|
|
dma_addr_t particular_se_phys;
|
|
dma_addr_t addr_elem_phys[1024];
|
|
} ind_cmd;
|
|
|
|
u32 (*init_buf)(void *ptr, dma_addr_t phys, int token_id);
|
|
int (*offload_enable)(struct mtk_wed_device *wed);
|
|
void (*offload_disable)(struct mtk_wed_device *wed);
|
|
u32 (*init_rx_buf)(struct mtk_wed_device *wed, int size);
|
|
void (*release_rx_buf)(struct mtk_wed_device *wed);
|
|
void (*update_wo_rx_stats)(struct mtk_wed_device *wed,
|
|
struct mtk_wed_wo_rx_stats *stats);
|
|
int (*reset)(struct mtk_wed_device *wed);
|
|
void (*reset_complete)(struct mtk_wed_device *wed);
|
|
} wlan;
|
|
#endif
|
|
};
|
|
|
|
struct mtk_wed_ops {
|
|
int (*attach)(struct mtk_wed_device *dev) __releases(RCU);
|
|
int (*tx_ring_setup)(struct mtk_wed_device *dev, int ring,
|
|
void __iomem *regs, bool reset);
|
|
int (*rx_ring_setup)(struct mtk_wed_device *dev, int ring,
|
|
void __iomem *regs, bool reset);
|
|
int (*txfree_ring_setup)(struct mtk_wed_device *dev,
|
|
void __iomem *regs);
|
|
int (*msg_update)(struct mtk_wed_device *dev, int cmd_id,
|
|
void *data, int len);
|
|
void (*detach)(struct mtk_wed_device *dev);
|
|
void (*ppe_check)(struct mtk_wed_device *dev, struct sk_buff *skb,
|
|
u32 reason, u32 hash);
|
|
|
|
void (*stop)(struct mtk_wed_device *dev);
|
|
void (*start)(struct mtk_wed_device *dev, u32 irq_mask);
|
|
void (*reset_dma)(struct mtk_wed_device *dev);
|
|
|
|
u32 (*reg_read)(struct mtk_wed_device *dev, u32 reg);
|
|
void (*reg_write)(struct mtk_wed_device *dev, u32 reg, u32 val);
|
|
|
|
u32 (*irq_get)(struct mtk_wed_device *dev, u32 mask);
|
|
void (*irq_set_mask)(struct mtk_wed_device *dev, u32 mask);
|
|
int (*setup_tc)(struct mtk_wed_device *wed, struct net_device *dev,
|
|
enum tc_setup_type type, void *type_data);
|
|
void (*start_hw_rro)(struct mtk_wed_device *dev, u32 irq_mask,
|
|
bool reset);
|
|
void (*rro_rx_ring_setup)(struct mtk_wed_device *dev, int ring,
|
|
void __iomem *regs);
|
|
void (*msdu_pg_rx_ring_setup)(struct mtk_wed_device *dev, int ring,
|
|
void __iomem *regs);
|
|
int (*ind_rx_ring_setup)(struct mtk_wed_device *dev,
|
|
void __iomem *regs);
|
|
};
|
|
|
|
extern const struct mtk_wed_ops __rcu *mtk_soc_wed_ops;
|
|
|
|
static inline int
|
|
mtk_wed_device_attach(struct mtk_wed_device *dev)
|
|
{
|
|
int ret = -ENODEV;
|
|
|
|
#ifdef CONFIG_NET_MEDIATEK_SOC_WED
|
|
rcu_read_lock();
|
|
dev->ops = rcu_dereference(mtk_soc_wed_ops);
|
|
if (dev->ops)
|
|
ret = dev->ops->attach(dev);
|
|
else
|
|
rcu_read_unlock();
|
|
|
|
if (ret)
|
|
dev->ops = NULL;
|
|
#endif
|
|
|
|
return ret;
|
|
}
|
|
|
|
static inline bool mtk_wed_get_rx_capa(struct mtk_wed_device *dev)
|
|
{
|
|
#ifdef CONFIG_NET_MEDIATEK_SOC_WED
|
|
if (dev->version == 3)
|
|
return dev->wlan.hw_rro;
|
|
|
|
return dev->version != 1;
|
|
#else
|
|
return false;
|
|
#endif
|
|
}
|
|
|
|
static inline bool mtk_wed_is_amsdu_supported(struct mtk_wed_device *dev)
|
|
{
|
|
#ifdef CONFIG_NET_MEDIATEK_SOC_WED
|
|
return dev->version == 3;
|
|
#else
|
|
return false;
|
|
#endif
|
|
}
|
|
|
|
#ifdef CONFIG_NET_MEDIATEK_SOC_WED
|
|
#define mtk_wed_device_active(_dev) !!(_dev)->ops
|
|
#define mtk_wed_device_detach(_dev) (_dev)->ops->detach(_dev)
|
|
#define mtk_wed_device_start(_dev, _mask) (_dev)->ops->start(_dev, _mask)
|
|
#define mtk_wed_device_tx_ring_setup(_dev, _ring, _regs, _reset) \
|
|
(_dev)->ops->tx_ring_setup(_dev, _ring, _regs, _reset)
|
|
#define mtk_wed_device_txfree_ring_setup(_dev, _regs) \
|
|
(_dev)->ops->txfree_ring_setup(_dev, _regs)
|
|
#define mtk_wed_device_reg_read(_dev, _reg) \
|
|
(_dev)->ops->reg_read(_dev, _reg)
|
|
#define mtk_wed_device_reg_write(_dev, _reg, _val) \
|
|
(_dev)->ops->reg_write(_dev, _reg, _val)
|
|
#define mtk_wed_device_irq_get(_dev, _mask) \
|
|
(_dev)->ops->irq_get(_dev, _mask)
|
|
#define mtk_wed_device_irq_set_mask(_dev, _mask) \
|
|
(_dev)->ops->irq_set_mask(_dev, _mask)
|
|
#define mtk_wed_device_rx_ring_setup(_dev, _ring, _regs, _reset) \
|
|
(_dev)->ops->rx_ring_setup(_dev, _ring, _regs, _reset)
|
|
#define mtk_wed_device_ppe_check(_dev, _skb, _reason, _hash) \
|
|
(_dev)->ops->ppe_check(_dev, _skb, _reason, _hash)
|
|
#define mtk_wed_device_update_msg(_dev, _id, _msg, _len) \
|
|
(_dev)->ops->msg_update(_dev, _id, _msg, _len)
|
|
#define mtk_wed_device_stop(_dev) (_dev)->ops->stop(_dev)
|
|
#define mtk_wed_device_dma_reset(_dev) (_dev)->ops->reset_dma(_dev)
|
|
#define mtk_wed_device_setup_tc(_dev, _netdev, _type, _type_data) \
|
|
(_dev)->ops->setup_tc(_dev, _netdev, _type, _type_data)
|
|
#define mtk_wed_device_start_hw_rro(_dev, _mask, _reset) \
|
|
(_dev)->ops->start_hw_rro(_dev, _mask, _reset)
|
|
#define mtk_wed_device_rro_rx_ring_setup(_dev, _ring, _regs) \
|
|
(_dev)->ops->rro_rx_ring_setup(_dev, _ring, _regs)
|
|
#define mtk_wed_device_msdu_pg_rx_ring_setup(_dev, _ring, _regs) \
|
|
(_dev)->ops->msdu_pg_rx_ring_setup(_dev, _ring, _regs)
|
|
#define mtk_wed_device_ind_rx_ring_setup(_dev, _regs) \
|
|
(_dev)->ops->ind_rx_ring_setup(_dev, _regs)
|
|
|
|
#else
|
|
static inline bool mtk_wed_device_active(struct mtk_wed_device *dev)
|
|
{
|
|
return false;
|
|
}
|
|
#define mtk_wed_device_detach(_dev) do {} while (0)
|
|
#define mtk_wed_device_start(_dev, _mask) do {} while (0)
|
|
#define mtk_wed_device_tx_ring_setup(_dev, _ring, _regs, _reset) -ENODEV
|
|
#define mtk_wed_device_txfree_ring_setup(_dev, _ring, _regs) -ENODEV
|
|
#define mtk_wed_device_reg_read(_dev, _reg) 0
|
|
#define mtk_wed_device_reg_write(_dev, _reg, _val) do {} while (0)
|
|
#define mtk_wed_device_irq_get(_dev, _mask) 0
|
|
#define mtk_wed_device_irq_set_mask(_dev, _mask) do {} while (0)
|
|
#define mtk_wed_device_rx_ring_setup(_dev, _ring, _regs, _reset) -ENODEV
|
|
#define mtk_wed_device_ppe_check(_dev, _skb, _reason, _hash) do {} while (0)
|
|
#define mtk_wed_device_update_msg(_dev, _id, _msg, _len) -ENODEV
|
|
#define mtk_wed_device_stop(_dev) do {} while (0)
|
|
#define mtk_wed_device_dma_reset(_dev) do {} while (0)
|
|
#define mtk_wed_device_setup_tc(_dev, _netdev, _type, _type_data) -EOPNOTSUPP
|
|
#define mtk_wed_device_start_hw_rro(_dev, _mask, _reset) do {} while (0)
|
|
#define mtk_wed_device_rro_rx_ring_setup(_dev, _ring, _regs) -ENODEV
|
|
#define mtk_wed_device_msdu_pg_rx_ring_setup(_dev, _ring, _regs) -ENODEV
|
|
#define mtk_wed_device_ind_rx_ring_setup(_dev, _regs) -ENODEV
|
|
#endif
|
|
|
|
#endif
|