Andrii Nakryiko ded61e5527 libbpf: fix sym_is_subprog() logic for weak global subprogs ...

[ Upstream commit 4073213488 ]

sym_is_subprog() is incorrectly rejecting relocations against *weak*
global subprogs. Fix that by realizing that STB_WEAK is also a global
function.

While it seems like verifier doesn't support taking an address of
non-static subprog right now, it's still best to fix support for it on
libbpf side, otherwise users will get a very confusing error during BPF
skeleton generation or static linking due to misinterpreted relocation:

  libbpf: prog 'handle_tp': bad map relo against 'foo' in section '.text'
  Error: failed to open BPF object file: Relocation failed

It's clearly not a map relocation, but is treated and reported as such
without this fix.

Fixes: 53eddb5e04 ("libbpf: Support subprog address relocation")
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/r/20241009011554.880168-1-andrii@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2024-12-14 19:50:54 +01:00

..

api

libapi: Add missing linux/types.h header to get the __u64 type on io.h

2024-01-25 14:52:50 -08:00

bpf

libbpf: fix sym_is_subprog() logic for weak global subprogs

2024-12-14 19:50:54 +01:00

lockdep

…

perf

libperf evlist: Avoid out-of-bounds access

2024-04-13 13:01:45 +02:00

subcmd

libsubcmd: Fix parse-options memory leak

2024-06-16 13:39:40 +02:00

symbol

…

traceevent

…

argv_split.c

…

bitmap.c

…

ctype.c

…

find_bit.c

…

hweight.c

…

rbtree.c

…

str_error_r.c

…

string.c

…

vsprintf.c

…

zalloc.c

…