Files
linux-stable-mirror/include/linux
Ben Hutchings 3cfde79c6c net: Get rid of rtnl_link_stats64 / net_device_stats union
In commit be1f3c2c02 "net: Enable 64-bit
net device statistics on 32-bit architectures" I redefined struct
net_device_stats so that it could be used in a union with struct
rtnl_link_stats64, avoiding the need for explicit copying or
conversion between the two.  However, this is unsafe because there is
no locking required and no lock consistently held around calls to
dev_get_stats() and use of the statistics structure it returns.

In commit 28172739f0 "net: fix 64 bit
counters on 32 bit arches" Eric Dumazet dealt with that problem by
requiring callers of dev_get_stats() to provide storage for the
result.  This means that the net_device::stats64 field and the padding
in struct net_device_stats are now redundant, so remove them.

Update the comment on net_device_ops::ndo_get_stats64 to reflect its
new usage.

Change dev_txq_stats_fold() to use struct rtnl_link_stats64, since
that is what all its callers are really using and it is no longer
going to be compatible with struct net_device_stats.

Eric Dumazet suggested the separate function for the structure
conversion.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2010-07-09 17:41:56 -07:00
..
2010-05-28 01:38:00 +02:00
2010-06-04 16:00:42 -04:00
2010-05-27 09:12:53 -07:00
2010-05-19 13:38:54 -04:00
2010-06-24 21:30:09 -07:00
2010-05-19 22:41:57 -04:00
2010-05-21 19:30:44 +02:00
2010-05-27 22:05:02 -04:00
2010-05-27 22:15:33 -04:00
2010-05-25 08:07:01 -07:00
2010-05-27 09:12:42 -07:00
2010-05-21 09:34:29 -07:00
2010-06-03 03:21:52 -07:00
2010-06-03 03:21:52 -07:00
2010-06-03 03:21:52 -07:00
2010-06-03 03:21:52 -07:00
2010-06-28 23:24:30 -07:00
2010-06-03 03:21:52 -07:00
2010-06-23 13:16:38 -07:00
2010-06-22 08:07:01 +02:00
2010-06-03 03:21:52 -07:00
2010-06-03 03:21:52 -07:00
2010-05-21 09:37:29 -07:00
2010-05-25 19:41:19 -04:00
2010-06-03 03:21:52 -07:00
2010-06-03 03:21:52 -07:00
2010-06-03 03:21:52 -07:00
2010-06-03 03:21:52 -07:00
2010-07-02 21:59:08 -07:00
2010-05-19 13:44:27 +10:00
2010-06-03 03:21:52 -07:00
2010-06-03 03:21:52 -07:00
2010-05-27 09:12:50 -07:00
2010-05-30 09:02:47 -07:00
2010-06-03 03:21:52 -07:00
2010-05-25 11:41:43 -04:00
2010-06-16 14:55:35 -07:00
2010-05-27 09:12:43 -07:00
2010-05-21 09:34:29 -07:00
2010-05-19 22:40:47 -04:00
2010-05-19 22:15:46 +09:30
2010-06-03 03:21:52 -07:00