Jocelyn Falempe 24186c6822 drm/mgag200: Fix PLL setup for G200_SE_A rev >=4 ...

commit b389286d02 upstream.

For G200_SE_A, PLL M setting is wrong, which leads to blank screen,
or "signal out of range" on VGA display.
previous code had "m |= 0x80" which was changed to
m |= ((pixpllcn & BIT(8)) >> 1);

Tested on G200_SE_A rev 42

This line of code was moved to another file with
commit 877507bb95 ("drm/mgag200: Provide per-device callbacks for
PIXPLLC") but can be easily backported before this commit.

v2: * put BIT(7) First to respect MSB-to-LSB (Thomas)
    * Add a comment to explain that this bit must be set (Thomas)

Fixes: 2dd040946e ("drm/mgag200: Store values (not bits) in struct mgag200_pll_values")
Cc: stable@vger.kernel.org
Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20221013132810.521945-1-jfalempe@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2023-01-12 11:59:20 +01:00

..

Kconfig

…

Makefile

…

mgag200_drv.c

…

mgag200_drv.h

…

mgag200_i2c.c

…

mgag200_mm.c

…

mgag200_mode.c

…

mgag200_pll.c

drm/mgag200: Fix PLL setup for G200_SE_A rev >=4

2023-01-12 11:59:20 +01:00

mgag200_reg.h

…