Mirsad Goran Todorovac de091a6e1f test_firmware: fix a memory leak with reqs buffer ...

[ Upstream commit be37bed754 ]

Dan Carpenter spotted that test_fw_config->reqs will be leaked if
trigger_batched_requests_store() is called two or more times.
The same appears with trigger_batched_requests_async_store().

This bug wasn't trigger by the tests, but observed by Dan's visual
inspection of the code.

The recommended workaround was to return -EBUSY if test_fw_config->reqs
is already allocated.

Fixes: 7feebfa487 ("test_firmware: add support for request_firmware_into_buf")
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Russ Weight <russell.h.weight@intel.com>
Cc: Tianfei Zhang <tianfei.zhang@intel.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Colin Ian King <colin.i.king@gmail.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kselftest@vger.kernel.org
Cc: stable@vger.kernel.org # v5.4
Suggested-by: Dan Carpenter <error27@gmail.com>
Suggested-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Link: https://lore.kernel.org/r/20230509084746.48259-2-mirsad.todorovac@alu.unizg.hr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2023-06-21 15:59:12 +02:00

..

842

…

crypto

crypto: lib - remove unneeded selection of XOR_BLOCKS

2022-09-05 10:30:03 +02:00

dim

linux/dim: Do nothing if no time delta between samples

2023-05-24 17:36:41 +01:00

fonts

lib/fonts: fix undefined behavior in bit shift for get_default_font

2022-12-31 13:14:02 +01:00

kunit

kunit: fix debugfs code to use enum kunit_status, not bool

2022-06-09 10:22:53 +02:00

livepatch

selftests/livepatch: better synchronize test_klp_callbacks_busy

2022-08-17 14:24:03 +02:00

lz4

lz4: fix LZ4_decompress_safe_partial read out of bound

2022-04-13 20:59:21 +02:00

lzo

…

math

math: make RATIONAL tristate

2021-09-08 11:50:26 -07:00

mpi

lib/mpi: Fix buffer overrun when SG is too long

2023-03-10 09:39:09 +01:00

pldmfw

…

raid6

lib/raid6/test/Makefile: Use $(pound) instead of \# for Make 4.3

2022-04-08 14:23:56 +02:00

reed_solomon

…

vdso

lib/vdso: use "grep -E" instead of "egrep"

2022-12-02 17:41:08 +01:00

xz

lib/xz: Validate the value before assigning it to an enum variable

2021-11-18 19:16:17 +01:00

zlib_deflate

…

zlib_dfltcc

…

zlib_inflate

lib/zlib_inflate/inffast: check config in C to avoid unused function warning

2021-09-24 16:13:35 -07:00

zstd

…

.gitignore

…

argv_split.c

…

ashldi3.c

…

ashrdi3.c

…

asn1_decoder.c

…

asn1_encoder.c

…

assoc_array.c

assoc_array: Fix BUG_ON during garbage collect

2022-06-06 08:43:37 +02:00

atomic64_test.c

…

atomic64.c

…

audit.c

…

bcd.c

…

bch.c

…

bitfield_kunit.c

…

bitmap.c

…

bitrev.c

…

bootconfig.c

memblock: introduce saner 'memblock_free_ptr()' interface

2021-09-14 13:23:22 -07:00

bsearch.c

…

btree.c

…

bucket_locks.c

…

bug.c

…

build_OID_registry

…

buildid.c

…

bust_spinlocks.c

…

check_signature.c

…

checksum.c

…

clz_ctz.c

…

clz_tab.c

…

cmdline_kunit.c

…

cmdline.c

…

cmpdi2.c

…

compat_audit.c

…

cpu_rmap.c

lib: cpu_rmap: Fix potential use-after-free in irq_cpu_rmap_release()

2023-06-14 11:13:04 +02:00

cpumask.c

…

crc4.c

…

crc7.c

…

crc8.c

…

crc16.c

…

crc32.c

…

crc32defs.h

…

crc32test.c

…

crc64.c

…

crc-ccitt.c

…

crc-itu-t.c

…

crc-t10dif.c

…

ctype.c

…

debug_info.c

…

debug_locks.c

…

debugobjects.c

Revert "debugobject: Ensure pool refill (again)"

2023-06-14 11:13:09 +02:00

dec_and_lock.c

…

decompress_bunzip2.c

…

decompress_inflate.c

…

decompress_unlz4.c

…

decompress_unlzma.c

…

decompress_unlzo.c

…

decompress_unxz.c

lib/xz: Avoid overlapping memcpy() with invalid input with in-place decompression

2021-11-18 19:16:17 +01:00

decompress_unzstd.c

…

decompress.c

…

devmem_is_allowed.c

…

devres.c

…

digsig.c

…

dump_stack.c

lib/dump_stack: correct kernel-doc notation

2021-09-08 11:50:26 -07:00

dynamic_debug.c

dyndbg: drop EXPORTed dynamic_debug_exec_queries

2022-10-26 12:35:08 +02:00

dynamic_queue_limits.c

…

earlycpio.c

…

errname.c

printf: fix errname.c list

2023-03-10 09:39:33 +01:00

error-inject.c

…

errseq.c

…

extable.c

…

fault-inject-usercopy.c

…

fault-inject.c

…

fdt_addresses.c

…

fdt_empty_tree.c

…

fdt_ro.c

…

fdt_rw.c

…

fdt_strerror.c

…

fdt_sw.c

…

fdt_wip.c

…

fdt.c

…

find_bit_benchmark.c

…

find_bit.c

…

flex_proportions.c

…

gen_crc32table.c

…

gen_crc64table.c

…

genalloc.c

…

generic-radix-tree.c

…

glob.c

…

globtest.c

…

hexdump.c

hex2bin: fix access beyond string end

2022-05-09 09:14:30 +02:00

hweight.c

…

idr.c

ida: don't use BUG_ON() for debugging

2022-07-12 16:35:18 +02:00

inflate.c

…

interval_tree_test.c

…

interval_tree.c

…

iomap_copy.c

…

iomap.c

…

iommu-helper.c

…

iov_iter.c

fix short copy handling in copy_mc_pipe_to_iter()

2022-08-17 14:22:51 +02:00

irq_poll.c

…

irq_regs.c

…

is_single_threaded.c

…

kasprintf.c

…

Kconfig

crypto: memneq - move into lib/

2022-06-22 14:22:03 +02:00

Kconfig.debug

lib/Kconfig.debug: Allow BTF + DWARF5 with pahole 1.21+

2023-02-25 12:06:46 +01:00

Kconfig.kasan

kasan: fix Kconfig check of CC_HAS_WORKING_NOSANITIZE_ADDRESS

2021-09-24 16:13:34 -07:00

Kconfig.kcsan

…

Kconfig.kfence

kfence: default to dynamic branch instead of static keys mode

2021-11-12 15:05:49 +01:00

Kconfig.kgdb

…

Kconfig.ubsan

ubsan: remove CONFIG_UBSAN_OBJECT_SIZE

2022-04-13 20:59:27 +02:00

kfifo.c

…

klist.c

…

kobject_uevent.c

…

kobject.c

kobject: Fix slab-out-of-bounds in fill_kobj_path()

2023-03-10 09:39:35 +01:00

kstrtox.c

…

kstrtox.h

…

libcrc32c.c

…

linear_ranges.c

…

list_debug.c

lib/list_debug.c: Detect uninitialized lists

2022-08-25 11:40:40 +02:00

list_sort.c

…

list-test.c

list: test: Add a test for list_is_head()

2022-06-09 10:23:31 +02:00

llist.c

…

locking-selftest-hardirq.h

…

locking-selftest-mutex.h

…

locking-selftest-rlock-hardirq.h

…

locking-selftest-rlock-softirq.h

…

locking-selftest-rlock.h

…

locking-selftest-rsem.h

…

locking-selftest-rtmutex.h

…

locking-selftest-softirq.h

…

locking-selftest-spin-hardirq.h

…

locking-selftest-spin-softirq.h

…

locking-selftest-spin.h

…

locking-selftest-wlock-hardirq.h

…

locking-selftest-wlock-softirq.h

…

locking-selftest-wlock.h

…

locking-selftest-wsem.h

…

locking-selftest.c

…

lockref.c

lockref: stop doing cpu_relax in the cmpxchg loop

2023-02-01 08:27:19 +01:00

logic_iomem.c

lib/logic_iomem: correct fallback config references

2022-04-13 20:58:59 +02:00

logic_pio.c

…

lru_cache.c

…

lshrdi3.c

…

Makefile

crypto: memneq - move into lib/

2022-06-22 14:22:03 +02:00

memcat_p.c

…

memneq.c

crypto: memneq - move into lib/

2022-06-22 14:22:03 +02:00

memory-notifier-error-inject.c

…

memregion.c

…

memweight.c

…

muldi3.c

…

net_utils.c

…

netdev-notifier-error-inject.c

…

nlattr.c

netlink: prevent potential spectre v1 gadgets

2023-02-01 08:27:26 +01:00

nmi_backtrace.c

printk: restore flushing of NMI buffers on remote CPUs after NMI backtraces

2021-11-25 09:48:45 +01:00

nodemask.c

nodemask: Fix return values to be unsigned

2022-06-14 18:36:24 +02:00

notifier-error-inject.c

lib/notifier-error-inject: fix error when writing -errno to debugfs file

2022-12-31 13:14:03 +01:00

notifier-error-inject.h

…

objagg.c

…

of-reconfig-notifier-error-inject.c

…

oid_registry.c

…

once.c

once: add DO_ONCE_SLOW() for sleepable contexts

2022-10-26 12:34:49 +02:00

packing.c

net: update NXP copyright text

2021-09-17 13:52:17 +01:00

parman.c

…

parser.c

…

pci_iomap.c

pci_iounmap'2: Electric Boogaloo: try to make sense of it all

2021-09-19 17:13:35 -07:00

percpu_counter.c

…

percpu_test.c

…

percpu-refcount.c

percpu_ref_init(): clean ->percpu_count_ref on failure

2022-06-06 08:43:36 +02:00

plist.c

…

pm-notifier-error-inject.c

…

radix-tree.c

…

random32.c

random: replace custom notifier chain with standard one

2022-05-30 09:29:10 +02:00

ratelimit.c

ratelimit: Fix data-races in ___ratelimit().

2022-08-31 17:16:43 +02:00

rbtree_test.c

…

rbtree.c

…

refcount.c

…

rhashtable.c

…

sbitmap.c

…

scatterlist.c

…

seq_buf.c

…

sg_pool.c

…

sg_split.c

…

sha1.c

lib/crypto: sha1: re-roll loops to reduce code size

2022-05-30 09:28:59 +02:00

show_mem.c

…

siphash.c

siphash: use one source of truth for siphash permutations

2022-05-30 09:29:15 +02:00

slub_kunit.c

…

smp_processor_id.c

lib/smp_processor_id: fix imbalanced instrumentation_end() call

2022-08-17 14:24:08 +02:00

sort.c

…

stackdepot.c

stacktrace: move filter_irq_stacks() to kernel/stacktrace.c

2022-04-13 20:59:28 +02:00

stmp_device.c

…

string_helpers.c

string: uninline memcpy_and_pad

2021-11-21 13:44:12 +01:00

string.c

…

strncpy_from_user.c

…

strnlen_user.c

…

syscall.c

…

test_bitmap.c

…

test_bitops.c

…

test_bits.c

…

test_blackhole_dev.c

…

test_bpf.c

test_bpf: fix incorrect netdev features

2022-08-17 14:23:23 +02:00

test_debug_virtual.c

…

test_firmware.c

test_firmware: fix a memory leak with reqs buffer

2023-06-21 15:59:12 +02:00

test_fpu.c

…

test_free_pages.c

…

test_hash.c

…

test_hexdump.c

…

test_hmm_uapi.h

…

test_hmm.c

lib/test_hmm: avoid accessing uninitialized pages

2022-08-17 14:23:43 +02:00

test_ida.c

…

test_kasan_module.c

…

test_kasan.c

kasan: test: Silence GCC 12 warnings

2022-08-17 14:23:05 +02:00

test_kmod.c

lib/test: use after free in register_test_dev_kmod()

2022-04-08 14:23:54 +02:00

test_linear_ranges.c

…

test_list_sort.c

…

test_lockup.c

lib/test_lockup: fix kernel pointer check for separate address spaces

2022-04-08 14:24:01 +02:00

test_memcat_p.c

…

test_meminit.c

lib/test_meminit: destroy cache in kmem_cache_alloc_bulk() test

2022-01-27 11:05:44 +01:00

test_min_heap.c

…

test_module.c

…

test_objagg.c

…

test_overflow.c

overflow: Implement size_t saturating arithmetic helpers

2022-12-31 13:14:33 +01:00

test_parman.c

…

test_printf.c

Merge branch 'akpm' (patches from Andrew)

2021-09-08 12:55:35 -07:00

test_rhashtable.c

…

test_scanf.c

lib/test_scanf: split up number parsing test routines

2021-09-06 11:04:03 -07:00

test_siphash.c

…

test_sort.c

lib/test: convert test_sort.c to use KUnit

2021-09-08 11:50:26 -07:00

test_stackinit.c

…

test_static_key_base.c

…

test_static_keys.c

…

test_string.c

…

test_strscpy.c

…

test_sysctl.c

…

test_ubsan.c

ubsan: remove CONFIG_UBSAN_OBJECT_SIZE

2022-04-13 20:59:27 +02:00

test_user_copy.c

…

test_uuid.c

…

test_vmalloc.c

…

test_xarray.c

XArray: Fix xas_create_range() when multi-order entry present

2022-04-08 14:24:09 +02:00

test-kstrtox.c

…

test-string_helpers.c

…

textsearch.c

…

timerqueue.c

…

ts_bm.c

…

ts_fsm.c

…

ts_kmp.c

…

ubsan.c

panic: Consolidate open-coded panic_on_warn checks

2023-02-01 08:27:22 +01:00

ubsan.h

…

ucmpdi2.c

…

ucs2_string.c

…

usercopy.c

uaccess: Add speculation barrier to copy_from_user()

2023-02-25 12:06:44 +01:00

uuid.c

…

vsprintf.c

random: replace custom notifier chain with standard one

2022-05-30 09:29:10 +02:00

win_minmax.c

…

xarray.c

XArray: Update the LRU list in xas_split()

2022-04-08 14:24:09 +02:00

xxhash.c

…