Pierre-Eric Pelloux-Prayer 65501a4fd8 drm/amdgpu: don't access invalid sched ...

[ Upstream commit a93b1020eb ]

Since 2320c9e6a7 ("drm/sched: memset() 'job' in drm_sched_job_init()")
accessing job->base.sched can produce unexpected results as the initialisation
of (*job)->base.sched done in amdgpu_job_alloc is overwritten by the
memset.

This commit fixes an issue when a CS would fail validation and would
be rejected after job->num_ibs is incremented. In this case,
amdgpu_ib_free(ring->adev, ...) will be called, which would crash the
machine because the ring value is bogus.

To fix this, pass a NULL pointer to amdgpu_ib_free(): we can do this
because the device is actually not used in this function.

The next commit will remove the ring argument completely.

Fixes: 2320c9e6a7 ("drm/sched: memset() 'job' in drm_sched_job_init()")
Signed-off-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 2ae520cb12)
Signed-off-by: Sasha Levin <sashal@kernel.org>

2024-12-27 13:52:57 +01:00

..

drm

drm/amdgpu: don't access invalid sched

2024-12-27 13:52:57 +01:00

host1x

gpu: host1x: Do not setup DMA for virtual devices

2024-05-17 11:56:07 +02:00

ipu-v3

…

trace

…

vga

…

Makefile

…